From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com [209.85.214.178]) by dpdk.org (Postfix) with ESMTP id 212479A8E for ; Tue, 16 Feb 2016 07:10:09 +0100 (CET) Received: by mail-ob0-f178.google.com with SMTP id jq7so59201678obb.0 for ; Mon, 15 Feb 2016 22:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=wbB0OWSHytluYd4WgnskRbo/8JUbEGHEeFKPXJepVqQ=; b=H3G8xX+Fm8yLhclURpbcWFMCjWQ4y+jJZar95/WJNO3h/8ncwAkQUvb7BCTB7BTHJ8 s/tDLu372AyR9PJYcp4CUCSyshZ+QhW4WruxofbZfAV2kRct1BZtjTPIMKQdYXkddbT5 6aHI0PjrmecfcnJVORxAhBQhjmmoEsPk9pLM8rqrN5GE0VzqveoHuXyqUieJG0z9BR4b Jb7Za6bLIEeCWz4jWO6IF5yYCcf8HOSS4DN7zmX96l0Oa32gOr81vHnlddZM1nrwJ9y3 zO1UPPEHdihHqlgd88bk3dr2WuNBGDuOApESJ6qOmQ6VpravghAcN+UhtE+1mCJ3DIDa piDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=wbB0OWSHytluYd4WgnskRbo/8JUbEGHEeFKPXJepVqQ=; b=Xw2Xq4xon9iT7kJ/P//Mbr2WnE8latmkz0GOagBzn/3Bdlt12VW/qniXxi8arz5uZ+ K2QEUH4v9XkJfO/1FX3R7c7sv5Xr0b+uBZwjbQVGxhD78gLHadkLSIdLfS/2fwOI9iy6 MzZdNY9JDuYj6V6uUkGmrCXifXG9+9c02lxPVvimI7E/6LFpb+HcvUCwIILhg56e9IhM Ejjd9qknBTBc2xumrSv5wLtAaSEd2PvPk9Bw75obL3YZsNpSUrY71wLjUzfW4KXzgTFo Ao73kedplGP8dTnZ+I3yc+KjxHp9kMkdriaFFZKgkeyiakKzXkxouPbcxOH6ZtKX6skd t8uA== X-Gm-Message-State: AG10YOSlIROfPSMC/mguiLeR+7rUNVc78dFXjTd7BfzuepMGW5lI7kcfSZS+mp9QMIsn1e9udPE8cq6RsoO50kwy X-Received: by 10.60.246.37 with SMTP id xt5mr15907080oec.72.1455603008633; Mon, 15 Feb 2016 22:10:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Mon, 15 Feb 2016 22:09:49 -0800 (PST) In-Reply-To: <20160216023622.GD21426@yliu-dev.sh.intel.com> References: <1454831317-4542-1-git-send-email-david.marchand@6wind.com> <1455542666-28895-1-git-send-email-david.marchand@6wind.com> <1455542666-28895-4-git-send-email-david.marchand@6wind.com> <20160216023622.GD21426@yliu-dev.sh.intel.com> From: David Marchand Date: Tue, 16 Feb 2016 07:09:49 +0100 Message-ID: To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 3/4] eal: introduce pci ioport api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2016 06:10:09 -0000 On Tue, Feb 16, 2016 at 3:36 AM, Yuanhan Liu wrote: > On Mon, Feb 15, 2016 at 02:24:25PM +0100, David Marchand wrote: >> +/** >> + * A structure used to access io resources for a pci device. >> + * rte_pci_ioport is arch, os, driver specific, and should not be used outside >> + * of pci ioport api. >> + */ >> +struct rte_pci_ioport { >> + struct rte_pci_device *dev; >> + uint64_t offset; >> +}; > > "offset" dosen't sound like a good name to me; espeicially when I found > code like below: > > reg = p->offset + offset; > > Regarding that, maybe "base" is a better name? I don't like it too much, > though. Any better idea? Hum, yes, base sounds better, and I have no better idea, will go with this unless someone else complains. > Otherwise, this patch looks good to me. Thanks. I will respin this patchset and if nobody is against this, I think this patchset should be pulled quickly because other patches depend on it. -- David Marchand