From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com [209.85.218.43]) by dpdk.org (Postfix) with ESMTP id DEACE5A1F for ; Wed, 21 Jan 2015 14:08:02 +0100 (CET) Received: by mail-oi0-f43.google.com with SMTP id z81so9022441oif.2 for ; Wed, 21 Jan 2015 05:08:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=X3NP8hf/szstbV4NCx/o1g7kmZ58kE6MaF0XHXXgYnk=; b=GMzHaEeEad10Kf12epRRP3NsLL4XNOmkM02IhNJqYTAOfoVN7TcIWH3ic+7DBld+Df HHLHvWnHd3CaMfhnvlASrpVIHxJRbUvzG9ltJvFHohvwQq+arWrkTXVWSZKGv2L7UZtz 0GAe8wQyYckmdOPMQ4go5sqe+5yHY1mGKfVotOOxWDarL/zw7q+EYCeX6yQ/GCxswuhh HHfiy/K79EdelkkAWz8ZwfBqQdxZ+jfC1sJX54KJcAEh1fg1saLuuOD+GWVc7231kemm N8x3CtzRnmjitHK1FOt7QKMyVvmYKN+Zkjk0XrHbQrYDGfsiU6BU5WbRiJPLBzrvjCkN uOkQ== X-Gm-Message-State: ALoCoQl/dqgUgHtb74j5aglxpAfTO+I8Tag0QBrLF7aGZsOQ3IfFPohysk9M7YltEh3EWIG7gvuc MIME-Version: 1.0 X-Received: by 10.182.165.9 with SMTP id yu9mr24472945obb.34.1421845682198; Wed, 21 Jan 2015 05:08:02 -0800 (PST) Received: by 10.76.95.198 with HTTP; Wed, 21 Jan 2015 05:08:02 -0800 (PST) In-Reply-To: <1421813818-2354-1-git-send-email-stephen@networkplumber.org> References: <1421813818-2354-1-git-send-email-stephen@networkplumber.org> Date: Wed, 21 Jan 2015 14:08:02 +0100 Message-ID: From: David Marchand To: Stephen Hemminger Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" , Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH] stats: remove useless memset's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2015 13:08:03 -0000 Hello Stephen, On Wed, Jan 21, 2015 at 5:16 AM, wrote: > From: Stephen Hemminger > > The rte_eth_stats_get is the only API that should call the device > statistics function directly, and it already does a memset of the > resulting structure. Therefore doing memset() in the driver is > redundant and should be removed. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_pmd_af_packet/rte_eth_af_packet.c | 2 -- > lib/librte_pmd_bond/rte_eth_bond_pmd.c | 4 ---- > lib/librte_pmd_enic/enic_main.c | 1 - > lib/librte_pmd_i40e/i40e_ethdev_vf.c | 1 - > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 1 - > lib/librte_pmd_ring/rte_eth_ring.c | 1 - > 6 files changed, 10 deletions(-) > I think you missed some : - lib/librte_pmd_e1000/igb_ethdev.c function eth_igbvf_stats_get() - lib/librte_pmd_pcap/rte_eth_pcap.c function eth_stats_get() With these fixed : Acked-By: David Marchand -- David Marchand