From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f179.google.com (mail-ob0-f179.google.com [209.85.214.179]) by dpdk.org (Postfix) with ESMTP id A2D469A88 for ; Tue, 9 Feb 2016 10:04:42 +0100 (CET) Received: by mail-ob0-f179.google.com with SMTP id wb13so182668079obb.1 for ; Tue, 09 Feb 2016 01:04:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=fL0PNAERYrai0u1Q2swpKFhLwALSMMcEwcOFtawqBNg=; b=N84M0xkJaH9k+3LFbdJ6KCV8EqL4SarNhanrStGc1HClaWH6v+foq0x+jdu0IjMGd5 W7lY3MzibPn+VAzu0Rr7jhN7r1kkaIwb7Uq3OWt7VHwQXhzGXjx6Hl6w0BudAFcS6GcV 53yCA/ye1sGDnUxtLPqzb92oJcm9ZdUa2khZlMtCfP9hcrZl2XKbdzny++lW31DW/Rwh Em0IfGz0SIfGqTKdWtRfE12xEYvHlf2cs5wsHb+aSLTdsMPKoRC9av6app4JHAzZrHbQ B/PUF/DkuG0NJ2nwHioIV7AZEQiZPJQYFe5Oju8RXYg9tDsbt1cyzWzAi8WTD0AzhycM KsvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=fL0PNAERYrai0u1Q2swpKFhLwALSMMcEwcOFtawqBNg=; b=If4awlQjHmmepAMl27qp+r3BjQVe2HMA0sdnkBYuD+nT1jQdQvaKUeT7kBfL0dK2/+ gYXJwk+Gw1+D7Ul5qgRH5Hi5eoFLhaevgZCgSCr6iKPluIVMtufwAgu8Pk4VHKzeDOX+ 6yv5Ej36J7t4qDpdNJJoeJpFtAjFx0i2wcnGViq7TR62zuRjFmP3HvqGjDwS1so43vgC iB+q1q/MPVBmay0sv5kCX4SXX2DPJykUvxxrMmJMKZEJCrTAT/0GF6st8frv64F2xJhI Kz/zqwIctuII0jivyQacgtmIGBBinZrRxlKx5u62EIgCWx2s+epdrsgsGM7pyBl1HFIK UV9w== X-Gm-Message-State: AG10YOQffG50wbnd8vlXwyita2MNR2m4/ToL6cqVqPJEbtaxUB0NKQFLabVEl9FLqQLYdzkFbiHi/HLHNrha/rmH X-Received: by 10.60.127.166 with SMTP id nh6mr28354755oeb.64.1455008682120; Tue, 09 Feb 2016 01:04:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Tue, 9 Feb 2016 01:04:22 -0800 (PST) In-Reply-To: References: <1454925815-14292-1-git-send-email-sshukla@mvista.com> <1454925815-14292-2-git-send-email-sshukla@mvista.com> From: David Marchand Date: Tue, 9 Feb 2016 10:04:22 +0100 Message-ID: To: Santosh Shukla Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v8 4/4] eal/linux: vfio: add pci ioport support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2016 09:04:43 -0000 On Mon, Feb 8, 2016 at 3:13 PM, Burakov, Anatoly wrote: >> Include vfio map/rd/wr support for pci ioport. >> >> Signed-off-by: Santosh Shukla >> --- >> v7->v8: >> - Remove rte_pci_ioport malloc and rte_free()/unmap() func from v7. >> - removed umap from git header. >> >> lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 36 ++++++++++++++++++------- >> --- >> 1 file changed, 24 insertions(+), 12 deletions(-) >> >> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >> b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >> index 4832313..9571ed8 100644 >> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >> @@ -74,6 +74,7 @@ EAL_REGISTER_TAILQ(rte_vfio_tailq) >> #define VFIO_GROUP_FMT "/dev/vfio/%u" >> #define VFIO_NOIOMMU_GROUP_FMT "/dev/vfio/noiommu-%u" >> #define VFIO_GET_REGION_ADDR(x) ((uint64_t) x << 40ULL) >> +#define VFIO_GET_REGION_IDX(x) (x >> 40) >> >> /* per-process VFIO config */ >> static struct vfio_config vfio_cfg; >> @@ -999,30 +1000,41 @@ int >> pci_vfio_ioport_map(struct rte_pci_device *dev, int bar, >> struct rte_pci_ioport *p) >> { >> - RTE_SET_USED(dev); >> - RTE_SET_USED(bar); >> - RTE_SET_USED(p); >> - return -1; >> + if (bar < VFIO_PCI_BAR0_REGION_INDEX || >> + bar > VFIO_PCI_BAR5_REGION_INDEX) { >> + RTE_LOG(ERR, EAL, "invalid bar (%d)!\n", bar); >> + return -1; >> + } >> + >> + p->dev = dev; >> + p->offset = VFIO_GET_REGION_ADDR(bar); >> + return 0; >> } >> I still think we don't need this p->dev = dev. But that's not important. > Acked-by: Anatoly Burakov Acked-by: David Marchand -- David Marchand