From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f195.google.com (mail-yw0-f195.google.com [209.85.161.195]) by dpdk.org (Postfix) with ESMTP id 028AD1B4F4 for ; Fri, 13 Jul 2018 10:10:03 +0200 (CEST) Received: by mail-yw0-f195.google.com with SMTP id t198-v6so11451892ywc.3 for ; Fri, 13 Jul 2018 01:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GMbDFzetW6+GGUNdaWWFLXOpqsu3ipDnsihLKT1M+VU=; b=rz4ZkvQdjxova/qeJiNxbFCmGxiIGJSnFGaX/i1mjv2NUVubpkB86oXDsIkRldFtrV glkpQaffa65P5/pzAPuZuBAuqhYK6HNFAzhRZlDDSApg9M12gyLnQZgdijm8GGsaiYFI hzw+S47d+cf3VfiapCvpuzi0nez0PoB3MiR/6J4VqiO9mkLxMCcctKJO0xGBpdegSBl3 9W0foSi6SpkNcsFoG5TqdOioojpDxPvhr/C52LGH3Vr6h7U8DLL4qveMaWiD+Ao+WnAJ w8CsLXHqSMb1vNdW88uL5++el6dYj3RY5j1v+KH1r+TS7l71UBfuLAdFzsY12sFAiAKC UjbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GMbDFzetW6+GGUNdaWWFLXOpqsu3ipDnsihLKT1M+VU=; b=q2KYLim3XmnOueWTCgppLYpMEo3JvXfJ1nmWWMHCb/vpVIIixiVHA+pb/PcO18Ht5B Z4Zi7fpC4ERTECeYZzJPeGn6k7PeyBaTTAu3pqWW3lsIUG9k4KDqPsgxk3cd73u0F8Xj 92MvIFgViLvNbkgodCN5DSbMYlMh4nCX4hD0tchsrIYgJ6G/I9R41H9yznFhoKjf+8JS GHKthbdlk+0XpnnsCeqSw6JXiQTJhmD6uRuQh3HTl21P1NEntSSl0RL/SGbaqtZjN07a t/Xp0oaf3cXtaFI3x2tr8iGFdSCwVpSMlmCNVLa+xNiRK5TLJGUcThGi6Ih35bEs3I4E XZfQ== X-Gm-Message-State: AOUpUlGqJTusluMM2TlDLfbawQbEDN7rIxTWLbYaTx4ctMU6O0Jyu+D2 VG/60qVG7RyLCpa8kUzth6bdYetC4A+yvJljVBe9GA== X-Google-Smtp-Source: AAOMgpehp2IG3EhE978eNO9E0VCTxQpUxVNWzBoeDpFjsnkP1YQJYEXxS+j2AQ5u02ra0uN/xJCNFDt4xmZ0E47JK+4= X-Received: by 2002:a0d:f3c7:: with SMTP id c190-v6mr2708333ywf.98.1531469403205; Fri, 13 Jul 2018 01:10:03 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:a282:0:0:0:0:0 with HTTP; Fri, 13 Jul 2018 01:09:42 -0700 (PDT) In-Reply-To: <5431396.k1M6VaMcRs@xps> References: <5f6bc60bf193daf4eb07f4484c52878bb1b751de.1530009564.git.anatoly.burakov@intel.com> <5431396.k1M6VaMcRs@xps> From: David Marchand Date: Fri, 13 Jul 2018 10:09:42 +0200 Message-ID: To: Thomas Monjalon Cc: Anatoly Burakov , dev@dpdk.org, Jianfeng Tan , Bruce Richardson , "Ananyev, Konstantin" , qi.z.zhang@intel.com, Stephen Hemminger , Olivier Matz , Ferruh Yigit , Maxime Coquelin , tiwei.bie@intel.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 5/7] eal: bring forward init of interrupt handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 08:10:04 -0000 On Fri, Jul 13, 2018 at 12:36 AM, Thomas Monjalon wrote: > I am almost sure it will bring regressions. > > Please think again about the consequences of initializing interrupt thread > before affinity setting, memory init, device init. Well, there was an issue vith virtio at one time (interrupt handler did not have the right iopl for virtio callback). http://git.dpdk.org/dpdk/commit/lib/librte_eal/linuxapp/eal/eal.c?id=fd6949c55c9a48e81c625138679159829d51ac51 Now... time has passed since then. It is worth checking the issue is still here, and if it is the case, revisit this. I suppose virtio pmd should deal with this itself. -- David Marchand