From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-oi0-f41.google.com (mail-oi0-f41.google.com
[209.85.218.41]) by dpdk.org (Postfix) with ESMTP id 69BED5A6F
for <dev@dpdk.org>; Mon, 15 Jun 2015 16:04:23 +0200 (CEST)
Received: by oiax193 with SMTP id x193so1647754oia.2
for <dev@dpdk.org>; Mon, 15 Jun 2015 07:04:22 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:mime-version:in-reply-to:references:date
:message-id:subject:from:to:cc:content-type;
bh=G4Db7m9P9Eje7ZTGTnHYSAxfXuaUjTk0W6VGnhwQ3gk=;
b=F+1vxjx7ySd8lMtdB2HOuHAA0YJAVr/41HODD52reTKIxG9YsyBkqVbWclOb0cnGDA
woYOtyhkq3ky1VM0DvvlDefDIcJBcY3slASIi6ELydbAcWA/CgkxzTofhKTuIiCg2dYL
D5ejEpYtKtaFkr3Y5/3kVO0i5H3j/wDSoL8m3/BgxyMzRoRHnWZoC4bo1gTkN2wJddw7
xhiTjiBZiFuqz3JJLKjvHDqPk2MsmlQsfEXqkjfdOgCKRwSKI1y//3ig45E8A2k0hrh3
TeEKeTgpNMfo8TwXBRgHZhj4Bl1ocS84aiSJwkNe5gSNZOqGt6P/XQ9QmvyBlv26K3/9
1xPw==
X-Gm-Message-State: ALoCoQkuPx4Jyk5lihoPNLAum3tJc029VVlBnkrEjWcjEqb7xifPc9FHGr9C7EVY0i+w6U1KIFI9
MIME-Version: 1.0
X-Received: by 10.202.178.70 with SMTP id b67mr22348158oif.0.1434377062870;
Mon, 15 Jun 2015 07:04:22 -0700 (PDT)
Received: by 10.76.25.69 with HTTP; Mon, 15 Jun 2015 07:04:22 -0700 (PDT)
In-Reply-To: <20150527113016.2c31ba7e@miho>
References: <20150527113016.2c31ba7e@miho>
Date: Mon, 15 Jun 2015 16:04:22 +0200
Message-ID: <CALwxeUvz97mz8ORqdETeQvirCAO1wtA5=nTSRzgTn2HDzzk66g@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Simon Kagstrom <simon.kagstrom@netinsight.net>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] eal: Allow combining -m and --no-huge
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Jun 2015 14:04:23 -0000
On Wed, May 27, 2015 at 11:30 AM, Simon Kagstrom <
simon.kagstrom@netinsight.net> wrote:
> Needed to run as non-root but with higher memory allocations, and
> removes a constraint on no-huge mode being limited to 64M. A usage
> example is if running with file input with the pcap PMD, which can be
> done as non-root after this patch via e.g.,
>
> ./test-dpdk --no-huge -m 1024 -l 0,1 -n3 --vdev
> 'eth_pcap0,rx_pcap=/tmp/eth-rx.pcap,tx_pcap=/tmp/eth-tx.pcap'
>
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> Signed-off-by: Johan Faltstrom <johan.faltstrom@netinsight.net>
> ---
> v2:
> * Remove unneeded parentheses and merge lines
>
> * Patch prefix now eal:
>
> * Add example and more description (from David Marchand)
>
> lib/librte_eal/common/eal_common_options.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c
> b/lib/librte_eal/common/eal_common_options.c
> index 8fcb1ab..1f459ac 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -850,9 +850,8 @@ eal_check_common_options(struct internal_config
> *internal_cfg)
> "be specified at the same time\n");
> return -1;
> }
> - if (internal_cfg->no_hugetlbfs &&
> - (mem_parsed || internal_cfg->force_sockets == 1)) {
> - RTE_LOG(ERR, EAL, "Options -m or --"OPT_SOCKET_MEM" cannot
> "
> + if (internal_cfg->no_hugetlbfs && internal_cfg->force_sockets ==
> 1) {
> + RTE_LOG(ERR, EAL, "Option --"OPT_SOCKET_MEM" cannot "
> "be specified together with --"OPT_NO_HUGE"\n");
> return -1;
> }
> --
> 1.9.1
>
Acked-by: David Marchand <david.marchand@6wind.com>
--
David Marchand