From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com [209.85.214.169]) by dpdk.org (Postfix) with ESMTP id E8EFB2C72 for ; Mon, 8 Feb 2016 09:51:46 +0100 (CET) Received: by mail-ob0-f169.google.com with SMTP id wb13so145409793obb.1 for ; Mon, 08 Feb 2016 00:51:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=QxiV6RjKc38Goiu7iLWm4ldVeE7ZtHDL2CnPXW3aZxI=; b=UaT/vhhqw1f+dBHa8/nbuZDkAkumvnnORyQkNeriHFrRv5uBN/1gMuVwatSRh7LTLQ 7KhCC6P9I7CPsOWx+IJAUoN+cOQErt+E8eIiYCFCED/nVh93H0C8Rpt80tusmOAj3+ix 4WUzDiAe8Gkam4n0enSmSYgjTWiXzYlLbxkiMNYeT9VihqJoa+OKB2/i2KJ3M1B1pxRY ujcjZBv7hVu062ay2OUl5K5r714tUD3tf68skcjUDb5h25gjh+Yra8djrMAZyyGzEteh VTMdWbc/dVTH2UJKtph98BcuW6K5kWQ+axlD+mDSprQ9K3pscCSpXlA9ntE0rY3zxofI dDfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=QxiV6RjKc38Goiu7iLWm4ldVeE7ZtHDL2CnPXW3aZxI=; b=hWnuoi8QbPnvjxo1xu0xMHwaUH5npQkwjWy1kWbopS3/hyMD2P5ii7vyTJTezCnvlz 23awGXlV8o5GOHd6dNpmWJrUliQF0iWTkgNUeLuOU9xIpGBMWqW8a+npsliOtbxWL4Ss 2AHByzayqJ/ITOF+RUF14MSq3KNCvtW/6K0X8ALdVZms5asAK+shb42a1U1nLg3tjKUd tdP1lLzf9cqMUScH1r66fuLusUxhZCtcaTb1IjiCkiQMWKUFsJVwrG47/gpHK6Z3PgrT uNX7DxNH1YD0ziPa2OtGXbWNPP1XlSp8dHFT9oDRk/lxe7ebhpwWYZrRB3YJbQvU+c6G rYHg== X-Gm-Message-State: AG10YORdwu03RbI5X09URpGlM1A8K1mmYywdzmMXx3O7jJDeDzRe7iZCRtnYmN3DOTE+FIBVApj7tVJsUOouKVYd X-Received: by 10.182.103.167 with SMTP id fx7mr22971740obb.36.1454921506419; Mon, 08 Feb 2016 00:51:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Mon, 8 Feb 2016 00:51:26 -0800 (PST) In-Reply-To: <1454853068-14621-5-git-send-email-sshukla@mvista.com> References: <1454853068-14621-1-git-send-email-sshukla@mvista.com> <1454853068-14621-5-git-send-email-sshukla@mvista.com> From: David Marchand Date: Mon, 8 Feb 2016 09:51:26 +0100 Message-ID: To: Santosh Shukla Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 4/4] eal/linux: vfio: add pci ioport support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2016 08:51:47 -0000 On Sun, Feb 7, 2016 at 2:51 PM, Santosh Shukla wrote: > @@ -999,37 +1000,56 @@ int > pci_vfio_ioport_map(struct rte_pci_device *dev, int bar, > struct rte_pci_ioport *p) p is passed as a value, not a reference ... > { > - RTE_SET_USED(dev); > - RTE_SET_USED(bar); > - RTE_SET_USED(p); > - return -1; > + if (bar < VFIO_PCI_BAR0_REGION_INDEX || > + bar > VFIO_PCI_BAR5_REGION_INDEX) { > + RTE_LOG(ERR, EAL, "invalid bar (%d)!\n", bar); > + return -1; > + } > + > + p = rte_zmalloc("VFIO_IOPORT", sizeof(*p), 0); ... so I don't think this allocation does what you expected. Anyway, you don't need to allocate a rte_pci_ioport object with current api. You already have a valid object passed by caller. You only need to initialise it. > + if (p == NULL) { > + RTE_LOG(ERR, EAL, "cannot alloc vfio ioport mem\n"); > + return -1; > + } > + > + p->dev = dev; Does not hurt to do this, but p->dev is already set by caller on ret == 0 (rte_eal_pci_ioport_map). > > void > pci_vfio_ioport_read(struct rte_pci_ioport *p, > void *data, size_t len, off_t offset) > { > - RTE_SET_USED(p); > - RTE_SET_USED(data); > - RTE_SET_USED(len); > - RTE_SET_USED(offset); > + const struct rte_intr_handle *intr_handle = &p->dev->intr_handle; Missing blank line between declaration and code. > + if (pread64(intr_handle->vfio_dev_fd, data, > + len, p->offset + offset) <= 0) > + RTE_LOG(ERR, EAL, > + "Can't read from PCI bar (%" PRIu64 ") : offset (%x)\n", > + VFIO_GET_REGION_IDX(p->offset), (int)offset); > } > > void > pci_vfio_ioport_write(struct rte_pci_ioport *p, > const void *data, size_t len, off_t offset) > { > - RTE_SET_USED(p); > - RTE_SET_USED(data); > - RTE_SET_USED(len); > - RTE_SET_USED(offset); > + const struct rte_intr_handle *intr_handle = &p->dev->intr_handle; Idem. > + if (pwrite64(intr_handle->vfio_dev_fd, data, > + len, p->offset + offset) <= 0) > + RTE_LOG(ERR, EAL, > + "Can't write to PCI bar (%" PRIu64 ") : offset (%x)\n", > + VFIO_GET_REGION_IDX(p->offset), (int)offset); > } > > int > pci_vfio_ioport_unmap(struct rte_pci_ioport *p) > { > - RTE_SET_USED(p); > - return -1; > + if (p == NULL) > + return -1; > + else { > + rte_free(p); > + return 0; > + } > } Since you have nothing to allocate, nothing to free here ? -- David Marchand