From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 540F9A04DD; Thu, 28 Nov 2019 02:19:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 16FF51BF6C; Thu, 28 Nov 2019 02:19:02 +0100 (CET) Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by dpdk.org (Postfix) with ESMTP id 90EC51B9B7 for ; Thu, 28 Nov 2019 02:19:00 +0100 (CET) Received: by mail-oi1-f193.google.com with SMTP id j7so21882785oib.3 for ; Wed, 27 Nov 2019 17:19:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Rvd7TEA7rbVgWmOzKqjjxumTjSs3tTdfAQi0bCAAZnY=; b=JY+x4jY9tLOU4eyRCy35lbxy5wipY2n/GEf0ru71uta6GTXyUuOVKN5tJndCX+njKD TR5WuCl9GZ9QOZN2xxgTb0k6+/G33EGkmocUwK3WY2WY37JDxz57+eV8DtWh6RucPhCB 3Q7AzurcKWGCUW8VwyzWou5fVsKQGJbuaAd5aUX1QoWDseTcHbjtXdmn9ZU04L8OM5c7 /xAkuOmOM/Dh0SVmOfTjdHfvZHes/AYcpfzeTLtf88q0EC0xKCbse+lYRs6yWHvgFOyQ ApfLFv/EE4PAGu6P+DAY3tv5GX6kg/Dq1Kx6maqQx4zAOWbzvVsuv7wN9DxYxiIN0Scn gB8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Rvd7TEA7rbVgWmOzKqjjxumTjSs3tTdfAQi0bCAAZnY=; b=ruMFzWyMnosd0UNUdtHCUmds8DiRRDVtVnEpwxHPOTivVKXqd2gF8a11vXd9J7PWd9 +POtZ9hk53hBDU5ElKk7lLQrIzNsa09qQzU6geYsEIGX+Fcuyl2HpRs+CqMkEgUPoSg5 l+8/+XKyvZlCj47ycYMEIMASAzKZtorc8AjQ87/O+3wNYUCwcYq6qtNLrEK8GOGT8nsf Ad02nBRIe/YPwlCglyvVCrmqpPG14srvF492ji73qi3qCjLveg2VbRmIfx4U71F7u60B JHg4RlopBt4nBGYNkFIwFrwcaFWrW46N2orgnLyhNu49yDXg24AvnUt7ovu7i6fO7YOj DeRQ== X-Gm-Message-State: APjAAAVobSJhVPOuwCj65UDOwRusIt2KNIFRRg5RytRFg/336NMHRT1j VjknapLaS2tQFy51NLSINrVK8hV/gfaD7XAXWnE= X-Google-Smtp-Source: APXvYqz9bh9ucnmx1wLJQJ0V4ZjA9DvZiJxLmt6X65lSQQKc+TjFffuhXhhvCOix2MXboVYtyQ2PiZjX9VRWKmMxDTg= X-Received: by 2002:aca:4742:: with SMTP id u63mr6591652oia.177.1574903939888; Wed, 27 Nov 2019 17:18:59 -0800 (PST) MIME-Version: 1.0 References: <1574864323-85580-1-git-send-email-xiangxia.m.yue@gmail.com> <1574864323-85580-3-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: From: Tonghao Zhang Date: Thu, 28 Nov 2019 09:18:23 +0800 Message-ID: To: Ori Kam Cc: "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH dpdk-dev 3/3] net/mlx5: remove the assert for rxq cq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 27, 2019 at 10:52 PM Ori Kam wrote: > > This patch is not correct, > You are using old code. This was already solved. Thanks for your review, and tips > Thanks, > Ori > > > -----Original Message----- > > From: xiangxia.m.yue@gmail.com > > Sent: Wednesday, November 27, 2019 4:19 PM > > To: dev@dpdk.org > > Cc: Tonghao Zhang ; Ori Kam > > > > Subject: [PATCH dpdk-dev 3/3] net/mlx5: remove the assert for rxq cq > > > > From: Tonghao Zhang > > > > The mlx5_rxq_obj_hairpin_new doesn't alloc the > > cq anymore. When releasing it, don't check it. > > > > Fixes: e79c9be91515 ("net/mlx5: support Rx hairpin queues") > > Cc: Ori Kam > > Signed-off-by: Tonghao Zhang > > --- > > drivers/net/mlx5/mlx5_rxq.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > > index 2a12d5fa3436..582a2330e575 100644 > > --- a/drivers/net/mlx5/mlx5_rxq.c > > +++ b/drivers/net/mlx5/mlx5_rxq.c > > @@ -673,7 +673,6 @@ mlx5_rxq_obj_release(struct mlx5_rxq_obj > > *rxq_obj) > > assert(rxq_obj); > > if (rxq_obj->type == MLX5_RXQ_OBJ_TYPE_IBV) > > assert(rxq_obj->wq); > > - assert(rxq_obj->cq); > > if (rte_atomic32_dec_and_test(&rxq_obj->refcnt)) { > > switch (rxq_obj->type) { > > case MLX5_RXQ_OBJ_TYPE_IBV: > > -- > > 2.23.0 > > >