From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f196.google.com (mail-ot0-f196.google.com [74.125.82.196]) by dpdk.org (Postfix) with ESMTP id 612372B9C for ; Fri, 23 Mar 2018 02:53:47 +0100 (CET) Received: by mail-ot0-f196.google.com with SMTP id h26-v6so4227823otj.12 for ; Thu, 22 Mar 2018 18:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=52vouphkkp32dkE8FEfZCqElYNuqqTj39tzOOTKC44o=; b=rjykoI9h5/97e7kKgb8RgEyBxBgMNBKlPpgPkZ5EXu5I0ZOmidsGw1N8ESHzD+8e54 ivNa5MHw0XtcKcI1eWXyaiOEfUusNSDDLUTvpxbi33ejGauP8d0TuZAOe2WyaipedJ0b Ua4ey5OODBoDbJ+yKqHQk2RNnWAJQpEpTchGSOPGG1rmcdz29cXjI+JUFtulxmKyGsN9 /mc2VUaqsE05BrmI6EbQNFcnN/qPDz38lsRxFRSAup+qTdHCCuFwVW896nT+RUq7VWF4 OBDR7BUDjsJW5IzQwceNMVGGcpHozzsRFCc+ymZ/7d525CBGjvCsTpXw8/m7ZAae/+Zq M8jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=52vouphkkp32dkE8FEfZCqElYNuqqTj39tzOOTKC44o=; b=IOtctekuuhOE5XUIYy5T6fnLoSsGeozvy5Ik9yWyY34XMoYkjSX58X8Ok9Ev9ve6jQ PfPgjgk4mMwTbWZ+u0so/2REt1dtX/RoabJ1L+aIwK8FOsjMxmlb43kPho6R/0uLuNh9 jEF2kYIfJlZoei0SXsQzMoH8XiqpFbnU5Fq3ij2aQaK7QqH0FDiDTkh/XI/cWqXSG2I/ w469ZZSpom3GpPZfGgQcwnjoO+6rX0y1ZMGdlcOTBvWr/ODxxtZkZ/oEsOel7TSjUef7 zk0X99JheR3OMOq43bW+BRrCKRxiGtNJrWTylrYTnqYP+TWm2krqZS2cOe3qRGGzdm6v fs4Q== X-Gm-Message-State: AElRT7EFuXHqvh+Bjxextj+GnijhdA5m1eUu2n4DTCJ88IyHA0QqTT2z uyO67+j5J9T1LiM3ZcfVCR61grmovCfrWE2OId0= X-Google-Smtp-Source: AG47ELtkN8hGt4yJvpin2q02SYiKfP4wpeyU439Jqo5PEa5wQfvy+WZ+/7usxJCo61JtVMrVZseW4Fp1ofCMccRAxUI= X-Received: by 2002:a9d:1920:: with SMTP id j32-v6mr15935655ota.383.1521770026537; Thu, 22 Mar 2018 18:53:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.198.16 with HTTP; Thu, 22 Mar 2018 18:53:46 -0700 (PDT) In-Reply-To: References: <1521722398-93353-1-git-send-email-xiangxia.m.yue@gmail.com> From: Tonghao Zhang Date: Fri, 23 Mar 2018 09:53:46 +0800 Message-ID: To: "Tan, Jianfeng" Cc: "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] vhost: make sure vhost fdset-thread created successfully X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 01:53:47 -0000 On Fri, Mar 23, 2018 at 9:30 AM, Tan, Jianfeng wrote: > Hi Xiangxia, > >> -----Original Message----- >> From: xiangxia.m.yue@gmail.com [mailto:xiangxia.m.yue@gmail.com] >> Sent: Thursday, March 22, 2018 8:40 PM >> To: Tan, Jianfeng >> Cc: dev@dpdk.org; Tonghao Zhang >> Subject: [PATCH 1/2] vhost: make sure vhost fdset-thread created >> successfully >> >> From: Tonghao Zhang >> >> When first call the 'rte_vhost_driver_start', the >> fdset_event_dispatch thread should be created successfully. >> Because the vhost uses it to poll socket events for vhost >> server or clients. Without it, for example, vhost will not >> get the connection event. >> >> This patch returns err code directly when created not successful. >> >> Signed-off-by: Tonghao Zhang > > Except a nit below, > > Reviewed-by: Jianfeng Tan > >> --- >> lib/librte_vhost/socket.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c >> index 83befdc..8ca01df 100644 >> --- a/lib/librte_vhost/socket.c >> +++ b/lib/librte_vhost/socket.c >> @@ -831,9 +831,11 @@ struct vhost_device_ops const * >> if (fdset_tid == 0) { >> int ret = pthread_create(&fdset_tid, NULL, >> fdset_event_dispatch, >> &vhost_user.fdset); >> - if (ret != 0) >> + if (ret != 0) { >> RTE_LOG(ERR, VHOST_CONFIG, >> "failed to create fdset handling thread"); >> + return ret; > > According to the declaration below, we shall return 0 or -1. I will send v2 > /** > * > * Start the vhost-user driver. > * > * This function triggers the vhost-user negotiation. > * > * @param path > * The vhost-user socket file path > * @return > * 0 on success, -1 on failure > */ > int rte_vhost_driver_start(const char *path); > >> + } >> } >> >> if (vsocket->is_server) >> -- >> 1.8.3.1 >