From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xiangxia.m.yue@gmail.com>
Received: from mail-io1-f68.google.com (mail-io1-f68.google.com
 [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id B18FA2C16
 for <dev@dpdk.org>; Tue, 11 Dec 2018 03:55:01 +0100 (CET)
Received: by mail-io1-f68.google.com with SMTP id o5so10567626iop.12
 for <dev@dpdk.org>; Mon, 10 Dec 2018 18:55:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
 bh=wubthrCHLD/hOG1MudqbL+yhRZTZhmIa+MwAxYoWITg=;
 b=AzhUhvL6kYp3+6zrlq3DYcaM6snFNIAx8bsN0HzGYtXhwt4KGwncW9+z1WdVDOr0Mz
 aQAP68PcyuUVJPDltL5xFkv7gJFzJOMdqL9n5X+4yudEB40usskQs5NH0L6mWFTgr29w
 dbG7mwk2LhQRRst7jJXvlOkbCxCvWuzEgBUHTeja9bTZVZB8wP3xpooze7pkfizLKQNK
 BButwl3yc7NDKGi5VgJ2lJIZOjEX0aaf/eoxOGSD23Dn3l7b5LLFxgO3Q/kVNH+urBjQ
 xcYqpItSvVZCMQJFPDC90IXBXJ4OZf4OmkqwE+OKcbnOH6FRcx7cSeeOzTpEFvTskTft
 D2bg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=wubthrCHLD/hOG1MudqbL+yhRZTZhmIa+MwAxYoWITg=;
 b=S+pMDwCZnQXLtDPoQuJ89gZH5PpwaOmvbpKJu+TJX5hCytMYMAQGQrdsRmB7oxnj43
 QLdKx/ZXL1KzBNF4I4slNspbaKsWeR1Ofhjw3YVnHN0cNb85WHGm6ogdJJ2OJed4kX3z
 jdbGsU9cX1N6SyqQ9GWdAWhY80cZY7v6MQcHMVFYTCw3M1jVoi2TVtalOu9s5rmDVVQn
 eipg1BMVTjRp+BIYdsBn0t6aahj1WreJQzw6hhf5KMmzwaCreoIVBaRdX4qi8eAN0zIr
 1Bv1mDQqyyNGqEMziFpP7BQUPcXujX7hsVYTVOyPbkh8PWBlu9KdPiJ4ETRuhdaoogq1
 SY8Q==
X-Gm-Message-State: AA+aEWYBpIAFG+CWxBD8eefOAcqz6EhMcO3htyexG2CZaBZesliJPh3q
 MddWeA87sRY9l9lK3vwmYJkE6KtOeeHiF9RhKl0P+CVG
X-Google-Smtp-Source: AFSGD/VqKOQ7Y+MQkFFDta4E3xHFLSlNJUYHt1k/NYAl00jlUViG+BoasyZUT/u7P06VF47epwLApH8E0RrDWDuSkVw=
X-Received: by 2002:a6b:f017:: with SMTP id w23mr11167566ioc.12.1544496900877; 
 Mon, 10 Dec 2018 18:55:00 -0800 (PST)
MIME-Version: 1.0
References: <1543413355-2874-1-git-send-email-xiangxia.m.yue@gmail.com>
 <1543413355-2874-2-git-send-email-xiangxia.m.yue@gmail.com>
In-Reply-To: <1543413355-2874-2-git-send-email-xiangxia.m.yue@gmail.com>
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Date: Tue, 11 Dec 2018 10:54:24 +0800
Message-ID: <CAMDZJNVLNZAi8KVWM1xGzmBcX7SxbX8tJe4vAe=VNxhVQMQQ_w@mail.gmail.com>
To: dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH 2/2] sched: fix possible mem leak on
	initialize
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Dec 2018 02:55:02 -0000

ping
On Wed, Nov 28, 2018 at 9:56 PM Tonghao Zhang <xiangxia.m.yue@gmail.com> wrote:
>
> In some case, we may create sched port dynamically,
> if err when creating so memory will leak.
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> ---
>  lib/librte_sched/rte_sched.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
> index 17de6e6..a3adcca 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -724,6 +724,7 @@ struct rte_sched_port *
>                                     bmp_mem_size);
>         if (port->bmp == NULL) {
>                 RTE_LOG(ERR, SCHED, "Bitmap init error\n");
> +               rte_free(port);
>                 return NULL;
>         }
>
> --
> 1.8.3.1
>