From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f195.google.com (mail-ot0-f195.google.com [74.125.82.195]) by dpdk.org (Postfix) with ESMTP id A6A9D7D19 for ; Mon, 15 Jan 2018 09:57:24 +0100 (CET) Received: by mail-ot0-f195.google.com with SMTP id h2so10043216oti.5 for ; Mon, 15 Jan 2018 00:57:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pYVQ2hcbVER64YQI1MaDCxhcpYdDdA3HaqfayhbDBRk=; b=gFKxVOPiY7rfxcFp4UBGctLDLhi7ftt+GhWpMj50UHEgF2HL73+wycr+Esyu1Jtz0g pedtdCr2EfILxKylUQqDeb1PIIlvPeOpmPtbPPVmzVMNMLGY8ZRpICqO4u634UKtp8rl PsqX7jQDwI0fH3TqPwrkCpgPuZA/3ehsu4yrHQ3Lba/IPufk/LAiuEK2RlMaM5zOaFBa egaYR8GOioYwM8WbNq69GHsdbOcrTtJs6KnGus6AOfQH6+2cHUgaT4IK3ZP0BamPifIf E43CFAz9ImaC60FcGjkXuzdOcbPfxMMXbLnz0aeVIbhun25ZSoXxMS213tR+OsT6Ck30 veQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pYVQ2hcbVER64YQI1MaDCxhcpYdDdA3HaqfayhbDBRk=; b=gdsspvWwJWKDLh3ivph5pmpOtBPQ8J1dMesbe1X1ojKHJHH4Nxzlol0Gi8+RRpl9Qq v2X/cfg8/B+3YzBHR5hYEiS7gcp6WNO67HSH8q/nzToQWForsXUbJ0yHxqpDsRywD2fn ZxCuIEtfyzzLoOzFd77+nHLaqRLeOWznoRDMdAA6x9WTqk9o3EMVMshiXjhqD/5XKrJM /ISZQPx7IQpIOFuhVve1JcHw0mCnqcC9C+1g9uYZr6/VZZY3yGwCmZVjMekvuYGA+n11 2idEhllBuaQLzpbCFBbEayq3YTs1wJdk5QH8iEfxzEqbXaU09ZgcPjQaqRGGrQCkimHn 11rg== X-Gm-Message-State: AKwxyteYGKRxPaltGkCwUKtIeaN4YuN1b4b3WrsjS0rMK+mK5sirtq6p Y5OR96tMJ4x4lmAgb5JyoRdFZZLBrsx4B0eA1uQ= X-Google-Smtp-Source: ACJfBovcMab82vzfu9d8c7z2gZEPvpOAq9DqrG/nnkxEpe0wYlhw0fgZs+WtKPkgZPO74SlKJqSGA+AuR4wpETJueCk= X-Received: by 10.157.58.116 with SMTP id j107mr1646326otc.238.1516006643927; Mon, 15 Jan 2018 00:57:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.151.65 with HTTP; Mon, 15 Jan 2018 00:57:23 -0800 (PST) In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D66CF2242D@PGSMSX112.gar.corp.intel.com> References: <1515924222-19044-1-git-send-email-xiangxia.m.yue@gmail.com> <49759EB36A64CF4892C1AFEC9231E8D66CF2242D@PGSMSX112.gar.corp.intel.com> From: Tonghao Zhang Date: Mon, 15 Jan 2018 16:57:23 +0800 Message-ID: To: "Dai, Wei" Cc: "Xing, Beilei" , "Zhang, Helin" , "Lu, Wenzhuo" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 1/6] net/ixgbevf: unregister irq handler when other interrupts not allowed. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 08:57:24 -0000 On Mon, Jan 15, 2018 at 12:57 PM, Dai, Wei wrote: >> -----Original Message----- >> From: xiangxia.m.yue@gmail.com [mailto:xiangxia.m.yue@gmail.com] >> Sent: Sunday, January 14, 2018 6:04 PM >> To: Dai, Wei ; Xing, Beilei >> Cc: dev@dpdk.org; Tonghao Zhang >> Subject: [PATCH v3 1/6] net/ixgbevf: unregister irq handler when other >> interrupts not allowed. >> >> From: Tonghao Zhang >> >> When bind the ixgbe VF (e.g 82599 card) to igb_uio and enable the >> rx-interrupt, there will be more than one epoll_wait on intr_handle.fd. >> One is in "eal-intr-thread" thread, and the others are in the thread which call >> the "rte_epoll_wait". The problem is that sometimes "eal-intr-thread" thread >> will process the rx interrupt, and then rte_epoll_wait can't get the event >> anymore, and the packets may be lost. >> >> The patch unregister the status interrupt handler in "eal-intr-thread" >> thread and the ixgbe pf is in the same case. >> >> Signed-off-by: Tonghao Zhang >> Acked-by: Beilei Xing > In my feedback to your v2 version of this patch, I mentioned miscellaneous interrupt > need to be handled in eal-intr-thread. > Your patch removes the handler of PF->VF reset event and leads to missing of > this event. > My suggestion is still using VFIO-PCI instead of igb_uio for rx-queue interrupt. I got it, Thanks for your review. > >> --- >> drivers/net/ixgbe/ixgbe_ethdev.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >> b/drivers/net/ixgbe/ixgbe_ethdev.c >> index ff19a56..0e056a2 100644 >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> @@ -5078,6 +5078,15 @@ static int >> ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, >> } >> ixgbevf_configure_msix(dev); >> >> + if (!rte_intr_allow_others(intr_handle)) { >> + rte_intr_callback_unregister(intr_handle, >> + ixgbevf_dev_interrupt_handler, >> + dev); >> + if (dev->data->dev_conf.intr_conf.lsc != 0) >> + PMD_INIT_LOG(INFO, "lsc won't enable because of" >> + " no intr multiplex"); >> + } >> + >> /* When a VF port is bound to VFIO-PCI, only miscellaneous interrupt >> * is mapped to VFIO vector 0 in eth_ixgbevf_dev_init( ). >> * If previous VFIO interrupt mapping setting in eth_ixgbevf_dev_init( ) >> @@ -5120,6 +5129,12 @@ static int >> ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, >> >> ixgbe_dev_clear_queues(dev); >> >> + if (!rte_intr_allow_others(intr_handle)) >> + /* resume to the default handler */ >> + rte_intr_callback_register(intr_handle, >> + ixgbevf_dev_interrupt_handler, >> + (void *)dev); >> + >> /* Clean datapath event and queue/vec mapping */ >> rte_intr_efd_disable(intr_handle); >> if (intr_handle->intr_vec != NULL) { >> -- >> 1.8.3.1 >