From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id AD421A0566;
	Mon,  2 Mar 2020 09:14:34 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 40A6D1BFF2;
	Mon,  2 Mar 2020 09:14:34 +0100 (CET)
Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com
 [209.85.160.195]) by dpdk.org (Postfix) with ESMTP id BABE42E81;
 Mon,  2 Mar 2020 09:14:33 +0100 (CET)
Received: by mail-qt1-f195.google.com with SMTP id a4so896234qto.12;
 Mon, 02 Mar 2020 00:14:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=+rsFtwX7y+tKlUwf1UEBcMCcCZ3mMltb1BKNWXXf6HQ=;
 b=N6QJbuh9qU92O1HvGpZvbHz7pC7B/CFK/G8ldRfGWKU9xuPWl1ipp6OzH0V9gBY+SY
 9GhfAc9Yt02xzY+gZELyPH335Sw+hY1H1GPkzvtkN0Ei7XOzHY8/KXQ4sczCVG5yPRRD
 nW9OEfcOIBItKHF2jZUFyzF50qvWq2riquuSXT2Ht0nufnkKCByb6VBzoqTFTUZEnkhG
 VcUWT5oOofc4EZvV+WBRgYXd4+Mhrn8DU5zK3ItJ470Z6eNkonX1zHnBQjzw2fmpnN/z
 EfEvcJGvcgS9t+N3ekgKbvdQSaqeX5K1Gnc0B26paiZvZzKQWlMzLCXYMWlz7CNWgEhx
 SyEg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=+rsFtwX7y+tKlUwf1UEBcMCcCZ3mMltb1BKNWXXf6HQ=;
 b=mb0LUFBlvHXnox+CUlf6uTr9Nzq6PdshpwnfqD1rKbrfxPzFf5KmXLYpRERxYFb5jV
 FDKAnwLpLNfePhdx+L9+Um0e1Lje3djSwNyYBT9J9gulS3mKSceHpLrzCt3/9NX+fQtw
 vCjkZKB13hZL2Af45tFddkPJlkSz6VOR7ij7alJnLZui3Lk1/l3tqwIRV3xOGpJotvis
 YnQvah4sqg5Llf452vfktMciLzFFrUCxbUvPJjp9XOFezQmIN0ghqCosPBJ4HQOW10/N
 r9WfTFiARMn2BmO0OfqbVbTA50rECvfYinmDZ1gD2EhwVyYoOANmGEkM4AYiw1mPmAXS
 D1fA==
X-Gm-Message-State: APjAAAWb/8mQ6dm6Ibt3ndZoRDCAzal2mtaj+Em95VxVe2VWVk/7+pG0
 jFt8z+SUAJtfwgrxgE4fZ1TmJwH20izql2YAAAA=
X-Google-Smtp-Source: APXvYqwidqtJQgELTt+OZXgHiRhUA3r5uJeeTrB/59zjFpOmQ9z1AYONSUqsGlzVtPezLf4frMIqEHCtDoe5wcmom5M=
X-Received: by 2002:aed:308a:: with SMTP id 10mr14351421qtf.221.1583136873079; 
 Mon, 02 Mar 2020 00:14:33 -0800 (PST)
MIME-Version: 1.0
References: <1582972040-7026-1-git-send-email-xiangxia.m.yue@gmail.com>
 <AM0PR05MB44015925E9C55C483B52FB1BD7E60@AM0PR05MB4401.eurprd05.prod.outlook.com>
 <CAMDZJNVH6C7S-XRG=8uxvKE_KjD-b+=bzO3CtwPyfaT5Z=DPMw@mail.gmail.com>
 <AM0PR05MB4401668688D28A3FF365D060D7E70@AM0PR05MB4401.eurprd05.prod.outlook.com>
In-Reply-To: <AM0PR05MB4401668688D28A3FF365D060D7E70@AM0PR05MB4401.eurprd05.prod.outlook.com>
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Date: Mon, 2 Mar 2020 16:13:56 +0800
Message-ID: <CAMDZJNVZoCAWRbGaFgsWYnHj=vfkCOi_L3PgM8LMT0sgBdgBOQ@mail.gmail.com>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>, Matan Azrad <matan@mellanox.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [dpdk v1] net/mlx5: fix possible building error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Mar 2, 2020 at 3:35 PM Ali Alnubani <alialnu@mellanox.com> wrote:
>
> > -----Original Message-----
> > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > Sent: Monday, March 2, 2020 2:23 AM
> > To: Ali Alnubani <alialnu@mellanox.com>
> > Cc: stable@dpdk.org; Matan Azrad <matan@mellanox.com>; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [dpdk v1] net/mlx5: fix possible building error
> >
> > On Mon, Mar 2, 2020 at 1:09 AM Ali Alnubani <alialnu@mellanox.com>
> > wrote:
> > >
> > > Hi Tonghao,
> > >
> > > > -----Original Message-----
> > > > From: dev <dev-bounces@dpdk.org> On Behalf Of
> > > > xiangxia.m.yue@gmail.com
> > > > Sent: Saturday, February 29, 2020 12:27 PM
> > > > To: Matan Azrad <matan@mellanox.com>; dev@dpdk.org
> > > > Cc: Tonghao Zhang <xiangxia.m.yue@gmail.com>; stable@dpdk.org
> > > > Subject: [dpdk-dev] [dpdk v1] net/mlx5: fix possible building error
> > > >
> > > > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > > >
> > > > When setting the CONFIG_RTE_BUILD_SHARED_LIB to y, and build the
> > > > mlx5 pmd, there is a building error.
> > > > To fix it, add RTE_IBVERBS_LINK_DLOPEN to include relative codes.
> > > >
> > > > > mlx5_common.o: In function `mlx5_glue_init':
> > > > > drivers/common/mlx5/mlx5_common.c:324: undefined reference to
> > > > `dlclose'
> > > >
> > > > Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > > > ---
> > > >  drivers/common/mlx5/mlx5_common.c | 5 +++--
> > > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > >
> > >
> > > I test this case on multiple environments and don't see the build failure.
> > Can you please provide more information about yours, and how to
> > reproduce this?
> > Hi Ali,
> > I use the dpdk-next-net, and the last commit id is
> > d7142fbae16f185e11bfa44be061399afc40a1be.
> > The build config is show as below:
> >
> > diff --git a/config/common_base b/config/common_base index
> > 7ca2f28..4bd5126 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -57,7 +57,7 @@ CONFIG_RTE_ENABLE_LTO=n  #  # Compile to share
> > library  # -CONFIG_RTE_BUILD_SHARED_LIB=n
> > +CONFIG_RTE_BUILD_SHARED_LIB=y
> >
> >  #
> >  # Use newest code breaking previous ABI @@ -363,7 +363,7 @@
> > CONFIG_RTE_LIBRTE_MLX4_DEBUG=n  # Compile burst-oriented Mellanox
> > ConnectX-4, ConnectX-5,  # ConnectX-6 & BlueField (MLX5) PMD  # -
> > CONFIG_RTE_LIBRTE_MLX5_PMD=n
> > +CONFIG_RTE_LIBRTE_MLX5_PMD=y
> >  CONFIG_RTE_LIBRTE_MLX5_DEBUG=n
> >
> >  #
> >
> > The building failure log show:
> > LD librte_common_mlx5.so.20.0.1
> > mlx5_common.o: In function `mlx5_glue_init':
> > /root/zth/myshell/dpdk-next-
> > net/drivers/common/mlx5/mlx5_common.c:324:
> > undefined reference to `dlclose'
> > collect2: error: ld returned 1 exit status
> >
>
> Do you mind sharing which OS are you using, which gcc/clang version, whether you have MLNX_OFED or rdma-core installed, and which version?
1. CentOS Linux release 7.6.1810 (Core)
2. kernel 3.10.0-957.1.3.el7.x86_64
3. OFED 4.7-3.2.9
4. FW 16.26.4012
5. gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36)
6. build the dpdk with x86_64-native-linuxapp-gcc
> Thanks,
> Ali