From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17D37A00BE; Tue, 28 Apr 2020 15:23:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 57C331D5C7; Tue, 28 Apr 2020 15:23:16 +0200 (CEST) Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by dpdk.org (Postfix) with ESMTP id 72D151D590 for ; Tue, 28 Apr 2020 15:23:14 +0200 (CEST) Received: by mail-ed1-f67.google.com with SMTP id f12so16322065edn.12 for ; Tue, 28 Apr 2020 06:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YpV1w/SziwAxDWrlUbOu+eqhP8YnHuZTUKhROEvVOxI=; b=k1I0GFQf4EDlmcrOy81i+SSJUjH+iWbAIWK+Mx1QaJ8A3n//RXjOOgdZO/AF6k+8x0 OCB24OWgXkIw2VU0AARZjbbAl+fajn0QZYn27drI0eD1T7Mk+5nMU8/c8a+roz8u/GGA 7qAoWkjG4UrYTnNZZ/zsj568Bcc8fylXUezSMGmv3IbLeS7tRAZeChyxzS16F8UYNE+d Odx8sG0Arr5JQ4U+iC7RZ7NG2elV1PY6FySXsquZ5vyfgSvIQkf3KqSY273ytQfcXctT NCMUQYET2X5KX9DoYaYFAoBHi7L1hqvUK0l8qqlJ4LBnlJmwoSCjnGcBMLu+vKkiqSC7 7QGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YpV1w/SziwAxDWrlUbOu+eqhP8YnHuZTUKhROEvVOxI=; b=kGePOu1IRjkD8h8evt38Em99m7s6GlpreltEVWtCsxbg5/3ykJ+wFI76vPMVG1wjYP FA1MJ8ufskn+zdJOuHBhoYc9nzQ6lOVR1B5sQINtCBLZfUhbBQbfr61nMLtpiFCCnvG4 UY+T4J84BSFONs7kVyF9FNz1JuFwjFnlhKmXgcjpd6sp/eiQa7bVruSM1lqC0GiEunCx tploZKqaGuEonWNHBKf718IVbZPKOsudJK/0KqvWwOyEqvph8gAlzsFoJ+p06gbtoo/t RO0RBrZi100dAiqBr85mD/nbmsSNpVE/Iu7oviXp9QhqdKwkehLpNd7CJ2bjAvgnSgo9 lagw== X-Gm-Message-State: AGi0Pub5o9QMdjHkIhUjWyPKykH67bid1U29luhIrEoa95v6mZNoBvvG ygR05MT+8QtWVqeQweObxREIP8+vJZk2kabP7K7MzAeQ0EM= X-Google-Smtp-Source: APiQypJCrj/lhbhO1En1SgjBBxkdms/6jvH0WYAwHp95ZkRaTrWyoBaQsNf78gBc/H5naS/NpmcBz6r7F2LO9uB00as= X-Received: by 2002:a05:6402:391:: with SMTP id o17mr22702512edv.71.1588080194068; Tue, 28 Apr 2020 06:23:14 -0700 (PDT) MIME-Version: 1.0 References: <1583114253-15345-1-git-send-email-xiangxia.m.yue@gmail.com> <3331280.0S5aU1g85B@thomas> <9453419.OU7Dqq5WaI@thomas> In-Reply-To: From: Tonghao Zhang Date: Tue, 28 Apr 2020 21:22:37 +0800 Message-ID: To: Thomas Monjalon Cc: Olivier Matz , Andrew Rybchenko , Gage Eads , "Artem V. Andreev" , Jerin Jacob , Nithin Dabilpuram , Vamsi Attunuru , Hemant Agrawal , David Marchand , "Burakov, Anatoly" , Bruce Richardson , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH dpdk-dev v3 2/2] mempool: use shared memzone for rte_mempool_ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 27, 2020 at 8:51 PM Tonghao Zhang wrote: > > On Mon, Apr 27, 2020 at 7:40 PM Thomas Monjalon wrote: > > > > 27/04/2020 10:03, Tonghao Zhang: > > > On Fri, Apr 17, 2020 at 6:27 AM Thomas Monjalon wrote: > > > > > > > > 13/04/2020 16:21, xiangxia.m.yue@gmail.com: > > > > > The order of mempool initiation affects mempool index in the > > > > > rte_mempool_ops_table. For example, when building APPs with: > > > > > > > > > > $ gcc -lrte_mempool_bucket -lrte_mempool_ring ... > > > > > > > > > > The "bucket" mempool will be registered firstly, and its index > > > > > in table is 0 while the index of "ring" mempool is 1. DPDK > > > > > uses the mk/rte.app.mk to build APPs, and others, for example, > > > > > Open vSwitch, use the libdpdk.a or libdpdk.so to build it. > > > > > The mempool lib linked in dpdk and Open vSwitch is different. > > > > > > > > We are supposed to use pkg-config to link DPDK. > > > > Does the problem appear between a DPDK compiled with meson > > > > and an application linked with pkg-config information? > Hi Thomas, > The library mempool linked order can trigger that problem. but when > the library is loaded > dynamically, trigger that problem too. > as Olivier Matz said: > The fact that the ops index changes during mempool driver lifetime is > indeed frightening, especially knowning that this is a dynamic > registration that could happen at any moment in the life of the > application. > > the message in https://mails.dpdk.org/archives/dev/2020-March/159354.html Hi Thomas, For first patch, I guess we support a callback for other library, it make the codes much cleaner at eal layer. Otherwise, if we init for library, we may include their header file. There is a better solution ? > > > > If the problem really needs to be solved, > > > > the EAL patch (first of this series) needs to be discussed > > > > and reviewed carefully. I don't imagine it being done in 20.05. > > > > > > will I stop update the patches or when the patch is ready and then > > > decide applied or not? > > > > As I said, it requires more discussion. > > Please start by answering my question above. > I got it, Thanks. > > > > > -- > Best regards, Tonghao -- Best regards, Tonghao