From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f68.google.com (mail-oi0-f68.google.com [209.85.218.68]) by dpdk.org (Postfix) with ESMTP id A21631B29B for ; Wed, 17 Jan 2018 02:38:12 +0100 (CET) Received: by mail-oi0-f68.google.com with SMTP id o64so12024216oia.9 for ; Tue, 16 Jan 2018 17:38:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7ux7AMQherTbrH+qelqImeUXMUUzRFv+xmJbFAMzkNU=; b=EJDQnPXUMLib0cAb3RI9rlngyjqYXMLRdEfyY11CO6ve/8l3Tt9eeF1kaR+bTzU8VA Ixlq/Cbs7lUjTpgn3MbnIQu6PMlE6GzimUIcfpyGkEFORwP3UmvFWk8s3khqOsE4btd/ JzGLztVcyEbADVj68+Z8LD/nlFl1iF9Fryr7TcicnnNJvLm18VXVe9O945stBRhvHoku 0/VUFkiuHwuXo3QfYR61USEZsAoH02ZnNUfNCUtL+vLA9rVhqB7pfLFoDGJA7VuMohuK iwePVG9i1H4hak+jB1U0iWq+BtiTxGbf74p+97VZ2/vrbn8YwZISHTJ79wnc+FmlnHpD LqqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7ux7AMQherTbrH+qelqImeUXMUUzRFv+xmJbFAMzkNU=; b=IXSt4uAB+yE1h0BaWdRqQIlhaXGwmvLCzB0w3R6YxULOCMpthSMuGc0VauGVWXLsv5 pn0qKO5snvG9CLntT3T7P+mM5k1m2v2yu6wIm5fPaKnrPkECjxkMvwcmcPAbx1H92y2k vX62xWb00tCfQXSEqnoyLqTYrfxYdvdmPCSjwLlTV4b4i4aNSKQ0EruWjNXbu/V9NrnD J9NbF2PKpPHfr9SeH2AeYO78+l3Nc1j4K1EzWtf/yRyG8fdLxgFX6xj2pGV6caO153kb fxfT42NnRs9GgdQLOqyooDXoxFKM72A3sPRVeTPgpivx7Ux6kUL/FP0z1NYQHjUkaXi+ yXkQ== X-Gm-Message-State: AKwxytfFgiQFvO6lpGibf8/EQcYthefPnWDj09VCAG9TjdN+kQVoOJ2P es2uSCuzxyTrsy0nIdxm+k5iprTcasvTOwxhBSU= X-Google-Smtp-Source: ACJfBovhbLD44SaQ71qCerDR3/IZJMnf44ujHOAV6BG9kUxKCrltOffDjtQox9ygQkaSBrxFbNnTimNoKSUWLs0KGtA= X-Received: by 10.202.237.134 with SMTP id l128mr189950oih.109.1516153091995; Tue, 16 Jan 2018 17:38:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.151.65 with HTTP; Tue, 16 Jan 2018 17:38:11 -0800 (PST) In-Reply-To: References: <1515924222-19044-1-git-send-email-xiangxia.m.yue@gmail.com> <49759EB36A64CF4892C1AFEC9231E8D66CF2242D@PGSMSX112.gar.corp.intel.com> From: Tonghao Zhang Date: Wed, 17 Jan 2018 09:38:11 +0800 Message-ID: To: "Dai, Wei" Cc: "Xing, Beilei" , "Zhang, Helin" , "Lu, Wenzhuo" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 1/6] net/ixgbevf: unregister irq handler when other interrupts not allowed. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 01:38:12 -0000 On Mon, Jan 15, 2018 at 4:57 PM, Tonghao Zhang wrote: > On Mon, Jan 15, 2018 at 12:57 PM, Dai, Wei wrote: >>> -----Original Message----- >>> From: xiangxia.m.yue@gmail.com [mailto:xiangxia.m.yue@gmail.com] >>> Sent: Sunday, January 14, 2018 6:04 PM >>> To: Dai, Wei ; Xing, Beilei >>> Cc: dev@dpdk.org; Tonghao Zhang >>> Subject: [PATCH v3 1/6] net/ixgbevf: unregister irq handler when other >>> interrupts not allowed. >>> >>> From: Tonghao Zhang >>> >>> When bind the ixgbe VF (e.g 82599 card) to igb_uio and enable the >>> rx-interrupt, there will be more than one epoll_wait on intr_handle.fd. >>> One is in "eal-intr-thread" thread, and the others are in the thread which call >>> the "rte_epoll_wait". The problem is that sometimes "eal-intr-thread" thread >>> will process the rx interrupt, and then rte_epoll_wait can't get the event >>> anymore, and the packets may be lost. >>> >>> The patch unregister the status interrupt handler in "eal-intr-thread" >>> thread and the ixgbe pf is in the same case. >>> >>> Signed-off-by: Tonghao Zhang >>> Acked-by: Beilei Xing >> In my feedback to your v2 version of this patch, I mentioned miscellaneous interrupt >> need to be handled in eal-intr-thread. >> Your patch removes the handler of PF->VF reset event and leads to missing of >> this event. >> My suggestion is still using VFIO-PCI instead of igb_uio for rx-queue interrupt. > I got it, Thanks for your review. Hi wei, beilei, The patches in the patchset have no dependency. Can you help me to review other patches ? >> >>> --- >>> drivers/net/ixgbe/ixgbe_ethdev.c | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >>> b/drivers/net/ixgbe/ixgbe_ethdev.c >>> index ff19a56..0e056a2 100644 >>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >>> @@ -5078,6 +5078,15 @@ static int >>> ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, >>> } >>> ixgbevf_configure_msix(dev); >>> >>> + if (!rte_intr_allow_others(intr_handle)) { >>> + rte_intr_callback_unregister(intr_handle, >>> + ixgbevf_dev_interrupt_handler, >>> + dev); >>> + if (dev->data->dev_conf.intr_conf.lsc != 0) >>> + PMD_INIT_LOG(INFO, "lsc won't enable because of" >>> + " no intr multiplex"); >>> + } >>> + >>> /* When a VF port is bound to VFIO-PCI, only miscellaneous interrupt >>> * is mapped to VFIO vector 0 in eth_ixgbevf_dev_init( ). >>> * If previous VFIO interrupt mapping setting in eth_ixgbevf_dev_init( ) >>> @@ -5120,6 +5129,12 @@ static int >>> ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, >>> >>> ixgbe_dev_clear_queues(dev); >>> >>> + if (!rte_intr_allow_others(intr_handle)) >>> + /* resume to the default handler */ >>> + rte_intr_callback_register(intr_handle, >>> + ixgbevf_dev_interrupt_handler, >>> + (void *)dev); >>> + >>> /* Clean datapath event and queue/vec mapping */ >>> rte_intr_efd_disable(intr_handle); >>> if (intr_handle->intr_vec != NULL) { >>> -- >>> 1.8.3.1 >>