From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f177.google.com (mail-ob0-f177.google.com [209.85.214.177]) by dpdk.org (Postfix) with ESMTP id E26375A97 for ; Wed, 20 Jan 2016 15:35:11 +0100 (CET) Received: by mail-ob0-f177.google.com with SMTP id ba1so8219045obb.3 for ; Wed, 20 Jan 2016 06:35:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=E6GE0ydV2xGQ/UwGpg7eUYeuMHiXg8Lze3MdwJhQj/0=; b=J3ayDuHfRuabPUCHPk5IJgSpORTtM4vUqEUSWgSY/+SOn/DiqGz75DOHNcFRQKZyZK OqsHgP9gGNoQqPbl8P3URAjo29u5j3oYW0dac9o1Whj2GTuAma1TKmcNMDiUV90cSRKn AIip2QT1PqSCKkl6TRkM8AQ18OjM3GbNylQRVkBuAqk1QqOKSZjE2h5PeSp8VCeBybFr rDlnNQDvgqT1JWiMPzmQXmQNtijnbl8+1jComPpTskSMIb4Ic/GOaC+P8d996AR/+B3D ysq5kRsKHMv8bdhrPOp06mLcB5P37qgbrEYQu9Zvf/Y2LRnD3pe6eLtxV8SbqqZrK13z V5VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=E6GE0ydV2xGQ/UwGpg7eUYeuMHiXg8Lze3MdwJhQj/0=; b=GlL4OmiHxBhUgWshUSVFuANbw+/a7SM7tW/MPjuwI7HpqGaXyZyUfdUKkVDFEbzqv8 0vXcGpUEHqo0uumWxPTQmaH5fdH4O1t5RfR/U3EmUDkBQ0QKy/54wB3W/izTj0e3Qxik xBeaqM32gtRDA2k4Ky6+Sc0knJ6nFVcrB9ayWi2uM0YFn9N5g+P4uKgElgotPukEp3g5 g27/ZfNy2BSE240k/l+F+nOhTWPNtgpqFfCQ3TsrKCI338lz419XDTuRoMYkrgMyKDL6 opCT3JDXr8nHMe+WQZPhxDZQLc+eqMpApPQxqTdomH7jAqu+mWTpdM7N6e3wOurlxmg6 lF0Q== X-Gm-Message-State: ALoCoQmoeT7IVS6RN50W2J56s3eFId/rbi+PEL/ewxzm5bUtPy3TMINjNXDDcSx5HfsnGx0ORv91U6XCcmqz83KlEUrj0pIl+A== MIME-Version: 1.0 X-Received: by 10.182.133.37 with SMTP id oz5mr27884569obb.16.1453300511458; Wed, 20 Jan 2016 06:35:11 -0800 (PST) Received: by 10.76.68.7 with HTTP; Wed, 20 Jan 2016 06:35:11 -0800 (PST) In-Reply-To: <1453300086-3756-1-git-send-email-harry.van.haaren@intel.com> References: <1453300086-3756-1-git-send-email-harry.van.haaren@intel.com> Date: Wed, 20 Jan 2016 09:35:11 -0500 Message-ID: From: Kyle Larose To: Harry van Haaren Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ethdev: expose link status and speed using xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2016 14:35:12 -0000 On Wed, Jan 20, 2016 at 9:28 AM, Harry van Haaren wrote: > This patch exposes link duplex, speed, and status via the > existing xstats API. > I'm slightly confused by this. Why are we exposing operational properties of the chip through an API which I thought was primarily targeting statistics? When I think of statistics and a NIC, I think of values which are monotonically increasing. I think of values that are derived primary from the packets flowing through the system. I do not think of link state, link speed and duplex, which have nothing to do with packets, and are not monotonic. Should we not have a separate API to get this type information? I mean, just because we have a generic "string to uint64_t" map doesn't mean we should toss in anything that can fit into a uin64_t. Would you want to see the MAC address in here as well? If we put in link speed/etc. it seems like we may as well! Thanks, Kyle