From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by dpdk.org (Postfix) with ESMTP id 8C5452C01 for ; Wed, 21 Nov 2018 17:14:47 +0100 (CET) Received: by mail-lj1-f176.google.com with SMTP id x85-v6so5355650ljb.2 for ; Wed, 21 Nov 2018 08:14:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WKvd2+68CsiUwpR3Mr+XnEgbRe+xryw/hmprlaEMz1A=; b=A3N2Fc+ex/RihW5HGmImVATlGfgzPqsJC0lKY+hCiNoU6MJ85bgtS87m9yIZS5UUdb 4Ph/t2QWUYeQrgjW1d9wWGqm1zZowF6MLfGPwhub0RVaVSivBLIW4ELzEd1E6pOsYYBs 1cpwddU8LIKKtZjTa7Y3sN6ZIr+8QyXh0v+EUst9ZHVTb8Zo3q6n4FHuepyr1app8p/5 roGPaGiu5tDGxkcj4I5Aoou58/VrL6p7chk7xosuMHZTk9FsOcit6XjkxRwb/FMfLjeP +/5qpb6UMqSf0MW7AVxdNZTJyZmyyZcwCKGu2uyjjrppjZ//NhounEzokEHQyNCeY+Yh zWWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WKvd2+68CsiUwpR3Mr+XnEgbRe+xryw/hmprlaEMz1A=; b=stDvHULqRYXFboiM3gl0vvle0qRylRmuc9vS/86FnS5FtgepeSi+jJlj5XHJWWn0tV b/vwgCuSaHjF3od9QMVkVV37/ALgopUpXewR//fMV8/EXhleWgeEK51ep/u1HDvHxMQ7 CVwzOa5rlAjhTCBm56GZlZFo3XVhpHDon/K6IiWgTYkrmvvJwPse+8HO9aHqnCJw/gp7 jOdHgE5l90QxJo6krfJhJjymcVM+mXkBaHHpYPQtDSZVq99ECBw+T/wUo3o78iGIkLKW nMI8zUjX/Uxx8EePtILKaDaONEu37n9PfXYFe71ymK9vQKRi1bYaJRu5BOg2iN4q4mHr ZmiQ== X-Gm-Message-State: AA+aEWanYeJi+Se2vd19ZYbyudfwW/H733nB1rknju/lgU8pIwmuVxDa xbKvHxBF8PLQg8vGzEREw8Q3uBjRNeaelzP+P0WAyg== X-Google-Smtp-Source: AJdET5cHYiu0UQG35Z/yAApDDJKDSvNc1njyvPHAp1IoM4FW5TZSp8HQXrrURh3BzpqRAAww6nQUVWpk07CkcmNnUaU= X-Received: by 2002:a2e:9dcb:: with SMTP id x11-v6mr4888266ljj.158.1542816886993; Wed, 21 Nov 2018 08:14:46 -0800 (PST) MIME-Version: 1.0 References: <1542731185-10136-1-git-send-email-rk@semihalf.com> <1542788474-32677-1-git-send-email-rk@semihalf.com> In-Reply-To: From: =?UTF-8?B?UmFmYcWCIEtvemlr?= Date: Wed, 21 Nov 2018 17:14:34 +0100 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Marcin Wojtas , =?UTF-8?Q?Micha=C5=82_Krawczyk?= , "Tzalik, Guy" , "Schmeilin, Evgeny" , "Matushevsky, Alexander" , "Chauskin, Igor" , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/ena: fix out of order completion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 16:14:47 -0000 Hello Ferruh, this patch fix issue in Rx path which could have caused receive of wrong packets. If it is possible, I would be very grateful if this patch could be applied to v18.11. Best regards, Rafal =C5=9Br., 21 lis 2018 o 16:16 Ferruh Yigit napisa= =C5=82(a): > > On 11/21/2018 8:21 AM, Rafal Kozik wrote: > > rx_buffer_info should be refill not linearly, but out of order. > > IDs should be taken from empty_rx_reqs array. > > > > rx_refill_buffer is introduced to temporary storage > > bulk of mbufs taken from pool. > > > > In case of error unused mbufs are put back to pool. > > > > Fixes: c2034976673d ("net/ena: add Rx out of order completion") > > Cc: stable@dpdk.org > > > > Signed-off-by: Rafal Kozik > > Acked-by: Michal Krawczyk > > Hi Rafal, > > This patch sent after rc4, I suggest pushing this out to next release, an= y > objection? Is this really a critical patch to get in at this stage?