From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f41.google.com (mail-qg0-f41.google.com [209.85.192.41]) by dpdk.org (Postfix) with ESMTP id BD36DC766 for ; Sat, 30 Jan 2016 14:38:21 +0100 (CET) Received: by mail-qg0-f41.google.com with SMTP id 6so86580153qgy.1 for ; Sat, 30 Jan 2016 05:38:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightcyber-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=jMdvhwmNTuwkQaIsr8JnLPyJY03kOTryNtOEaR2W1uo=; b=xI6CPNOFXa91bFqjt/8+04NS7WkaB1z0jMPuxLx+wa4FxHNSprNyWLfY3xWG46XRym 2WUJCOLjDBJFQ+BNu3hu8K3/IxOYY+r1jCNi30N0XXFKZiuR4Ca3D0qpfFifye4w126m gpeyrZOb4ENNq268jz7i1bChZUAT1KcOIBW0aYUw1vu0VMUP0k4XDH2VKxKvwERygbro XCS95rlHdh/s00G3/zVQGPcQ4xfKe20IVKk8CmvwJC2n5PLWcnG2kGRknp6+MZyWOp7K HQC96WC2x9yH5LgoiIbSTu2O+fZEkZkERSgNqaR/kxIPzhvqkJzsMjXEqU8oU8sQqoe0 8P3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=jMdvhwmNTuwkQaIsr8JnLPyJY03kOTryNtOEaR2W1uo=; b=X+dPChDMBmMNcLLMDe/icASdloJvNwbn7coFgWnKbn9MoDXCNZz/dLbgH+EP2qMqeh HOgYNoSeU6ZmhgE/U1wxoqm6q4ea0id0wAWb4sDO5OvCXIXKBkA1mV5OHkJWREGi/PMH wovJFUHV4I0wOOQjKtqjL2MrHDFnTPuLHwAY4z37LGUipEGpWqmhsRI3YSPAwO2IOjZr GECuHJCx+FdW+LLvvrq6JhuqoAa9P11/KNDoD3bfgfMtuwQ486UltKr8VspEf0fboQC1 8ElSm+czUmTspTUavIrW1TPETh1XJ7+Qg7CuPqtssmIYcNoFTIb3QDmV1KX0NAzksbgT Ap4Q== X-Gm-Message-State: AG10YOQZubpJDtXGysgz3LjZ53a0sapZjKVP5ryEvbCimd0rCE82yV/UGehw0sdqNzkNyaGeVFQXkVlvsmlwXA== MIME-Version: 1.0 X-Received: by 10.140.88.202 with SMTP id t68mr17323324qgd.86.1454161101165; Sat, 30 Jan 2016 05:38:21 -0800 (PST) Received: by 10.55.98.204 with HTTP; Sat, 30 Jan 2016 05:38:21 -0800 (PST) In-Reply-To: <56AA5746.5030401@emutex.com> References: <1453968561-29085-1-git-send-email-dror.birkman@lightcyber.com> <56AA5746.5030401@emutex.com> Date: Sat, 30 Jan 2016 15:38:21 +0200 Message-ID: From: Dror Birkman To: Nicolas Pernas Maradei Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] pcap: fix captured frame length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jan 2016 13:38:22 -0000 Hi Nicolas, Thanks. I tried to test my application with a pcap file I had, but got weird results, so I wrote back the rte_mbufs in pcap format and hex compared it to my input pcap. Only then I noticed that my original pcap had frames that were captured with a length smaller than the frame length. I guess you can call it pure (bad) luck :) Dror On Thu, Jan 28, 2016 at 8:00 PM, Nicolas Pernas Maradei < nicolas.pernas.maradei@emutex.com> wrote: > Hi Dror, > > Good catch. What you are saying makes sense and it is also explained in > pcap's documentation. Was your setup unusual though? > This might sound like a silly question but I don't remember seeing that > issue and I should have since your fix is correct. > > Nico. > > On 28/01/16 08:09, Dror Birkman wrote: > > The actual captured length is header.caplen, whereas header.len is > the original length on the wire. > > Signed-off-by: Dror Birkman > --- > > > Without this fix, if the captured length is smaller than the original > length on the wire, mbuf will contain incorrect data. > > > drivers/net/pcap/rte_eth_pcap.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c > index f9230eb..1d121f8 100644 > --- a/drivers/net/pcap/rte_eth_pcap.c > +++ b/drivers/net/pcap/rte_eth_pcap.c > @@ -220,25 +220,25 @@ eth_pcap_rx(void *queue, > buf_size = (uint16_t)(rte_pktmbuf_data_room_size(pcap_q->mb_pool) - > RTE_PKTMBUF_HEADROOM); > > - if (header.len <= buf_size) { > + if (header.caplen <= buf_size) { > /* pcap packet will fit in the mbuf, go ahead and copy */ > rte_memcpy(rte_pktmbuf_mtod(mbuf, void *), packet, > - header.len); > - mbuf->data_len = (uint16_t)header.len; > + header.caplen); > + mbuf->data_len = (uint16_t)header.caplen; > } else { > /* Try read jumbo frame into multi mbufs. */ > if (unlikely(eth_pcap_rx_jumbo(pcap_q->mb_pool, > mbuf, > packet, > - header.len) == -1)) > + header.caplen) == -1)) > break; > } > > - mbuf->pkt_len = (uint16_t)header.len; > + mbuf->pkt_len = (uint16_t)header.caplen; > mbuf->port = pcap_q->in_port; > bufs[num_rx] = mbuf; > num_rx++; > - rx_bytes += header.len; > + rx_bytes += header.caplen; > } > pcap_q->rx_pkts += num_rx; > pcap_q->rx_bytes += rx_bytes; > > > - no title specified @page { } table { border-collapse:collapse; > border-spacing:0; empty-cells:show } td, th { vertical-align:top; > font-size:12pt;} h1, h2, h3, h4, h5, h6 { clear:both } ol, ul { margin:0; > padding:0;} li { list-style: none; margin:0; padding:0;} li span. { clear: both; line-height:0; > width:0; height:0; margin:0; padding:0; } span.footnodeNumber { > padding-right:1em; } span.annotation_style_by_filter { font-size:95%; > font-family:Arial; background-color:#fff000; margin:0; border:0; padding:0; > } * { margin:0;} .P1_borderStart { font-size:12pt; line-height:120%; > margin-top:0cm; font-family:Liberation Serif; writing-mode:page; > margin-left:0.3cm; margin-right:0cm; text-indent:0cm; > background-color:transparent; padding-bottom:0.247cm; > border-bottom-style:none; } .P1 { font-size:12pt; line-height:120%; > font-family:Liberation Serif; writing-mode:page; margin-left:0.3cm; > margin-right:0cm; text-indent:0cm; background-color:transparent; > padding-bottom:0.247cm; padding-top:0cm; border-top-style:none; > border-bottom-style:none; } .P1_borderEnd { font-size:12pt; > line-height:120%; margin-bottom:0.247cm; font-family:Liberation Serif; > writing-mode:page; margin-left:0.3cm; margin-right:0cm; text-indent:0cm; > background-color:transparent; padding-top:0cm; border-top-style:none;} > .P2_borderStart { font-size:12pt; line-height:120%; margin-top:0cm; > font-family:Liberation Serif; writing-mode:page; margin-left:0.3cm; > margin-right:0cm; text-indent:0cm; background-color:transparent; > padding-bottom:0.247cm; border-bottom-style:none; } .P2 { font-size:12pt; > line-height:120%; font-family:Liberation Serif; writing-mode:page; > margin-left:0.3cm; margin-right:0cm; text-indent:0cm; > background-color:transparent; padding-bottom:0.247cm; padding-top:0cm; > border-top-style:none; border-bottom-style:none; } .P2_borderEnd { > font-size:12pt; line-height:120%; margin-bottom:0.247cm; > font-family:Liberation Serif; writing-mode:page; margin-left:0.3cm; > margin-right:0cm; text-indent:0cm; background-color:transparent; > padding-top:0cm; border-top-style:none;} .P3_borderStart { font-size:10pt; > line-height:120%; margin-top:0cm; font-family:Courier New; > writing-mode:page; margin-left:0.3cm; margin-right:0cm; text-indent:0cm; > background-color:transparent; padding-bottom:0.247cm; > border-bottom-style:none; } .P3 { font-size:10pt; line-height:120%; > font-family:Courier New; writing-mode:page; margin-left:0.3cm; > margin-right:0cm; text-indent:0cm; background-color:transparent; > padding-bottom:0.247cm; padding-top:0cm; border-top-style:none; > border-bottom-style:none; } .P3_borderEnd { font-size:10pt; > line-height:120%; margin-bottom:0.247cm; font-family:Courier New; > writing-mode:page; margin-left:0.3cm; margin-right:0cm; text-indent:0cm; > background-color:transparent; padding-top:0cm; border-top-style:none;} > .Standard { font-size:12pt; font-family:Liberation Serif; > writing-mode:page; } .Internet_20_link { color:#000080; > text-decoration:underline; } .T10 { color:#0070c0; } .T11 { color:#0070c0; > font-size:12pt; } .T12 { color:#0070c0; font-size:20pt; font-weight:bold; } > .T16 { color:#000000; font-size:10pt; } .T2 { color:#0000ff; > font-family:Liberation Sans; } .T20 { color:#ff0000; font-size:10pt; > font-weight:bold; } .T22 { font-size:10pt; } .T3 { color:#0000ff; > font-family:Liberation Sans; font-size:8pt; } .T6 { color:#0000ff; > font-size:10pt; } .T7 { color:#000066; font-family:Liberation Sans; > font-weight:bold; } .T8 { font-family:Liberation Sans; } { >