From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB58E41C8B; Mon, 13 Feb 2023 18:12:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74E0242D10; Mon, 13 Feb 2023 18:12:31 +0100 (CET) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by mails.dpdk.org (Postfix) with ESMTP id 2BE1540EE4 for ; Mon, 13 Feb 2023 18:12:30 +0100 (CET) Received: by mail-ed1-f49.google.com with SMTP id fj20so13915525edb.1 for ; Mon, 13 Feb 2023 09:12:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Sg+NgC5QkX2gJg8ZJWuaRyWmHZaxk6fJEB0keUmfkOc=; b=oN+XDo1VkqoJys8zzEUd0uEmny7gaZC4JAzY7EL9O/Wcu6BAubYdG/bXKwqtAuN7VQ sROmJWKEuKa/FgWvD56QKZe0xP6xxyMbAUwOSwklQNzz2t5VWTO1rrvmt9sBdBvGWXKJ fFna2LdvhCX5d/bQ4xwgwVRDY4x6m+IE1nN9Fia5zRGc4Tma2DqK43XUZ6IGl+L0Puyl ez2DI/q5W5lkA/yJclAI7Vo29r14OI2+fb7J+hVs6b/xxnj0b/SD7hpI+xrKV0mCXfYB 4kLhLo76Mp59AkdTcpqxu9opfgyDK1JDSOXtThcBDClBfZtHEudTdoovx/qoxNtp5RRs zgmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Sg+NgC5QkX2gJg8ZJWuaRyWmHZaxk6fJEB0keUmfkOc=; b=5HPw5YkhA0jOEbBJMAM80+zDmGLfE6B1iqtxla4hryQz50aujgyyAcW1gllOkM+cQh Vy0BxxUt7rVmpt5Tx/VssJ4AWe9Tf7qJHcPAA5n8yvm7tOg3U/E2qgQjuLFXP2ZGe1rD 6S1TkgBTNieo3bLTgFQxOks2yImv2GVrxlPzn4ZlaeUVfSRAPs3w6BmbFmCbl+Vf+pvo u01cDi2rRaPv2wK9sJVfMOzFl85rNjrft8cXUQw2XVo29n8NouPp/yE9ytAwVS1wNmt/ QI0ISGxUxI0n10ay9BoFbvN5RpK84/iplwILkZdkMBim02/1C5QsbYkeB2tZ6bmFiSiE lCCA== X-Gm-Message-State: AO0yUKV6ysTDV1tMaLc8nTSm7Yc4AA02L3uXnCIUWqhgbJcFu+qEpZS9 5fh5rpeuAuxn9q+yxkW8oZncdOnDUxZc8ZiDKkiTlA== X-Google-Smtp-Source: AK7set/aHo7C3GxziQV2gShQnk7rW/2VW3V0kcPT75bqwwtotOTNehqNlcBJApqw5pZ4gaokZcUnXnlqjngE8RN9oRM= X-Received: by 2002:a50:bace:0:b0:4ac:ce87:3e5a with SMTP id x72-20020a50bace000000b004acce873e5amr1169782ede.3.1676308349823; Mon, 13 Feb 2023 09:12:29 -0800 (PST) MIME-Version: 1.0 References: <20230211141459.2857045-1-shepard.siegel@atomicrules.com> <20230213145824.2886910-1-shepard.siegel@atomicrules.com> <20230213145824.2886910-2-shepard.siegel@atomicrules.com> <2a62f7a3-5c09-036e-eae8-ed992a35ccd2@amd.com> In-Reply-To: <2a62f7a3-5c09-036e-eae8-ed992a35ccd2@amd.com> From: Shepard Siegel Date: Mon, 13 Feb 2023 12:12:18 -0500 Message-ID: Subject: Re: [PATCH 2/4] net/ark: add new device to PCIe allowlist To: Ferruh Yigit Cc: ed.czeck@atomicrules.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000b9c04d05f497f34e" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000b9c04d05f497f34e Content-Type: text/plain; charset="UTF-8" Hi Ferruh, If you dont mind squashing 2/4 3/4 4/4 together, that would be great. Thank you for correcting on the allowlist, s..b "supported PCIe ids list" instead. best, Shep On Mon, Feb 13, 2023 at 10:51 AM Ferruh Yigit wrote: > On 2/13/2023 2:58 PM, Shepard Siegel wrote: > > This patch adds the Arkville FX2 device to the PCIe allowlist. > > > > Signed-off-by: Shepard Siegel > > --- > > drivers/net/ark/ark_ethdev.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c > > index c654a229f7..b2995427c8 100644 > > --- a/drivers/net/ark/ark_ethdev.c > > +++ b/drivers/net/ark/ark_ethdev.c > > @@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] = { > > {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)}, > > {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)}, > > {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)}, > > + {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)}, > > {.vendor_id = 0, /* sentinel */ }, > > }; > > > > It is possible to squash 2/4, 3/4 & 4/4 into single patch, I can do it > while merging. > > In the patch title it mentions 'PCIe allowlist', this is not a kind of > allow list, this is list of PCI ids supported by driver, so I can update > patch title as following while merging if there won't be a new version: > "net/ark: support Arkville FX2 device" > --000000000000b9c04d05f497f34e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ferruh,

If you dont mind squashing 2= /4 3/4 4/4 together, that would be great.

Thank yo= u for correcting on the allowlist, s..b "supported PCIe ids list"= instead.

best, Shep

On Mon, F= eb 13, 2023 at 10:51 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
On 2/13/2023 2:58 PM, Shepard Siegel wrote:
> This patch adds the Arkville FX2 device to the PCIe allowlist.
>
> Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> ---
>=C2=A0 drivers/net/ark/ark_ethdev.c | 1 +
>=C2=A0 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev= .c
> index c654a229f7..b2995427c8 100644
> --- a/drivers/net/ark/ark_ethdev.c
> +++ b/drivers/net/ark/ark_ethdev.c
> @@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] =3D = {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
>=C2=A0 =C2=A0 =C2=A0 =C2=A0{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
>=C2=A0 =C2=A0 =C2=A0 =C2=A0{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
> +=C2=A0 =C2=A0 =C2=A0{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
>=C2=A0 =C2=A0 =C2=A0 =C2=A0{.vendor_id =3D 0, /* sentinel */ },
>=C2=A0 };
>=C2=A0

It is possible to squash 2/4, 3/4 & 4/4 into single patch, I can do it<= br> while merging.

In the patch title it mentions 'PCIe allowlist', this is not a kind= of
allow list, this is list of PCI ids supported by driver, so I can update patch title as following while merging if there won't be a new version:=
"net/ark: support Arkville FX2 device"
--000000000000b9c04d05f497f34e--