From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 5E44A3252 for ; Fri, 23 Jun 2017 12:06:36 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id z45so11356630wrb.2 for ; Fri, 23 Jun 2017 03:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KnQhzhdDwSwLfqfM1Xzxmpu8EuB6DjO3MlFYB4+yr7U=; b=CHyvmgZAhgfpG/KQgcjzpSBCpq9NKRVuF9g3LdaTNAdU78SMOq0VELLSp/5334CBR/ bGSu06ykd2EjFpy+U8/SAwPzKk8A2OOvluOcgvDv6K4YlDIM5HVa3T3Ql2rgV6Oyr6GA OX2kwG8M9jIG4lJCnBASsrXC3wPC+pbOZH1yihiTqadOl6p+vu6KYapMG5J/EiKvg590 m5KZVCAIhQg8b9jgk6PonlvCnj8tKVf2++Mn2HHF7n29DbFkpLcFry/trc32cLX5qRXc vCcVeI+aWWus5FmFsxR0LoSsdMnlyJMSAbYQHfBhA5I+WXBLANRE1JQ9xfQjoHmvWWKH nM9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KnQhzhdDwSwLfqfM1Xzxmpu8EuB6DjO3MlFYB4+yr7U=; b=U2M0k0oIRW+zdlLrzVOwk/L+wbFAMfjE5RTHjaBxhzYjF6WzBvMkUihrBb3quBxVZE afC48jI2S+2basfjyqkCFjfKGf0Ywg9ScUMRgPnHUFtK8wXTt8/CIouHI2af6FV31mHh AVsdmsambL07idC0SPakVm6Ti2VyDf+XmJyXuGPxa7kmW4o0iTCjH7GF6LtiAgPQNm9g UYdApctt0PEVQFlrJ5L9WeBeB1GoB7FRcjdnxfFXweLxTd81ljvrg95nvtw8hZHYicmE beDMUv4qrvNKpMWFv3zZS4wYKIXy5P/fZZaLRZsw04g02zGv6wJub8+vYT3zXT2fmwvt rVvA== X-Gm-Message-State: AKS2vOzvD8ZLyY3iz2lf7PRbOdsuOAu4FPXhIKpvwKF+g28XHeScZetJ vrXSxlc6oloNGiyRfISwY8bb6rZbRkdE X-Received: by 10.223.163.197 with SMTP id m5mr5138562wrb.128.1498212396035; Fri, 23 Jun 2017 03:06:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.43.198 with HTTP; Fri, 23 Jun 2017 03:06:35 -0700 (PDT) In-Reply-To: <258b76a4-dec7-0ccc-e568-581cf5cbc09c@intel.com> References: <1498134644-14089-1-git-send-email-john.miller@atomicrules.com> <258b76a4-dec7-0ccc-e568-581cf5cbc09c@intel.com> From: Shepard Siegel Date: Fri, 23 Jun 2017 06:06:35 -0400 Message-ID: To: Ferruh Yigit Cc: John Miller , dev@dpdk.org, Ed Czeck Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/2] net/ark: allow unique user data for each port in extension calls X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2017 10:06:36 -0000 Hi Ferruh, I was absent from the code review John Miller and Ed Czeck held for earlier this week for this patch set. John and Ed are both on a long weekend this weekend. If my reply below is correct and sufficient, please ack this patch set. Otherwise, no reply is needed and please hold this open until next Monday when John will respond. The Arkville net/ark PMD has the unique challenge of supporting a plurality of MACs through singleton ingress and egress AXI interfaces in hardware. Arkville is in the DPDK business of mbuf structures and data-moving; and does not itself have a concept of line-rate, MTU, and other MAC-centric properties. The extension calls, and the unique user data for each port in the extension calls provide users of Arkville and the net/ark PMD a DPDK normalized way of accessing their MAC parameters, regardless of how many MACs they have instanced in their Arkville DPDK device. -Shep Shepard Siegel, CTO atomicrules.com On Fri, Jun 23, 2017 at 5:21 AM, Ferruh Yigit wrote: > On 6/22/2017 1:30 PM, John Miller wrote: > > Provide unique user data pointer in the extension calls for > > each port. > > Hi John, > > Can you please give more details about why this is done. I can see in > adapter data user_data pointer kept per port now, but why? What was > observed with previous code? If this is to fix something, what we should > expect to be fixed? > > And there is mtu_set implementation, is it related modification? Can be > separated to another patch? > > Thanks, > ferruh > > > > > Signed-off-by: John Miller > > <...> > >