From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0582AA0C53; Tue, 10 Aug 2021 09:30:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C05140E6E; Tue, 10 Aug 2021 09:30:46 +0200 (CEST) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mails.dpdk.org (Postfix) with ESMTP id 89CA04068E for ; Tue, 10 Aug 2021 09:30:44 +0200 (CEST) Received: by mail-wm1-f48.google.com with SMTP id u15so12316751wmj.1 for ; Tue, 10 Aug 2021 00:30:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4/gl0xe9vDC7TgEQbLrxI/97amO9zUSyCD+nwIMM7P0=; b=FjOCl5Ee7rc7J1mWU5W5YmEs9y5oxfR2dwiydGuQSAR9Cgn6OsdWBrGqgRxZ2AVCCf zAeYjGnw4QQ/DZ5NmKMsnOk8UHR23cFgnPcKhsZppGH1aN+6qnKGOhB1jlGgIxZSoQbD orcvBl5aESBUt/gaIgNg/FrVew7/50Z74ZMi6ayZBmD/iO0mSRZcZxgHNGProkTsd6xW vpTtbTPu0dj5NFOpXv5l4XrO3iT573U4LM0EQeepsbCf8V3tKArtKZepJdK7zcZ6qvXk m5o3YKktAVL3zH6Cvqv4YoixtsgXUSB1PsUYGinvG749napYWfS+y9AvbyArhaENL6c4 o3ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4/gl0xe9vDC7TgEQbLrxI/97amO9zUSyCD+nwIMM7P0=; b=TV2HT73lGo9VponasG3OFRHn/au2SPZdL0clJqWj9KH6O3ds4rgGnZkMIprUmv0nkT Kp1PFqK+s9hDkuLlnd8OLmj9x8z6+v5jfIOWHg15AWzznWVqL/sFlfYvv8mNcsLDlp21 VJ4ifuOTLWsAPiaSfAlmki+Eyf1VnJvO6am16Ui6jOzyF9xrpiDX1ibTlkHpwkvGZebB Lw/4Hl2iaFEEEoCA34tSSwdZ0XjC3czQX540ak5nb4ZFnMsmYexMCchrTI7bqqXzLyyD 8/AaqQJ3dAeb1SIzQtYvKiSvt85FafzIsuzmBPJ/8zI60oUgQ7F2tBON5d59JOhCqhOK f++Q== X-Gm-Message-State: AOAM532bTvz7+7MQYVMwCLTuzTdJ93kmKwaBVu/gNgs9WS2qEP0RpvWS tkHuaS7ZBqBupz6FZJ8PjGHdf2LBB4TtjzQG9KFXdQ== X-Google-Smtp-Source: ABdhPJyzUAiKcg3yk56ulqS+uGEHcIwkbseylk0WaLEup/JFYbZwbh8o0+iw53X4zioNluMlG1KkCMDC4Dp2uHRmA0I= X-Received: by 2002:a1c:7711:: with SMTP id t17mr3047650wmi.77.1628580644146; Tue, 10 Aug 2021 00:30:44 -0700 (PDT) MIME-Version: 1.0 References: <20210809062548.30187-1-wangzhihong.wzh@bytedance.com> <20210809065200.31134-1-wangzhihong.wzh@bytedance.com> In-Reply-To: From: =?UTF-8?B?546L5b+X5a6P?= Date: Tue, 10 Aug 2021 15:30:33 +0800 Message-ID: To: "Singh, Aman Deep" Cc: dev@dpdk.org, ferruh.yigit@intel.com, xiaoyun.li@intel.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [External] Re: [PATCH v2] app/testpmd: flowgen support ip and udp fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Aman, On Mon, Aug 9, 2021 at 8:21 PM Singh, Aman Deep wrote: > > Hi Wang, > > On 8/9/2021 12:22 PM, Zhihong Wang wrote: > > This patch aims to: > 1. Add flexibility by supporting IP & UDP src/dst fields > 2. Improve multi-core performance by using per-core vars > > v2: fix assigning ip header cksum > > Signed-off-by: Zhihong Wang > --- > > > From defination of flowgen as per the documentation- > > flowgen: Multi-flow generation mode. Originates a number of flows (with varying destination IP addresses), and terminate receive traffic. > > So changing the src IP address may not fit the defination of a source generating real traffic. > > I would like to check this part further. Thanks for the review. The purpose of introducing them is to emulate pkt generators behaviors. Do you think keeping cfg_n_ip_src & cfg_n_udp_src while setting them = 1 by default makes sense? Or maybe update the documentation?