* [PATCH] net/virtio-user: add VIRTIO_F_ORDER_PLATFORM to feature list
@ 2024-02-20 11:40 Nithin Dabilpuram
2024-04-15 9:45 ` Nithin Dabilpuram
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Nithin Dabilpuram @ 2024-02-20 11:40 UTC (permalink / raw)
To: Maxime Coquelin, Chenbo Xia; +Cc: dev, jerinj, Nithin Dabilpuram
VIRTIO_F_ORDER_PLATFORM is needed feature when working with
real HW platforms that are exposing virtio-net devices
via VDPA framework. This feature helps in having more
real ordering requirements between descriptor updates and
notification data updates. Hence enable it if the
device supports the feature.
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
index d395fc1676..6ece3c6621 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
@@ -701,6 +701,7 @@ virtio_user_free_vrings(struct virtio_user_dev *dev)
1ULL << VIRTIO_F_VERSION_1 | \
1ULL << VIRTIO_F_RING_PACKED | \
1ULL << VIRTIO_F_NOTIFICATION_DATA | \
+ 1ULL << VIRTIO_F_ORDER_PLATFORM | \
1ULL << VIRTIO_NET_F_RSS)
int
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net/virtio-user: add VIRTIO_F_ORDER_PLATFORM to feature list
2024-02-20 11:40 [PATCH] net/virtio-user: add VIRTIO_F_ORDER_PLATFORM to feature list Nithin Dabilpuram
@ 2024-04-15 9:45 ` Nithin Dabilpuram
2024-06-10 4:35 ` Maxime Coquelin
2024-06-12 8:34 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Nithin Dabilpuram @ 2024-04-15 9:45 UTC (permalink / raw)
To: Nithin Dabilpuram; +Cc: Maxime Coquelin, Chenbo Xia, dev, jerinj
Ping.
Thanks
Nithin
On Tue, Feb 20, 2024 at 5:10 PM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
> VIRTIO_F_ORDER_PLATFORM is needed feature when working with
> real HW platforms that are exposing virtio-net devices
> via VDPA framework. This feature helps in having more
> real ordering requirements between descriptor updates and
> notification data updates. Hence enable it if the
> device supports the feature.
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> ---
> drivers/net/virtio/virtio_user/virtio_user_dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> index d395fc1676..6ece3c6621 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> @@ -701,6 +701,7 @@ virtio_user_free_vrings(struct virtio_user_dev *dev)
> 1ULL << VIRTIO_F_VERSION_1 | \
> 1ULL << VIRTIO_F_RING_PACKED | \
> 1ULL << VIRTIO_F_NOTIFICATION_DATA | \
> + 1ULL << VIRTIO_F_ORDER_PLATFORM | \
> 1ULL << VIRTIO_NET_F_RSS)
>
> int
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/virtio-user: add VIRTIO_F_ORDER_PLATFORM to feature list
2024-02-20 11:40 [PATCH] net/virtio-user: add VIRTIO_F_ORDER_PLATFORM to feature list Nithin Dabilpuram
2024-04-15 9:45 ` Nithin Dabilpuram
@ 2024-06-10 4:35 ` Maxime Coquelin
2024-06-12 8:34 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2024-06-10 4:35 UTC (permalink / raw)
To: Nithin Dabilpuram, Chenbo Xia; +Cc: dev, jerinj
On 2/20/24 12:40, Nithin Dabilpuram wrote:
> VIRTIO_F_ORDER_PLATFORM is needed feature when working with
> real HW platforms that are exposing virtio-net devices
> via VDPA framework. This feature helps in having more
> real ordering requirements between descriptor updates and
> notification data updates. Hence enable it if the
> device supports the feature.
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> ---
> drivers/net/virtio/virtio_user/virtio_user_dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> index d395fc1676..6ece3c6621 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> @@ -701,6 +701,7 @@ virtio_user_free_vrings(struct virtio_user_dev *dev)
> 1ULL << VIRTIO_F_VERSION_1 | \
> 1ULL << VIRTIO_F_RING_PACKED | \
> 1ULL << VIRTIO_F_NOTIFICATION_DATA | \
> + 1ULL << VIRTIO_F_ORDER_PLATFORM | \
> 1ULL << VIRTIO_NET_F_RSS)
>
> int
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/virtio-user: add VIRTIO_F_ORDER_PLATFORM to feature list
2024-02-20 11:40 [PATCH] net/virtio-user: add VIRTIO_F_ORDER_PLATFORM to feature list Nithin Dabilpuram
2024-04-15 9:45 ` Nithin Dabilpuram
2024-06-10 4:35 ` Maxime Coquelin
@ 2024-06-12 8:34 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2024-06-12 8:34 UTC (permalink / raw)
To: Nithin Dabilpuram, Chenbo Xia; +Cc: dev, jerinj
On 2/20/24 12:40, Nithin Dabilpuram wrote:
> VIRTIO_F_ORDER_PLATFORM is needed feature when working with
> real HW platforms that are exposing virtio-net devices
> via VDPA framework. This feature helps in having more
> real ordering requirements between descriptor updates and
> notification data updates. Hence enable it if the
> device supports the feature.
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> ---
> drivers/net/virtio/virtio_user/virtio_user_dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> index d395fc1676..6ece3c6621 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> @@ -701,6 +701,7 @@ virtio_user_free_vrings(struct virtio_user_dev *dev)
> 1ULL << VIRTIO_F_VERSION_1 | \
> 1ULL << VIRTIO_F_RING_PACKED | \
> 1ULL << VIRTIO_F_NOTIFICATION_DATA | \
> + 1ULL << VIRTIO_F_ORDER_PLATFORM | \
> 1ULL << VIRTIO_NET_F_RSS)
>
> int
Applied to next-virtio/for-next-net.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-12 8:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-20 11:40 [PATCH] net/virtio-user: add VIRTIO_F_ORDER_PLATFORM to feature list Nithin Dabilpuram
2024-04-15 9:45 ` Nithin Dabilpuram
2024-06-10 4:35 ` Maxime Coquelin
2024-06-12 8:34 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).