Re: 20.11.8 patches review and test

[Luca Boccassi <luca.boccassi@gmail.com>]

On Wed, 19 Apr 2023 at 15:26, Kevin Traynor <ktraynor@redhat.com> wrote:
>
> On 19/04/2023 15:23, Ali Alnubani wrote:
> >> -----Original Message-----
> >> From: Luca Boccassi <luca.boccassi@gmail.com>
> >> Sent: Wednesday, April 19, 2023 5:15 PM
> >> To: David Marchand <david.marchand@redhat.com>
> >> Cc: Ali Alnubani <alialnu@nvidia.com>; stable@dpdk.org; dev@dpdk.org;
> >> Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> >> benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>;
> >> Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes
> >> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara
> >> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>;
> >> Kevin Traynor <ktraynor@redhat.com>; Pei Zhang <pezhang@redhat.com>;
> >> qian.q.xu@intel.com; Raslan Darawsheh <rasland@nvidia.com>; NBU-
> >> Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Yanghang
> >> Liu <yanghliu@redhat.com>; yuan.peng@intel.com;
> >> zhaoyan.chen@intel.com
> >> Subject: Re: 20.11.8 patches review and test
> >>
> >> On Wed, 19 Apr 2023 at 14:25, David Marchand
> >> <david.marchand@redhat.com> wrote:
> >>>
> >>> On Wed, Apr 19, 2023 at 3:14 PM Ali Alnubani <alialnu@nvidia.com> wrote:
> >>>>>
> >>>>> I don't think this function prototype is really different in the 20.11
> >>>>> stable branch (putting the __rte_internal tag aside).
> >>>>> Can you trigger this issue on the main branch?
> >>>>>
> >>>>
> >>>> The main branch doesn't reproduce on the same environment.
> >>>
> >>> Ok, same for me, I reproduced for 20.11 but not for main.
> >>>
> >>>
> >>> I think I have the reason.
> >>> We filter headers to be processed by doxygen via a name filter:
> >>>
> >>> FILE_PATTERNS           = rte_*.h \
> >>>
> >>> But this rte_cryptodev_pmd.h driver header has been renamed as
> >>> cryptodev_pmd.h in 21.11.
> >>> So the issue you reported only affects 20.11.
> >>
> >> I can reproduce in debian testing, after backporting the mentioned
> >> commit from main it seems fine, can you confirm as well that it works
> >> in fedora?
> >>
> >> https://github.com/bluca/dpdk-
> >> stable/commit/77f65b61f955fd817b3791049dda3032c459ac59
> >
> > Now I see a different error:
> >
> > [2/4] Generating doc/api/doxygen with a custom command
> > FAILED: doc/api/html
> > /tmp/dpdk/doc/api/generate_doxygen.sh doc/api/doxy-api.conf doc/api/html /tmp/dpdk/doc/api/doxy-html-custom.sh
> > /tmp/dpdk/lib/librte_vhost/rte_vhost_async.h:49: error: rte_vhost_async_channel_ops::transfer_data has @param documentation sections but no arguments (warning treated as error, aborting now)
>
> See
> https://git.dpdk.org/dpdk-stable/commit/?h=21.11&id=adeaf361f0a5bb3992756fd4e727dd11ecca0943

Thanks, any more errors with
https://github.com/bluca/dpdk-stable/commit/b75ebf643de0204d0092a56fbec63f0bcd10e89f
?