From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 879D54407C; Mon, 20 May 2024 23:43:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C25E402F2; Mon, 20 May 2024 23:43:13 +0200 (CEST) Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by mails.dpdk.org (Postfix) with ESMTP id 6C21B402E9 for <dev@dpdk.org>; Mon, 20 May 2024 23:43:11 +0200 (CEST) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-620314aa1d7so31821837b3.2 for <dev@dpdk.org>; Mon, 20 May 2024 14:43:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716241390; x=1716846190; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rUSJitaYCJz0gPQhTXsTfTsbplxMi1YXc/Mc6AP9B9I=; b=e5dG39a/wQBZ+7Z49SE8E/Z+z5eSTD7TeE0K9PzuIosHVb0zd0/fhZ08F5P/3GFNwX 35gHdY6xAd0+LT95/Npai46I5S6Li+ZCjj28Uo43T9YhpCvmPJYy/zNhdjPD1VJyz0f+ pl6+gS2qY92z+cD6PjUZ2UNeYmj48DYoDDoDHAUKG39u7W3+ISKVB+yWXG6ogHSX4wLW BUvPQSNuuQbyTWD0U2o3jolq+iluvZcNBpEjI/WI3lwS70v/mLvQWl0RKoOzMazY9udp HwGOZQIUHbRDJZOBW2r7hFkySen8yWHQLm8nvDLlLkJoBeDqCnCeSDzEhD1pr1QGCDCX Y47g== X-Forwarded-Encrypted: i=1; AJvYcCW3O3Zn1HKSliQUhQ3oY7dOcgm4H2F67w7Lw5IuOX6gE808+vhuTrE5G8r5muqgeCdtN8rGAaJRs4SmEAA= X-Gm-Message-State: AOJu0YyRD4DWG06kgm02RBTvzuVKiwGyqPXlpcXPUdP6zjGMwb2tR8AH uEx2swoDVhqQsckyRuGovZDrrr3nSucv7JSg7thJdwhdOEPYI33j51fO4ruj X-Google-Smtp-Source: AGHT+IEuik8Z9Lyl18XYjguoyITjLSbR0zuhY5CAElDoEpbp0SaP1Hzh9RY4k5q1cKSmo/4WmHXNzw== X-Received: by 2002:a81:ae68:0:b0:61b:e871:9115 with SMTP id 00721157ae682-622affa8a1bmr306443867b3.17.1716241390484; Mon, 20 May 2024 14:43:10 -0700 (PDT) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com. [209.85.219.179]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6209e379299sm49530597b3.108.2024.05.20.14.43.09 for <dev@dpdk.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 May 2024 14:43:09 -0700 (PDT) Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-de5ea7edb90so2798593276.1 for <dev@dpdk.org>; Mon, 20 May 2024 14:43:09 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVP75loxvQ5fMEIR28uFw/3Jd9xfSk7WqWKwhIDruzjC1J+XxA8zS8+HueTpUp0FgGp47v5tw/+tP3XfTw= X-Received: by 2002:a25:8382:0:b0:deb:3b7c:5268 with SMTP id 3f1490d57ef6-dee4f2e8616mr30815465276.29.1716241389358; Mon, 20 May 2024 14:43:09 -0700 (PDT) MIME-Version: 1.0 References: <20240130034925.44869-1-stephen@networkplumber.org> <20240502213618.11391-1-stephen@networkplumber.org> <20240502213618.11391-8-stephen@networkplumber.org> <6bb00014-b2ee-4fc9-bdfd-7583e172d3e2@amd.com> <20240520111804.0ee1fff2@hermes.local> In-Reply-To: <20240520111804.0ee1fff2@hermes.local> From: Luca Boccassi <bluca@debian.org> Date: Mon, 20 May 2024 22:42:57 +0100 X-Gmail-Original-Message-ID: <CAMw=ZnQxROi5WH4+QWE6FO3Owu-sQjL+f7agHbViW-FHWbrc+A@mail.gmail.com> Message-ID: <CAMw=ZnQxROi5WH4+QWE6FO3Owu-sQjL+f7agHbViW-FHWbrc+A@mail.gmail.com> Subject: Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program To: Stephen Hemminger <stephen@networkplumber.org> Cc: Ferruh Yigit <ferruh.yigit@amd.com>, Christian Ehrhardt <christian.ehrhardt@canonical.com>, Patrick Robb <probb@iol.unh.edu>, dpdklab <dpdklab@iol.unh.edu>, Aaron Conole <aconole@redhat.com>, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, 20 May 2024 at 19:43, Stephen Hemminger <stephen@networkplumber.org> wrote: > > On Mon, 20 May 2024 18:49:19 +0100 > Ferruh Yigit <ferruh.yigit@amd.com> wrote: > > > On 5/2/2024 10:31 PM, Stephen Hemminger wrote: > > > There were multiple issues in the RSS queue support in the TAP > > > driver. This required extensive rework of the BPF support. > > > > > > Change the BPF loading to use bpftool to > > > create a skeleton header file, and load with libbpf. > > > The BPF is always compiled from source so less chance that > > > source and instructions diverge. Also resolves issue where > > > libbpf and source get out of sync. The program > > > is only loaded once, so if multiple rules are created > > > only one BPF program is loaded in kernel. > > > > > > The new BPF program only needs a single action. > > > No need for action and re-classification step. > > > > > > It also fixes the missing bits from the original. > > > - supports setting RSS key per flow > > > - level of hash can be L3 or L3/L4. > > > > > > Bugzilla ID: 1329 > > > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > > > > > > > > The libbpf version in my Ubuntu box, installed with package manager, is > > 'libbpf.so.0.5.0', so it doesn't satisfy the requirement and bpf support > > is not compiled for me. > > > > > > @Christian, 'libbpf.so.0.5.0'seems old, it is from 2021, do you know is > > there a reason Ubuntu stick to this version? And can we expect an update > > soon? > > > > > > @Patric, I assume test environment also doesn't have 'libbpf', version: > > '>= 1.0' which we need to test this feature. > > Is it possible to update test environment to justify this dependency? > > > > I think we need to verify at least build (with and without dependency > > met) for the set. > > The BPF API changed a lot, and it is not really possible to support > both. It can be done, but it is a _lot_ of work and requires a lot of shims, so for something optional it's not really worth it. Given libbpf 1.0 also broke ABI, Ubuntu 22.04 and older cannot really get a new version as it's incompatible, so this pmd will simply be skipped there. I think it's fine. 24.04 has a new one.