From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61F0B4404D; Fri, 17 May 2024 13:29:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6E3E4029B; Fri, 17 May 2024 13:29:56 +0200 (CEST) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by mails.dpdk.org (Postfix) with ESMTP id 1BCAD40268 for ; Fri, 17 May 2024 13:29:55 +0200 (CEST) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-61af74a010aso312557b3.0 for ; Fri, 17 May 2024 04:29:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715945394; x=1716550194; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=km8Kuc53qNiBodOokYKjkGwhVyeQNBgApmIEMyz4vvs=; b=aOZe5KFfyD0Ite7Z8hSJFbuSec4A5qF7zkXIDv2qCFz3CLkI7pnNR1+B7zBPEV2Bdy yMJQ75TCnsM8DnH7Mwdlh4t1q4x9ClIC4UXFWAOXZmAI6FCCY/RqAfKKsrE8SI57WFCX LHLUzViW4GIRykG+DuOqxohCLxFF8Ga1Wgpdr1+2LRrrPOHp9V/4Sq8Jv1oILKOsjDOW u7sd+cb73xHvTTPGQyaDjgE0rGq8sZrMf5IA4O9SShKpsOTNscWKy/oPKYlmMgy/fsFZ PEQ+2naHxmORE0KMRgAvjIxcREztD4xZwTTemCmEEtuLfRrUPJiWNqmxvknoLkbidwUK aWfA== X-Forwarded-Encrypted: i=1; AJvYcCW6V0WkxD2G3O2tRQkC1S/g6zJwh4qINg820W8eGIJkgrL2M927MRgjvWJeYSegEnxENSOnKKxy3pmCmDY= X-Gm-Message-State: AOJu0YyDWF2Pv9S2a57lUBrPlr2m+MrGfxYEatQ8xKjnnLj2IqsTzBst psseD1EoIBouv7sKnwObp1BPhhRD5Wd+mdfRObcouvMwytJevnidEr46wRuG X-Google-Smtp-Source: AGHT+IFnQB7rzzI/Wde2u8TDuZ8dv/2Sv0kE0v1Qe+gy0+2aqbjufYvA0PKyCGRCz6L5a8xiUqlJzQ== X-Received: by 2002:a05:690c:f83:b0:61a:d2d9:5488 with SMTP id 00721157ae682-622aff920e2mr271107857b3.7.1715945394225; Fri, 17 May 2024 04:29:54 -0700 (PDT) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com. [209.85.219.177]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6209e2340a3sm39269927b3.4.2024.05.17.04.29.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 May 2024 04:29:53 -0700 (PDT) Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-de6074a464aso30787276.0 for ; Fri, 17 May 2024 04:29:53 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVbSAsCOp+WoA12Kh/mZFdlEMycmhyrXIg7jRr1vKYBrewBg4XBMzISsSoE3ig523n+6+pqRd8p8IdbONs= X-Received: by 2002:a25:a2c2:0:b0:de6:dcd:20ae with SMTP id 3f1490d57ef6-dee4f2e9124mr20595976276.27.1715945393113; Fri, 17 May 2024 04:29:53 -0700 (PDT) MIME-Version: 1.0 References: <20230629125838.1995751-1-christian.ehrhardt@canonical.com> <5843892.MhkbZ0Pkbq@thomas> <7653904.8F6SAcFxjW@thomas> In-Reply-To: From: Luca Boccassi Date: Fri, 17 May 2024 12:29:41 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] doc: ensure sphinx output is reproducible To: Bruce Richardson Cc: Thomas Monjalon , Christian Ehrhardt , dev@dpdk.org, david.marchand@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 27 Nov 2023 at 17:04, Bruce Richardson wrote: > > On Mon, Nov 27, 2023 at 05:45:52PM +0100, Thomas Monjalon wrote: > > 06/07/2023 14:49, Christian Ehrhardt: > > > On Mon, Jul 3, 2023 at 5:29=E2=80=AFPM Thomas Monjalon wrote: > > > > > > > > 29/06/2023 14:58, christian.ehrhardt@canonical.com: > > > > > From: Christian Ehrhardt > > > > > > > > > > By adding -j we build in parallel, to make building on multiproce= ssor > > > > > machines more effective. While that works it does also break > > > > > reproducible builds as the order of the sphinx generated searchin= dex.js > > > > > is depending on execution speed of the individual processes. > > > > [...] > > > > > -if Version(ver) >=3D Version('1.7'): > > > > > - sphinx_cmd +=3D ['-j', 'auto'] > > > > > > > > What is the impact on build speed on an average machine? > > > > > > Hi, > > > I haven't tested this in isolation as it was just a mandatory change > > > on the Debian/Ubuntu side. > > > And the time for exactly and only the doc build is hidden inside the > > > concurrency of meson. > > > But I can compare a full build [1] and a full build with the change [= 2]. > > > > > > That is an average build machine and it is 35 seconds slower with the > > > change to no more do doc builds in parallel. > > > > I would prefer adding an option for reproducible build > > (which is not a common requirement). > > > Taking a slightly different tack, is it possible to sort the searchindex.= js > file post-build, so that even reproducible builds get the benefits of > parallelism? Given the recent attacks with malicious sources being injected in open source projects, reproducible builds are more important than ever and should just be the default. Could we please take this patch as-is? If someone wants to try and fix this searchindex.js in a different way separately it can then be done later and on top of this.