From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E50B4407D; Tue, 21 May 2024 00:25:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DC6140698; Tue, 21 May 2024 00:25:38 +0200 (CEST) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by mails.dpdk.org (Postfix) with ESMTP id D140140696 for ; Tue, 21 May 2024 00:25:36 +0200 (CEST) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-62027fcf9b1so22175957b3.0 for ; Mon, 20 May 2024 15:25:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716243936; x=1716848736; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FL61BRkS47KPkICH92e1UtC14nMlN/Lf1z06cjoDQJE=; b=ugaVO9XrPmb/X8WZiK0ZrM3QBhR7PVcNylV5SwSyDjkwrRmsTi6zokT4xrh5BqP7eC oVNE7foBIfGu2NTYiGS0g+a6Rr6tzgyvHKZmvS25qWFw0O2fMhpWgbu6TcgEItfC97fX 7d7vk1S5r4mVS8PG+9MqJ9RKWYYHN3/L0FrgWYQ2VCMcX6i1Iy8iTcIoEXtQkMeaaH9T exBYKCxp5tiYmd9psR4mO+6rOl4/Vc0qzIFYSbTXBFfdyf1n77zUP1lpThGXwnFGWJWr Uu/zQ7d5GVzknc1FkkCAiBsf6QRMEiPhi+5wv+cgnSizcoUju7L1EU6LrY/qjY+318o0 eGOA== X-Forwarded-Encrypted: i=1; AJvYcCWvzrLKtbji4rUKcA3GtpoBpud+yBueRYjZynTPHf/x0SE/iQIPM0j2JQ/l/zT3eatePnSKFY6L70vebEo= X-Gm-Message-State: AOJu0YxybIa6OxqIEpyLGmGFbVsxbHuSzP26dR7cHDBjVGJV7pF3dSMV UsmGsVNoO0rI+O1vQyO3igAqMVEQ2CzBS+qDZwV2hnaapWWVXtsnCGrs/2FK X-Google-Smtp-Source: AGHT+IEjXs/o/v7sZsuQ//QWzQMeBSbuhOJHGwpc7EZ3PRkUcXC9W0DHf/GQOblV/yLsdbeSIAY2tg== X-Received: by 2002:a81:6c86:0:b0:627:788e:94d4 with SMTP id 00721157ae682-6279723289cmr53367527b3.12.1716243936008; Mon, 20 May 2024 15:25:36 -0700 (PDT) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com. [209.85.219.182]) by smtp.gmail.com with ESMTPSA id 00721157ae682-622ce790e0bsm39678217b3.75.2024.05.20.15.25.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 May 2024 15:25:35 -0700 (PDT) Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-dc6cbe1ac75so2304326276.1 for ; Mon, 20 May 2024 15:25:35 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWDWmSKGLTT2+AeyUz4OK9/ev5sHMMCqxEXldZkrLRQDNnsQMpNZHhXCFG50eP46UArGD/ktR1KajIZL68= X-Received: by 2002:a25:ab8d:0:b0:dc6:db56:eb6a with SMTP id 3f1490d57ef6-df4906e6b46mr5195294276.28.1716243935053; Mon, 20 May 2024 15:25:35 -0700 (PDT) MIME-Version: 1.0 References: <20240130034925.44869-1-stephen@networkplumber.org> <20240502213618.11391-1-stephen@networkplumber.org> <20240502213618.11391-8-stephen@networkplumber.org> <6bb00014-b2ee-4fc9-bdfd-7583e172d3e2@amd.com> <20240520111804.0ee1fff2@hermes.local> <44b38cc3-b6ee-40e3-b6d1-e2d3f51a01fc@amd.com> In-Reply-To: <44b38cc3-b6ee-40e3-b6d1-e2d3f51a01fc@amd.com> From: Luca Boccassi Date: Mon, 20 May 2024 23:25:23 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program To: Ferruh Yigit Cc: Stephen Hemminger , Christian Ehrhardt , Patrick Robb , dpdklab , Aaron Conole , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 20 May 2024 at 23:08, Ferruh Yigit wrote: > > On 5/20/2024 10:42 PM, Luca Boccassi wrote: > > On Mon, 20 May 2024 at 19:43, Stephen Hemminger > > wrote: > >> > >> On Mon, 20 May 2024 18:49:19 +0100 > >> Ferruh Yigit wrote: > >> > >>> On 5/2/2024 10:31 PM, Stephen Hemminger wrote: > >>>> There were multiple issues in the RSS queue support in the TAP > >>>> driver. This required extensive rework of the BPF support. > >>>> > >>>> Change the BPF loading to use bpftool to > >>>> create a skeleton header file, and load with libbpf. > >>>> The BPF is always compiled from source so less chance that > >>>> source and instructions diverge. Also resolves issue where > >>>> libbpf and source get out of sync. The program > >>>> is only loaded once, so if multiple rules are created > >>>> only one BPF program is loaded in kernel. > >>>> > >>>> The new BPF program only needs a single action. > >>>> No need for action and re-classification step. > >>>> > >>>> It also fixes the missing bits from the original. > >>>> - supports setting RSS key per flow > >>>> - level of hash can be L3 or L3/L4. > >>>> > >>>> Bugzilla ID: 1329 > >>>> > >>>> Signed-off-by: Stephen Hemminger > >>>> > >>> > >>> > >>> The libbpf version in my Ubuntu box, installed with package manager, is > >>> 'libbpf.so.0.5.0', so it doesn't satisfy the requirement and bpf support > >>> is not compiled for me. > >>> > >>> > >>> @Christian, 'libbpf.so.0.5.0'seems old, it is from 2021, do you know is > >>> there a reason Ubuntu stick to this version? And can we expect an update > >>> soon? > >>> > >>> > >>> @Patric, I assume test environment also doesn't have 'libbpf', version: > >>> '>= 1.0' which we need to test this feature. > >>> Is it possible to update test environment to justify this dependency? > >>> > >>> I think we need to verify at least build (with and without dependency > >>> met) for the set. > >> > >> The BPF API changed a lot, and it is not really possible to support > >> both. > > > > It can be done, but it is a _lot_ of work and requires a lot of shims, > > so for something optional it's not really worth it. Given libbpf 1.0 > > also broke ABI, Ubuntu 22.04 and older cannot really get a new version > > as it's incompatible, so this pmd will simply be skipped there. I > > think it's fine. 24.04 has a new one. > > > > Does Ubuntu 24.04 have libbpf >= 1.0 ? Yes: https://packages.ubuntu.com/search?keywords=libbpf-dev&searchon=names&suite=all§ion=all