From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0C424291B; Tue, 11 Apr 2023 11:58:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B58A240DFD; Tue, 11 Apr 2023 11:58:45 +0200 (CEST) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by mails.dpdk.org (Postfix) with ESMTP id 3D07C40A8B; Tue, 11 Apr 2023 11:58:44 +0200 (CEST) Received: by mail-yb1-f173.google.com with SMTP id u13so7550139ybu.5; Tue, 11 Apr 2023 02:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681207123; x=1683799123; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9X2TmYUG4t6uKcKtLj4gSvtdv+NZU41rYCXaG/3rUnI=; b=FRFqoYc+7sOGcaBgG+YQMTa03L7pqVQSYJ0y9+/eILsDQLnN9M6M2+kwps52n2Euey vCDCiML/HwpRmmY/suR1Gj2DzkJOIKd1ecq436DjvSycZ9VeaJxVMfav+L+bLYtFMahv xd6a32vz9XRVsNLnk5MNol5wk74vERazBrhY4uKy4v49c4REBQQQ75X2juB9/oVIpbLP pYNRLaFc6/NQDItcP3jJ71JxHLtZ+ADkGPYvWj3OaWnsIj9LZwAjeK6891PWda8DwFZL j2v/uX3hdB79QVDdhE+V5f+RYYWNmBTRQdmukne4Wq1MRDJzFigNiQp7rrzBhTEsuA1I 1RGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681207123; x=1683799123; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9X2TmYUG4t6uKcKtLj4gSvtdv+NZU41rYCXaG/3rUnI=; b=HZohaW4IjXjajvk/kJJVrBXMNbDVl8YMkpVJ335+H5oVDhSWKE0gt2Lo7pJmAnKFdQ bVOhRtvl+hOeEoN80w0RzzhEasPSGno+4ZSQVZjoerZN1+4+mNU/n5BJJpAE/7WX1u02 hCYqL2lvjtvZ2UNwsdhf1U0K3VTPOvd5ua4cJ8qUbsJ+J7qj/VmaW+ur3GvvLbK8u4mf tobTGd9UhTsFW6t8fF2F4HglxWZ6DgauhParwF1BSRns4ZC7W1S/0FMO0O4rbw+YBgMo HpJRHwpmj8ObH3MSYAEgZOxyi7lX0K6mKu2IsYKoZ61q7sjVLLTPN+VRJvOz9/RdcdlH mCOw== X-Gm-Message-State: AAQBX9eGjXUnuxgCA7gRlrI7XRjIKxdJ3VK2Oh7GUM1yiwkUdVoFSC+V vbXh7n7EcSULqnhxj26+CLfG07h2SQByHATp2TA= X-Google-Smtp-Source: AKy350acyCNPB2qi51OCf8G+cx/FJrbsbm6Vui2aXQGDPdQGo1oKzaqvPRZ7fegNhyx2MmXfGIabewvTBy7/9OfYVeM= X-Received: by 2002:a25:e0c5:0:b0:b8b:fd23:5028 with SMTP id x188-20020a25e0c5000000b00b8bfd235028mr1142384ybg.3.1681207123482; Tue, 11 Apr 2023 02:58:43 -0700 (PDT) MIME-Version: 1.0 References: <20221128105232.1394896-1-luca.boccassi@gmail.com> <98CBD80474FA8B44BF855DF32C47DC35D8751A@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D8751B@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D8785E@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8785E@smartserver.smartshare.dk> From: Luca Boccassi Date: Tue, 11 Apr 2023 10:58:32 +0100 Message-ID: Subject: Re: 20.11.7 patches review and test To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: stable@dpdk.org, dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, ktraynor@redhat.com, Wei Ling Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 11 Apr 2023 at 08:22, Morten Br=C3=B8rup = wrote: > > > From: Morten Br=C3=B8rup [mailto:mb@smartsharesystems.com] > > Sent: Monday, 28 November 2022 13.08 > > > > > From: Luca Boccassi [mailto:luca.boccassi@gmail.com] > > > Sent: Monday, 28 November 2022 12.55 > > > > > > On Mon, 28 Nov 2022 at 11:35, Morten Br=C3=B8rup > > > wrote: > > > > > > > > +CC Andrew Rybchenko as co-signer on the mempool patch in mainline. > > > > > > > > > From: luca.boccassi@gmail.com [mailto:luca.boccassi@gmail.com] > > > > > Sent: Monday, 28 November 2022 11.53 > > > > [...] > > > > > > > mempool: fix get objects from mempool with cache > > > > > > > > Reviewed stable release patch [1], comparing it to the accepted > > > mainline patch [2]. > > > > > > > > [1]: https://git.dpdk.org/dpdk- > > > stable/commit/?h=3D20.11&id=3D26cb4c81b552594292f7c744afb904f01700dfe= 8 > > > > [2]: > > > https://patchwork.dpdk.org/project/dpdk/patch/20221007104450.2567961-= 1- > > > andrew.rybchenko@oktetlabs.ru/ > > > > > > > > This is not correct: > > > > + __MEMPOOL_STAT_ADD(mp, get_success_bulk, 1); > > > > + __MEMPOOL_STAT_ADD(mp, get_success_objs, n); > > > > > > > > The old macro did more, so it should be: > > > > + __MEMPOOL_STAT_ADD(mp, get_success, n); > > > > > > > > This is only visible if built with RTE_LIBRTE_MEMPOOL_DEBUG. > > > > > > > > Besides that, it looks perfectly good to me. > > > > > > Can you test a patch and send it? > > > > Extremely busy these days... Not sure I can make it within the deadline= . > > > > Alternatively, consider omitting the patch. It only fixes some performa= nce > > issues for certain use cases. > > Now the omitted patch shows up as [Bug 1212], so I will try to provide a = v2 patch, continuing the work you already put into the v1 patch. > > [Bug 1212]: https://bugs.dpdk.org/show_bug.cgi?id=3D1212 > > However, I'm not good at git, so could you please provide a step-by-step = guide for contributing such a patch to the 20.11 stable branch? > > 1. git clone git://dpdk.org/(FIXME: Which URL?) > 2. (Edit and test the code.) > 3. git add lib/mempool/rte_mempool.h > 4. git commit (FIXME: Which additional parameters here?) -m "mempool: fix= get objects from mempool with cache" -m "Edit description in editor." --si= gnoff --edit (FIXME: And which special lines to add in the patch descriptio= n?) > 5. git format-patch -1 -v 2 (FIXME: Which additional parameters here?) > 6. git send-email (FIXME: Which additional parameters here?) -to stable@d= pdk.org v2-000*.patch Use the 20.11 branch from the https://git.dpdk.org/dpdk-stable/ repository. You can find instructions on how to send patches here: http://core.dpdk.org/contribute/