From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8C97A00C3; Mon, 28 Nov 2022 12:55:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5296542686; Mon, 28 Nov 2022 12:55:40 +0100 (CET) Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by mails.dpdk.org (Postfix) with ESMTP id C63B64067C; Mon, 28 Nov 2022 12:55:38 +0100 (CET) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-3bfd998fa53so50024107b3.5; Mon, 28 Nov 2022 03:55:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=O+rczv2jMXmKJ5P7L3kg2N2/7Jqjf+/92ZTqAcT34RE=; b=Z9IduguEx3tae1ByB4egdvdflqXovA7aaD644gyUKjc5Kwx4yfmL6OpQR2A2Ie+ldQ 35+H8JZOb1iER2IAn/8owFgkUbzP1GMnCf1ktmfm4e0jKYfq6W0pQEierb5DbwdsYK/R MQ36+ezdoZqHH/mIl1CDb4SPKNrh3ll9/iYblDpJ+mpNqY73YQF8PWJ4SknNofGgLkwx 89dOnvKeH/43TsK5/nYEbkmwIaNWMPROvClTa2TjlPbRZVUGMuFp/oUtiOf+9s8tEGu0 BJXAHmpecJ3NCKDsc2hZNuHodKOy0viQ+uG80XK8B9Nptxaw7RGczJoxJER6O3DMjpNH JamQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O+rczv2jMXmKJ5P7L3kg2N2/7Jqjf+/92ZTqAcT34RE=; b=sJSBjRaECbgLzhlQbCV+/F0ojZCv+LaMy7Prbk2YVSm9yV0Ycz18DUu8Scepqllq6Y fKMGTCe+QOAXXw20taVipFY1xTW/pPALIRls6PwkuuRXtTpgdrrKsgfRofs7vHn1GiXE dOZVScUiisOAJK43CL0WJDWunlgRyqkSrj3VcpoQB5cvaSUwolbLyjzVkGgKMlHM/x07 OaOEFrmDO90MoK7LqUKrnGoGEYI+DM2mAA37Ve5EBB1iFd6ozyy6lewz706wXBPqEFy1 gVTXZZsCgVpy2ziI1t3acTQN7X5epwbuk7RBw7VGG0E4K0G19s/kfwveV/UVf3ITSJzr x/Mw== X-Gm-Message-State: ANoB5plhYWQTEzLvVkYPA3PxbnmXDg8oIjxmghk4NtT2wIi8aa5qMQN7 SADnV/mMOtcHEVbt8pbpk5pc2puxeUxQ6FZpbqfqiYVS5j0= X-Google-Smtp-Source: AA0mqf7Dr1Fl+jhhJBWZyPYURaIMBHIkyZFafdrbFYomvcGc0186BA5Gdgh+JIP6fWfa5K7tYu3hymyS2sFf7H6CrdA= X-Received: by 2002:a05:690c:7a0:b0:3a4:c5b7:4ffa with SMTP id bw32-20020a05690c07a000b003a4c5b74ffamr32957751ywb.131.1669636538110; Mon, 28 Nov 2022 03:55:38 -0800 (PST) MIME-Version: 1.0 References: <20221128105232.1394896-1-luca.boccassi@gmail.com> <98CBD80474FA8B44BF855DF32C47DC35D8751A@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8751A@smartserver.smartshare.dk> From: Luca Boccassi Date: Mon, 28 Nov 2022 11:55:26 +0000 Message-ID: Subject: Re: 20.11.7 patches review and test To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: stable@dpdk.org, dev@dpdk.org, andrew.rybchenko@oktetlabs.ru Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 28 Nov 2022 at 11:35, Morten Br=C3=B8rup = wrote: > > +CC Andrew Rybchenko as co-signer on the mempool patch in mainline. > > > From: luca.boccassi@gmail.com [mailto:luca.boccassi@gmail.com] > > Sent: Monday, 28 November 2022 11.53 > > > > Hi all, > > > > Here is a list of patches targeted for stable release 20.11.7. > > > > The planned date for the final release is the 12th of December. > > > > Please help with testing and validation of your use cases and report > > any issues/results with reply-all to this mail. For the final release > > the fixes and reported validations will be added to the release notes. > > > > A release candidate tarball can be found at: > > > > https://dpdk.org/browse/dpdk-stable/tag/?id=3Dv20.11.7-rc1 > > > > These patches are located at branch 20.11 of dpdk-stable repo: > > https://dpdk.org/browse/dpdk-stable/ > > The link with pre-selected branch seems to be: > https://git.dpdk.org/dpdk-stable/?h=3D20.11 > > [...] > > > Morten Br=C3=B8rup (2): > > eal/x86: add 256 bytes copy for AVX2 > > LGTM. > > > mempool: fix get objects from mempool with cache > > Reviewed stable release patch [1], comparing it to the accepted mainline = patch [2]. > > [1]: https://git.dpdk.org/dpdk-stable/commit/?h=3D20.11&id=3D26cb4c81b552= 594292f7c744afb904f01700dfe8 > [2]: https://patchwork.dpdk.org/project/dpdk/patch/20221007104450.2567961= -1-andrew.rybchenko@oktetlabs.ru/ > > This is not correct: > + __MEMPOOL_STAT_ADD(mp, get_success_bulk, 1); > + __MEMPOOL_STAT_ADD(mp, get_success_objs, n); > > The old macro did more, so it should be: > + __MEMPOOL_STAT_ADD(mp, get_success, n); > > This is only visible if built with RTE_LIBRTE_MEMPOOL_DEBUG. > > Besides that, it looks perfectly good to me. Can you test a patch and send it? Kind regards, Luca Boccassi