From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19BD54298A; Wed, 19 Apr 2023 16:38:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B059540A79; Wed, 19 Apr 2023 16:38:13 +0200 (CEST) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by mails.dpdk.org (Postfix) with ESMTP id 5050E4021F; Wed, 19 Apr 2023 16:38:12 +0200 (CEST) Received: by mail-yb1-f177.google.com with SMTP id t15so4353385ybb.1; Wed, 19 Apr 2023 07:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681915091; x=1684507091; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FNCIkCumjaKO4CJFWYBJOUrUQu5luq6ihKC1WbrnPEc=; b=o7jp0ZyOrbXtfb2CGOzgnTlyU/k8qPatTk/SSCrtJZlWkMc6Q203Ckeq3JOftw+okE hZwi3VUQ/d7tNOYgmdwOdu2kuSqZJwJnODuxQBi1TzOl3bEu7OaHFOKPDLyOPgwTqLfP eXucnMOipUeKxulHWPBCCt4EEdsrU+oYSbcYTjomWO3wbIPgWTFCJUqI8YwQmYpVWeYY zpuf3k37AdJlKo4avUUHCi3xCJ+mTdl0igSTxqOBnh2FMUM0NGVAvWgJ74Bt+ljvbm+6 l6ysB2l0eq0NZeE5NRLawi4L4DWnwIlqDD/A10QFR+9Rz7KrtoxFdaJExJNQkD1/rikT 6q+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681915091; x=1684507091; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FNCIkCumjaKO4CJFWYBJOUrUQu5luq6ihKC1WbrnPEc=; b=LKVSeTqxGIj95Bm0D4LejHgd3aIF4nCZRN1IAZugli+Q6i/GTl+CIIvN2Ja/6J60Zb wzgQTA/eA+6yBij+82z1ZrT0KBmQKkiukB+po1sqVuyrvfN0AL4XxaMpAos1h5xWBjc/ PrmWn2dyvAoc0xmbUoO18OUgix9t6NUYMvkhv6Nrj3WLnTcM9vTSjc9kXqDlyifavxeq YQJZsES6Izqe1C8oE1PgrdntkmmEqnhrN6CDJQSNvPHYmw9YpKeIULBGGfH5UVlhSY1c qTPcmvrhfMhMyswg1SNU3KGdTaUZBwaaloKhrWuQe2+zl/f7hEp/fbGALn7fICAr126N HBhg== X-Gm-Message-State: AAQBX9ds1cUtuwyIyH/4rlQzpYcv7C0ueMeowYwCOpLyNZaJezlx/dLL J0iwa87GXP0jo5x0Irk4gV3iElT22KLIeanncPk= X-Google-Smtp-Source: AKy350Zi9PB6qCmC5QJP3OUgy7RjqkIr+TrG/kzqocZvaK/QxEBIwMqg+4age+ee0YD17oonKu1K8GHS7Hzu6NlsS3o= X-Received: by 2002:a25:ae53:0:b0:b8f:490c:a0db with SMTP id g19-20020a25ae53000000b00b8f490ca0dbmr25785036ybe.59.1681915091616; Wed, 19 Apr 2023 07:38:11 -0700 (PDT) MIME-Version: 1.0 References: <20230331182006.708984-1-luca.boccassi@gmail.com> In-Reply-To: From: Luca Boccassi Date: Wed, 19 Apr 2023 15:38:00 +0100 Message-ID: Subject: Re: 20.11.8 patches review and test To: David Marchand Cc: Kevin Traynor , Ali Alnubani , "stable@dpdk.org" , "dev@dpdk.org" , Abhishek Marathe , "benjamin.walker@intel.com" , David Christensen , Hemant Agrawal , Ian Stokes , Jerin Jacob , John McNamara , Ju-Hyoung Lee , Pei Zhang , "qian.q.xu@intel.com" , Raslan Darawsheh , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Yanghang Liu , "yuan.peng@intel.com" , "zhaoyan.chen@intel.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 19 Apr 2023 at 15:36, David Marchand wr= ote: > > On Wed, Apr 19, 2023 at 4:30=E2=80=AFPM Luca Boccassi wrote: > > > > On Wed, 19 Apr 2023 at 15:26, Kevin Traynor wrote= : > > > > > > On 19/04/2023 15:23, Ali Alnubani wrote: > > > >> -----Original Message----- > > > >> From: Luca Boccassi > > > >> Sent: Wednesday, April 19, 2023 5:15 PM > > > >> To: David Marchand > > > >> Cc: Ali Alnubani ; stable@dpdk.org; dev@dpdk.o= rg; > > > >> Abhishek Marathe ; > > > >> benjamin.walker@intel.com; David Christensen ; > > > >> Hemant Agrawal ; Ian Stokes > > > >> ; Jerin Jacob ; John McN= amara > > > >> ; Ju-Hyoung Lee ; > > > >> Kevin Traynor ; Pei Zhang ; > > > >> qian.q.xu@intel.com; Raslan Darawsheh ; NBU- > > > >> Contact-Thomas Monjalon (EXTERNAL) ; Yanghang > > > >> Liu ; yuan.peng@intel.com; > > > >> zhaoyan.chen@intel.com > > > >> Subject: Re: 20.11.8 patches review and test > > > >> > > > >> On Wed, 19 Apr 2023 at 14:25, David Marchand > > > >> wrote: > > > >>> > > > >>> On Wed, Apr 19, 2023 at 3:14=E2=80=AFPM Ali Alnubani wrote: > > > >>>>> > > > >>>>> I don't think this function prototype is really different in th= e 20.11 > > > >>>>> stable branch (putting the __rte_internal tag aside). > > > >>>>> Can you trigger this issue on the main branch? > > > >>>>> > > > >>>> > > > >>>> The main branch doesn't reproduce on the same environment. > > > >>> > > > >>> Ok, same for me, I reproduced for 20.11 but not for main. > > > >>> > > > >>> > > > >>> I think I have the reason. > > > >>> We filter headers to be processed by doxygen via a name filter: > > > >>> > > > >>> FILE_PATTERNS =3D rte_*.h \ > > > >>> > > > >>> But this rte_cryptodev_pmd.h driver header has been renamed as > > > >>> cryptodev_pmd.h in 21.11. > > > >>> So the issue you reported only affects 20.11. > > > >> > > > >> I can reproduce in debian testing, after backporting the mentioned > > > >> commit from main it seems fine, can you confirm as well that it wo= rks > > > >> in fedora? > > > >> > > > >> https://github.com/bluca/dpdk- > > > >> stable/commit/77f65b61f955fd817b3791049dda3032c459ac59 > > > > > > > > Now I see a different error: > > > > > > > > [2/4] Generating doc/api/doxygen with a custom command > > > > FAILED: doc/api/html > > > > /tmp/dpdk/doc/api/generate_doxygen.sh doc/api/doxy-api.conf doc/api= /html /tmp/dpdk/doc/api/doxy-html-custom.sh > > > > /tmp/dpdk/lib/librte_vhost/rte_vhost_async.h:49: error: rte_vhost_a= sync_channel_ops::transfer_data has @param documentation sections but no ar= guments (warning treated as error, aborting now) > > > > > > See > > > https://git.dpdk.org/dpdk-stable/commit/?h=3D21.11&id=3Dadeaf361f0a5b= b3992756fd4e727dd11ecca0943 > > > > Thanks, any more errors with > > https://github.com/bluca/dpdk-stable/commit/b75ebf643de0204d0092a56fbec= 63f0bcd10e89f > > With those two backports, it works for me. > > b75ebf643d - (HEAD -> 20.11, bluca/20.11) vhost: fix doxygen warnings > (6 minutes ago) > 77f65b61f9 - lib: remove empty return types from doxygen comments (23 > minutes ago) > a75247cbdc - (stable/20.11) crypto/snow3g: fix snow3g enqueue stat > increment (24 hours ago) Alright, ship it