From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01968A0524; Thu, 7 Jan 2021 18:20:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E3104140FE0; Thu, 7 Jan 2021 18:20:36 +0100 (CET) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by mails.dpdk.org (Postfix) with ESMTP id 552FA140FE0 for ; Thu, 7 Jan 2021 18:20:35 +0100 (CET) Received: by mail-yb1-f179.google.com with SMTP id d37so6801843ybi.4 for ; Thu, 07 Jan 2021 09:20:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VPhag1gvTT3tI60OpZOCUF5JizcsyT5QW0R0lx4JoS8=; b=uRtAtNea0Lu21b4uZ3HSiA65C0kqiBZ/8MTuhWpOTGjf7/ItQIxJf6Jlh8viPUPzje K17KmaImXp5TBsWfrBnuXl9m1dJK8eXQlcgDeq/6VzkdbOWJ/+kavLTVnXH0JQv5SCqI n+2Mbx0EwuoRbOZV2YsuKTjMxZlESagKsZ9FJqprqOAhYHfh+9OpP/9dLWYLd3bF+bba Kh+rY7J+JaQ1DE60s+aaGPwIqllhWYScXHBg0od9BZDdKNFvMyW2oIjFUurV4xV9+gWP JI5tQAT12G8aLytoFqoGhl1v0yqsyE0sz98++xKtbbLltSMMYZIBSgS/tSZDRe8E4JWn fqdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VPhag1gvTT3tI60OpZOCUF5JizcsyT5QW0R0lx4JoS8=; b=qp5stHLA1JG7w1V0yW1nxAWdv0cRDcFi6vTJRBJoOv95AFc+pn23/5Ju0I7wQiXoeJ M5Ock1mVCdgjnCUHh+EMgd24BCmU7Cn2QlcDQEMH6hl3GaT3yrik3stxmVGmbUq55lR1 85AWB2WqbDXnmvfTt3ihgHGiQKKAi2xU1eWWSjliFWnX7EML54ektigJimr5+BDCTT37 pZ8xVSVo0eCLpvtS+DRXN7qCFDWUhLzvSliRAhT5geIGHKf9xUFm+EMcHmjrdOSCFuD4 7URdNlrvQQPJDy+QK9HpnH2GwWGrqxk4d1WX9GtY2y5qvci52LI3JLo2XOVYdUo5g3Cj X3Pw== X-Gm-Message-State: AOAM530W3tarWV9rxs3FOVoiMwGVXzeCyJdQG0wrMtusNJwv49E6Qgz2 gT06csO1j2ZPjK+aCxsfFxBk8GsCaJ8OHbmAcRQ= X-Google-Smtp-Source: ABdhPJwFrdgPFiL2/DF2DCm6qSumnUZx0PR17tfkYz8hMRLllq2nZOypPbq+dNBgE+oJXioVlp5qhzPtivjLzzaVbpk= X-Received: by 2002:a25:d392:: with SMTP id e140mr15743342ybf.70.1610040034746; Thu, 07 Jan 2021 09:20:34 -0800 (PST) MIME-Version: 1.0 References: <20201229194144.17824-1-ashish.sadanandan@gmail.com> <20201229121008.3644fed4@hermes.local> <20210106132132.GK2631@platinum> In-Reply-To: From: Ashish Sadanandan Date: Thu, 7 Jan 2021 10:20:08 -0700 Message-ID: To: David Marchand Cc: Olivier Matz , Stephen Hemminger , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, On Thu, Jan 7, 2021 at 1:02 AM David Marchand wrote: > On Thu, Jan 7, 2021 at 2:42 AM Ashish Sadanandan > wrote: > > > > Hi Olivier, > > > > On Wed, Jan 6, 2021 at 6:21 AM Olivier Matz > wrote: > > > > > > Hi Ashish, > > > > > > Yes, it should reference the patch that introduced the issue. In this > case, > > > it should be: > > > > > > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") > > > > > > Can you please also change the title to start with "fix", for > > > instance like this: > > > > > > mbuf: fix inclusion from c++ > > > > > > You can also add "Cc: stable@dpdk.org" in the commit log. > > > > > > Some documentation can be found in doc/guides/contributing/patches.rst > > > > Thanks for the pointers. I've made the changes above. However I don't > > know if I'm using the message ID for --in-reply-to correctly, since I > > seem to be creating a new thread each time. > > You can get the message ID in various places. > I usually take the info from patchwork and update the previous patch > state to Superseded at the same time. > > So in your case, the v1 patch was: > http://patchwork.dpdk.org/patch/85878/ > > Message ID: 20201229194144.17824-1-ashish.sadanandan@gmail.com > > So for the v2: > git send-email --to dev@dpdk.org --cc-cmd ./devtools/get-maintainer.sh > --cc XXX --in-reply-to > '20201229194144.17824-1-ashish.sadanandan@gmail.com' v2-*.patch > > This is almost the exact command I ran (except for the --cc-cmd arg since I don't have the Linux source tree cloned). Just tried it once more, but I think it created a new thread again! I don't get what I'm doing wrong and am terribly sorry for the spam I've been generating. - Ashish > > -- > David Marchand > >