From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12D67A00C2; Wed, 4 Jan 2023 19:18:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0527742D15; Wed, 4 Jan 2023 19:18:22 +0100 (CET) Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by mails.dpdk.org (Postfix) with ESMTP id 199B840041; Wed, 4 Jan 2023 19:18:21 +0100 (CET) Received: by mail-ej1-f51.google.com with SMTP id u9so84809273ejo.0; Wed, 04 Jan 2023 10:18:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Cz9dj3rdx2vA2sNS7PMHKkXEj26zJK0drZs8lfTSNKU=; b=G2VFOz47edQfr0tcxa8v5mMRt8WvqqEPnpjt+7PpkZRSYKT7DLxKcDiRbIaOe1uZJI aUdW6KLDZAUDqSXhNy8/MCrJRgztCoSAVCiZ/yUrU4qIxxe5+qq8H8GbTaq7czi8dlfX zye0x63hQwUQ6VpnnddDnLE9JzxAzQ/FISRYy4NZ1eb6pVDgsZpf2a11/BfbetdrEugB hZqLQRTueIpEvBRVbb+UnTUR5KUsYaMGr0mZx0bks8xXDXGxabB3ueFc2Y1vdKVogYTQ nye0RNdRwL0xyEmb6hOZAoaJRvph82tQLW5TbRDxJ4QIb+SuKm9lt1vO7p4yH6f3J95L VgvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Cz9dj3rdx2vA2sNS7PMHKkXEj26zJK0drZs8lfTSNKU=; b=Rhyumg9pTzqASLY04C12aZtSh27dd8bWFlyHhMpg7nQbeKLnlrbrKUBbMUfsW4qxMQ OmB4uSzy/ovLlPjlorMniyaliswDF1Sd2ZZXKPTa5npi01FX5j4/vSxknQzPLmV2WFaX 9Zx4pg16+EAa34GrNP6sIKfvyloh69nstWFbxe/AMZye/AhU37dcgfqKqrtIMG5XZsr/ hhSrYHNQdL/jt8vPTtuj9pgO7WGlqnOnjlMie2vFNOIDhYLpXh4VwDPHEHtqH1ySgIc2 4Ofztu2LU7hvwDYhHuM/5u4hMDfyN0IvTaFtjtgNfa9KHae+DBpx9gj4PT030mjzuR7I Ni7Q== X-Gm-Message-State: AFqh2kpV/8Nhf789ts/UUPtAN7oStBtLcP59Tq7ANyprwedSQVRuR2TU PyPxI97WfZ41Zl3t16DudnGjx/fRHDPkISuhF+5D0otVEz9s4wqp X-Google-Smtp-Source: AMrXdXvNiEw63HIlccoD80nQIDrq0YM8kxqVtWCykS84rNd28zuoV+XxF7FV+fsVGTdxVLTyt2zvOh1Xpnrc/D25ogs= X-Received: by 2002:a17:906:4ad3:b0:7c0:f459:a0e4 with SMTP id u19-20020a1709064ad300b007c0f459a0e4mr2640364ejt.155.1672856300752; Wed, 04 Jan 2023 10:18:20 -0800 (PST) MIME-Version: 1.0 References: <20230103185732.2007210-1-ashish.sadanandan@gmail.com> <20230104000030.187857-1-ashish.sadanandan@gmail.com> <20230104142456.320fc95a@sovereign> In-Reply-To: <20230104142456.320fc95a@sovereign> From: Ashish Sadanandan Date: Wed, 4 Jan 2023 11:17:52 -0700 Message-ID: Subject: Re: [PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt To: Dmitry Kozlyuk Cc: dev@dpdk.org, john.levon@nutanix.com, stable@dpdk.org Content-Type: multipart/alternative; boundary="00000000000091124505f17435ad" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000091124505f17435ad Content-Type: text/plain; charset="UTF-8" On Wed, Jan 4, 2023 at 4:24 AM Dmitry Kozlyuk wrote: > 2023-01-03 17:00 (UTC-0700), Ashish Sadanandan: > > The code added for allowing --huge-dir to specify hugetlbfs > > sub-directories has a bug where it incorrectly matches mounts that > > contain a prefix of the specified --huge-dir. > > > > Acked-by: Dmitry Kozlyuk > Thanks for reviewing > > The second one can be done before the loop. > Please declare all variables at the beginning of the block per code style. > Done > > Nit: maybe a single comment for both conditions would be more clear: > Done --00000000000091124505f17435ad Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Jan 4, 2023 at 4:24 AM Dmitry= Kozlyuk <dmitry.kozliuk@gma= il.com> wrote:
2023-01-03 17:00 (UTC-0700), Ashish Sadanandan:
> The code added for allowing --huge-dir to specify hugetlbfs
> sub-directories has a bug where it incorrectly matches mounts that
> contain a prefix of the specified --huge-dir.
>

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

<= /div>
Thanks for reviewing
=C2=A0

The second one can be done before the loop.
Please declare all variables at the beginning of the block per code style.<= br>

Done
=C2=A0

Nit: maybe a single comment for both conditions would be more clear:

Done
=C2=A0
--00000000000091124505f17435ad--