From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17728A00C2; Wed, 4 Jan 2023 19:18:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C62242D21; Wed, 4 Jan 2023 19:18:27 +0100 (CET) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by mails.dpdk.org (Postfix) with ESMTP id 0564D40697; Wed, 4 Jan 2023 19:18:26 +0100 (CET) Received: by mail-ej1-f41.google.com with SMTP id fc4so84556634ejc.12; Wed, 04 Jan 2023 10:18:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KFV+EJPuvMF30q/K9ITbQ35uW33xx2J+ZPJqAf1ejHg=; b=TDk0tSDHX4ie+2IcDgiD2kX+vynjvrCE0UmHR3A67NjCQ+7x/qSisHipZVc0mlZQIX zoZK47Prfnnvf/4Oe4+dPKEStMvK2sltmCDztkY8N73WDZmWDDXR7dhPrrqNq+5MV6j0 uZAGuJ5UB+OD5JWnQ1FU4XYkGl2rtb3YZWZoosB/n11wGCLo9SZn5TANf4xxYhJdNflH bsh0ZSaNXQyymD4cPBsn5usz+Mk34fNwMEjlYyi6UCBiLqKwy4BMrJIa18ObuhrjY4h4 ZutMtFGbM0UL8gq+T8Uie/4kUnPMlNIzsVU3LNojhiYVvxzI2izS5jUen0oI9Bqjn0Rm 35EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KFV+EJPuvMF30q/K9ITbQ35uW33xx2J+ZPJqAf1ejHg=; b=yJF9Wtm+6ptNV7su/X0UXn8I85vyRVbQwDzDabh9o+YpTNDbo1KsOMbC4REAxPBpZp JoSozY2PvK49x/UVjuyM7IcCzwd+myiOzUVJqJgMyUxHRUbYFaRmUgB2rb8ROS/bOOxI HGpoj6lSXJnNXiw8j76NfPw/ZGdDFvVcbkkWU8UZQLTYp8ZU+Bu1N0bI7K8mf2u9OPhU 7s08dh674GPjJu24PXlQsKmjlT4A5wHncVcFj+IwoQtZNAIwdE9QFCq1kDDFIy3Hc0N/ tOezweLvuU+EXgyVLhQnqt+kaTVrGoY9jbCdvR/j6+G8iq4dLcTs/YT9SZApGs+BT4nY GcZg== X-Gm-Message-State: AFqh2kru/6RHh1rXjmdJq2v+VtQdhXVtvhiALptqVAgwrU8Q4Yonm6Ww GMqNjWlGouHbOKAoiqivL7exUQILeavSTGOC3vtDGYYbp0+qqmgU X-Google-Smtp-Source: AMrXdXtvph0rIa4d9gjvjTYSvtIC4HKFd1K14YnrSYLjeKW1a+eqmdE32mRCask9pWwNj09SID+0U7UG8oshOrDgZjw= X-Received: by 2002:a17:907:234a:b0:7c1:6344:83e with SMTP id we10-20020a170907234a00b007c16344083emr3477088ejb.560.1672856305816; Wed, 04 Jan 2023 10:18:25 -0800 (PST) MIME-Version: 1.0 References: <20230103185732.2007210-1-ashish.sadanandan@gmail.com> <20230104000030.187857-1-ashish.sadanandan@gmail.com> In-Reply-To: From: Ashish Sadanandan Date: Wed, 4 Jan 2023 11:17:58 -0700 Message-ID: Subject: Re: [PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt To: John Levon Cc: dev@dpdk.org, stable@dpdk.org Content-Type: multipart/alternative; boundary="000000000000de583005f17435f2" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000de583005f17435f2 Content-Type: text/plain; charset="UTF-8" On Wed, Jan 4, 2023 at 9:22 AM John Levon wrote: > On Tue, Jan 03, 2023 at 05:00:30PM -0700, Ashish Sadanandan wrote: > > > The code added for allowing --huge-dir to specify hugetlbfs > > sub-directories has a bug where it incorrectly matches mounts that > > contain a prefix of the specified --huge-dir. > > Sorry for the trouble & thanks for the fix. > Thanks for reviewing > > Shouldn't this comment say "Ignore any mount that is not a parent path of > hugepage_dir" ? > Doh, typed the opposite of what I wanted to say :) Fixed. > > regards > john > --000000000000de583005f17435f2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable