From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8C4CA09FF; Tue, 29 Dec 2020 21:22:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2858E2B91; Tue, 29 Dec 2020 21:22:36 +0100 (CET) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by dpdk.org (Postfix) with ESMTP id 457752B8C for <dev@dpdk.org>; Tue, 29 Dec 2020 21:22:34 +0100 (CET) Received: by mail-yb1-f175.google.com with SMTP id r63so6341803ybf.5 for <dev@dpdk.org>; Tue, 29 Dec 2020 12:22:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lBVaOv/ib6GU6mnDxxHtfUUuFGEzyOxELQFZ0nuW8iI=; b=fP7tOVDrqjL5oqQ7kW3FeIkVD8iAzARd2wkH8z2/+WCYaruuwA1OQWpewhL5zcFDG0 ablFW9H0QDCy1p6MXKvvmlvpAPCjDUQ96sseI37+qTtEzH/VvmBCfr8EXcTh1guUtq1u 2foworheMsXkfGr84vp/wqJuWsZXZRU07ClV5vCUgGcXaBRs+fXo4edshklsaploWKJ4 bMrm0mr4jMp+7dLwDtl3ZE+VFIXcIHIP1IptX+cAzR5Jmya5Q5hTrccVbWANYPnB0E/v 3/9dQ1OTHgW8rCU4XXMkicg0VBV1pFYTL36KYuphe2ZvVltnb/o9DPOq5XXJR/kKjvuY CvbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lBVaOv/ib6GU6mnDxxHtfUUuFGEzyOxELQFZ0nuW8iI=; b=I2ddN3VRpVJRPsMAPv21++Qn6eVlxz/aRRcPpM1tREQDCyFramjHnqtnpc2Aty00it CQZIsQTFZWg7If5MZyhoAa7ooC67L+LP2PKIPmljIZ1V5MBHSNJWkFnP0y1uXWmXiJjl 79HLNiPBkmM2OayhgLjhoWImXM+4Ld8bYiktdgAAlNF1dgbm8l3OSmeawuN3kTs5NMJ5 xucROylQ8Ae4fzfq5ynNdU0QlzNXxZameVI199PXylCin2q9RHRuVI4DcEZXzUg9d8zM yccuySkfnpjQGEhriEkifIRq2zw7WSMkTKxc+JA517qwZoM9hoF2Wyi6Nj97dh9hFHSs Besg== X-Gm-Message-State: AOAM533Ol67hSq7Yq9gGO2y7nNc3i2BGt6IFkES1ooevKfZToTIoMmpm MuaeoN9CbJDleR1eAOFGYKGHUAAciu0/McE/Pzi1anZIS669pw== X-Google-Smtp-Source: ABdhPJx/UmFhYwoqOEitMuTfCq1F+8Oah0ONqtLxKdQB6BTD+jAWM3XrfgI9pqCq3geEdC1SkQrt+KS8/R0/BtswF+Y= X-Received: by 2002:a25:d392:: with SMTP id e140mr76233669ybf.70.1609273352701; Tue, 29 Dec 2020 12:22:32 -0800 (PST) MIME-Version: 1.0 References: <20201229194144.17824-1-ashish.sadanandan@gmail.com> <20201229121008.3644fed4@hermes.local> In-Reply-To: <20201229121008.3644fed4@hermes.local> From: Ashish Sadanandan <ashish.sadanandan@gmail.com> Date: Tue, 29 Dec 2020 13:22:04 -0700 Message-ID: <CAN44U23ao-Cc1h5eWhOuhr=2r6BP1nv9CUxxoz-O=-exi3W_Xg@mail.gmail.com> To: stephen@networkplumber.org Cc: olivier.matz@6wind.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Stephen, Should I reference the commit that created rte_mbuf_dyn.h for the Fixes tag? PS: this is my first time submitting a patch to DPDK, so forgive me if this is covered in the contributing doc, but I couldn't find anything that applied to this situation On Tue, Dec 29, 2020 at 1:10 PM Stephen Hemminger < stephen@networkplumber.org> wrote: > On Tue, 29 Dec 2020 12:41:44 -0700 > Ashish Sadanandan <ashish.sadanandan@gmail.com> wrote: > > > The header was missing the extern "C" directive which causes name > > mangling of functions by C++ compilers, leading to linker errors > > complaining of undefined references to these functions. > > > > Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com> > > Could you add a Fixes tag please? >