From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f48.google.com (mail-vk0-f48.google.com [209.85.213.48]) by dpdk.org (Postfix) with ESMTP id 61CA612001 for ; Tue, 16 Jan 2018 09:45:44 +0100 (CET) Received: by mail-vk0-f48.google.com with SMTP id g83so8923351vki.4 for ; Tue, 16 Jan 2018 00:45:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VOWN1xbiJSRsQZMGt1ARNiRKXkdzNzPBeDgTgHSyV2U=; b=GWoCr/cuT6lRcYAwcUQfWEiTq2SITPWCuGC9itn5cC44M4n1iDuFSKBZIIG7vzFbKx NAceA1+mIe+/028kBrx3Os3VDkan7VBlmTWdbXhwQX7xUSsaNOaQC5megskDa7EgADZY obv/zXvR8HqRL7C+hM8qK1jlgyM5z6fpC9eN1E6jNBcebPl0HpZ5oJh6Sf3MXOckUwyP RjUX81t8Z7Ah6CTcWf8j9hBs2rNWEjM+zeEMaHqu1uuIfk/yUay49FRHo2NT9eTYozzs ENFMvcP0557kn6yIv/yBcZ1+Yq9nZi3/ToobCq7h7aodm2q14w3YBOCKVDWAifqq3qtl Mn2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VOWN1xbiJSRsQZMGt1ARNiRKXkdzNzPBeDgTgHSyV2U=; b=rfChe4jt39n8eI/8s8Xjuct7iitG5coO3GNSqxBiX7rCp7tP/64RYQ5KpLL5r/JHzx PUnXr9EdZmXS8Tgm7VyTN2JPcdPYsM0FAefhNuHlJ1DrrDT9l8wDTqYAwileBGdkoKri Kx+nuwPsFCCNOIbhUUJLbecTN7N+6r757DBdOj1Lp+sej4xsWL5D+sphWJUxu1xgWpen z21fJ3XS7cc7pcIHfEfJfJQJ/BXaRFLqE3iez3RBScGXlhfUMyN4vOfHw4osvjFoe3EE ERfKpmkpVsO8J5LuqOh4fAbkctN1/MQnvLj9G4+K6CEsdG6Cb3wtv8iV+KBm9Xe+d7T4 6Glw== X-Gm-Message-State: AKwxytddfawrJt9KQGrFoo2YGaxoF61vxPID8Dvk6LBwmhLgJBTgrcug isAJrNQX9BocTtil5ss7nDZVshO9fte4MBM4QZQ= X-Google-Smtp-Source: ACJfBov79391qEb4MHVuhwjOUgyr48be+9qHtm5Sp/0QP88a3YlQiNTA7k0pN/tzskhoJbl7L2CdD1XAuv2OLM/ZwAE= X-Received: by 10.31.170.3 with SMTP id t3mr33325816vke.150.1516092343394; Tue, 16 Jan 2018 00:45:43 -0800 (PST) MIME-Version: 1.0 References: <1515790887-64502-1-git-send-email-george.dit@gmail.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B710648@shsmsx102.ccr.corp.intel.com> <20180116083958.hk4rtxfoa2y3uydk@platinum> In-Reply-To: <20180116083958.hk4rtxfoa2y3uydk@platinum> From: george.dit@gmail.com Date: Tue, 16 Jan 2018 08:45:32 +0000 Message-ID: To: Olivier Matz Cc: "Lu, Wenzhuo" , "dev@dpdk.org" , "Adrien Mazarguil (adrien.mazarguil@6wind.com)" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 08:45:44 -0000 Hi Lu, Oliver, Thanks for your feedback! You have a point here, flow commands are only a subset of the parser. Do you want me to create this new library and send another patch? I guess I have to use librte_cmdline as a template/example for creating the librte_flow_cmdline library. Best regards, Georgios On Tue, Jan 16, 2018 at 9:40 AM Olivier Matz wrote: > Hi Georgios, > > On Mon, Jan 15, 2018 at 01:30:35AM +0000, Lu, Wenzhuo wrote: > > Hi, > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Georgios Katsikas > > > Sent: Saturday, January 13, 2018 5:01 AM > > > To: olivier.matz@6wind.com > > > Cc: dev@dpdk.org; Georgios Katsikas > > > Subject: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to > > > librte_cmdline > > > > > > Signed-off-by: Georgios Katsikas > > Looks like a good idea to move this code to the lib. > > cc Adrien the author of this file, app/test-pmd/cmdline_flow.c. > > If the command line parsing of rte_flow is something that has some > chances to be shared among multiple applications, I agree it makes sense > to move it in a library. > > However, my opinion is that it would be better to have a specific > library for it, like librte_flow_cmdline, because I'm not sure that > people linking with librte_cmdline always want to pull the rte_flow > parsing code. > >