From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f193.google.com (mail-ua0-f193.google.com [209.85.217.193]) by dpdk.org (Postfix) with ESMTP id 46FB51B398 for ; Tue, 30 Jan 2018 09:25:56 +0100 (CET) Received: by mail-ua0-f193.google.com with SMTP id t6so6522494ual.7 for ; Tue, 30 Jan 2018 00:25:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o5/cRR5Y3h9FzXu084ILQmLvHMCIk0ZhDt8ZBpigbaA=; b=XRsPROim81nTtxtYyt9ti6i9yCsLZpIOfO7QlHvYJsLFtz+AZPTIGnd8QWiJWpMMZ2 7ZHYrnnS/oW6SKC4IdJ70wLewiC76AqmCU7yURomWhdKc6WvJj5FLRZ6ngs3LL2QsdhB zfykPo4cOACj7BQDCrBgrxDbTQPM8ZLzsE9t55Lau5jkqiBZpPHaVmz2UBdQO7kvOvhP lEwRY379xvnqx26/AFkPPeDq+pEaJ7axZK3im4Z4sqNRTurGtSwld8X5a9g+c208/Tqw WFBX9twV3acl8Xb4rogZ6jTMqHvgtMOqSetXd0Q/lXaDAMhOH4YtvSqjMabt4DXPEGBp UTMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o5/cRR5Y3h9FzXu084ILQmLvHMCIk0ZhDt8ZBpigbaA=; b=DyBQdNRv1wU7w8PFoIu7e1ODDwQxmhVgmWPGcE/KHTHauyZPiD3h1yIeOn7yQGbspG BaUBMClADXzq0nkx2AbvBJRnkstxYrTadDBYdiQpcXskiyZZTqZS3fjnd3NPd1S9zQuy NZ3RoSJ230dSbzborY6aQILaPKhaO/J4soItuX2AnHyqybfxMhizyUmxv5XkWS+eUyao jvXBWjy0ALwbDPB1rMIvq/ZSlkalnIaRjLFbrCJrgINPdjPOmMw5xc+eMNqRkqg8hy4S Wqeq9bpU/qwPN0RtTqw3Eb51ORa5HnvTdqMKdbe2HAwqU/lvlUKJHtD9fa1KB09SUROS T6mg== X-Gm-Message-State: AKwxytekiEGgn8YXpBJMXockSEBesjLYNkd429+QZdiZORFvwwe1PSJi gX385VFBnOG1vAvIPiZRuDqM6VKGfHFCol7R1g4= X-Google-Smtp-Source: AH8x226eVZIriO1s4znp9S355Tx7yVs74jB1+vJRl0nahglN/NUGrsTrrXADHpf59N9qucNihnC3LjISyyxG5JjGs/8= X-Received: by 10.176.4.102 with SMTP id 93mr21258422uav.128.1517300755412; Tue, 30 Jan 2018 00:25:55 -0800 (PST) MIME-Version: 1.0 References: <1516794816-12588-1-git-send-email-katsikas.gp@gmail.com> In-Reply-To: <1516794816-12588-1-git-send-email-katsikas.gp@gmail.com> From: Georgios Katsikas Date: Tue, 30 Jan 2018 08:25:44 +0000 Message-ID: To: wenzhuo.lu@intel.com, jingjing.wu@intel.com Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: move variables definition in source X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2018 08:25:56 -0000 Hi, This is a kind reminder to review this short patch. There seems to be 1 build failure out of 15, but the error looks irrelevant to the patch according to: http://dpdk.org/dev/patchwork/patch/34403/ Please let me know if there is something I could fix. Best regards, Georgios On Wed, Jan 24, 2018 at 12:53 PM Georgios P. Katsikas wrote: > From: Georgios Katsikas > > This patch moves the definition of 3 variables in testpmd.h > into the respective .c file. The idea behind this move is > to allow external applications to compile against testpmd > without throwing compilation errors related to multiple > definition of variables. > > Also, an extern dcb_q_mapping in testpmd.h is removed > since it appears that this variable is not defined > elsewhere in the tree. > > Signed-off-by: Georgios Katsikas > --- > app/test-pmd/testpmd.c | 18 ++++++++++++++++++ > app/test-pmd/testpmd.h | 7 +++---- > 2 files changed, 21 insertions(+), 4 deletions(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 5dc8cca..02e8787 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -91,6 +91,24 @@ uint8_t socket_num = UMA_NO_CONFIG; > uint8_t mp_anon = 0; > > /* > + * Store specified sockets on which memory pool to be used by ports > + * is allocated. > + */ > +uint8_t port_numa[RTE_MAX_ETHPORTS]; > + > +/* > + * Store specified sockets on which RX ring to be used by ports > + * is allocated. > + */ > +uint8_t rxring_numa[RTE_MAX_ETHPORTS]; > + > +/* > + * Store specified sockets on which TX ring to be used by ports > + * is allocated. > + */ > +uint8_t txring_numa[RTE_MAX_ETHPORTS]; > + > +/* > * Record the Ethernet address of peer target ports to which packets are > * forwarded. > * Must be instantiated with the ethernet addresses of peer traffic > generator > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h > index 47f8fa8..153abea 100644 > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -329,19 +329,19 @@ extern uint32_t bypass_timeout; /**< Store the NIC > bypass watchdog timeout */ > * Store specified sockets on which memory pool to be used by ports > * is allocated. > */ > -uint8_t port_numa[RTE_MAX_ETHPORTS]; > +extern uint8_t port_numa[RTE_MAX_ETHPORTS]; > > /* > * Store specified sockets on which RX ring to be used by ports > * is allocated. > */ > -uint8_t rxring_numa[RTE_MAX_ETHPORTS]; > +extern uint8_t rxring_numa[RTE_MAX_ETHPORTS]; > > /* > * Store specified sockets on which TX ring to be used by ports > * is allocated. > */ > -uint8_t txring_numa[RTE_MAX_ETHPORTS]; > +extern uint8_t txring_numa[RTE_MAX_ETHPORTS]; > > extern uint8_t socket_num; > > @@ -384,7 +384,6 @@ extern int16_t tx_rs_thresh; > > extern uint8_t dcb_config; > extern uint8_t dcb_test; > -extern enum dcb_queue_mapping_mode dcb_q_mapping; > > extern uint16_t mbuf_data_size; /**< Mbuf data space size. */ > extern uint32_t param_total_num_mbufs; > -- > 2.7.4 > >