DPDK patches and discussions
 help / color / mirror / Atom feed
From: Georgios Katsikas <katsikas.gp@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Wisam Monther <wisamm@nvidia.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches
Date: Sun, 11 Oct 2020 13:33:29 +0300
Message-ID: <CAN9HtFD-5AAkv-vqVwf7CBBeM-3Y38gq1kMmoj6PWxdQwg80jA@mail.gmail.com> (raw)
In-Reply-To: <1926489.DYHX6cUqRX@thomas>

Hi,

Thanks for the feedback Thomas.
Please see my updated patch, I hope it better explains the scope of this
work.

Best regards,
Georgios

On Tue, Oct 6, 2020 at 1:25 AM Thomas Monjalon <thomas@monjalon.net> wrote:

> 05/10/2020 19:16, Georgios Katsikas:
> > Hi,
> >
> > What is the conclusion?
> > I haven't seen this patch being committed yet.
>
> You missed updating the file doc/guides/tools/flow-perf.rst
>
>
> > On Thu, Sep 24, 2020 at 3:01 PM Wisam Monther <wisamm@nvidia.com> wrote:
> > >From: Georgios Katsikas
> > > >
> > > >* One can now configure the number of rules per batch
>
> Please develop a bit more what was the previous behaviour
> and what you mean by "batch" in this context.
>
> > > >* Refactored flow_count variable to rules_count as it is related to
> the
> > > newly
> > > >added rules_batch variable
> > > >* Added default values to usage function
> > > >
> > > >Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
> > >
> > > Acked-by: Wisam Jaddo <wisamm@nvidia.com>
>
> Wisam, you should not ack if the doc is not updated.
> Otherwise you will have to complete the doc update yourself ;)
>
>
>

  reply	other threads:[~2020-10-11 10:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24  9:10 Georgios Katsikas
2020-09-24 12:01 ` Wisam Monther
2020-10-05 17:16   ` Georgios Katsikas
2020-10-05 22:25     ` Thomas Monjalon
2020-10-11 10:33       ` Georgios Katsikas [this message]
2020-10-11 10:03 Georgios Katsikas
2020-11-03 11:26 ` Georgios Katsikas
2020-11-04  8:04   ` Wisam Monther
2020-11-04 11:11     ` Georgios Katsikas
2020-11-04 11:25       ` Wisam Monther
2020-11-04 20:46     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN9HtFD-5AAkv-vqVwf7CBBeM-3Y38gq1kMmoj6PWxdQwg80jA@mail.gmail.com \
    --to=katsikas.gp@gmail.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=wisamm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git