From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 74E7EA04B6;
	Sun, 11 Oct 2020 12:33:54 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 7FB3F1D567;
	Sun, 11 Oct 2020 12:33:45 +0200 (CEST)
Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com
 [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 2E7DF1D565
 for <dev@dpdk.org>; Sun, 11 Oct 2020 12:33:43 +0200 (CEST)
Received: by mail-ot1-f68.google.com with SMTP id l4so13136230ota.7
 for <dev@dpdk.org>; Sun, 11 Oct 2020 03:33:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=x/H2olVfA2avdMsKUSXyWFnLdhcMEdfft3rPD2h9IJg=;
 b=CaPCVeYNojIDuiatKn7cl7ZOIRtFWnEMeOSjeH34mrChE6bkh5wrDX1hGkSz0sQrW0
 SPgyNhUhf7DOmdIncKKPIjc/nxlbgHgQYIum13U+SbuJ7RBKONsMMnRXx/3X7HeGaZht
 kkmA1LhKlylj9CWuKMa9bZYO7sN9WDZnmbmMarmeOMgHRu2uwKMUg7X6dAEBhi6HGn1T
 UjezcNbG1u+6YP9aOfaBEQDRCOrJHo4U90ji5yzsU8GQuanw760NFnqo522sm9EPLnlE
 XXnGJCdZvWzn0PIr8XbpBDusMsk6YBHkzj1Mk7We4Q4nNFSPw3XIpLwRz5I02bCm4TcN
 lmDQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=x/H2olVfA2avdMsKUSXyWFnLdhcMEdfft3rPD2h9IJg=;
 b=oP6kVXF2UJuUpBUNoWp5SSjF5QzeQtNc8yMBYoKkUwLi3DIlgPnPjwlp7IDTHy1R0c
 qC8Dyh+CV++JLt2tgfsacV9lQ7jQm4pLdumM/0EFO7guWO8aw6x4UmV6p6eEifaG86fI
 RyBaA1jJfb+gin6YJC+3H2h2acHW85rW51LjVvYAN6L4yRmpqaN0UbggChWWYWyQqsBM
 VC8GS9GMaLBltgz3WQ9E1dHtnW4HnZ4w19YrgDpoV7HXHDJVo0nLXhRoa9YqIvIHMV8S
 buVtysFffrAbRIQ9Wldd1K8s2eRy/a6tf929uopL4d0Ck7YuWtuzyoLOS2vnOtfPuiIq
 Mx1A==
X-Gm-Message-State: AOAM533n9rZe43/pYgu+KgIl9ek/ovIQ2URiZJp+VEnoUXkqWX1JkOcx
 sbngpU2w1DdYH26AMGb4rfZVSkNTf7RfKlvThpg=
X-Google-Smtp-Source: ABdhPJyj7MGK+WJ4FGiMUQtdu+vBZANGoTbMu2PrZ32cs4lLL9zev8E6WPFmxKbCGAKxRt6VPkH2fl1w2m2szoGbOrg=
X-Received: by 2002:a9d:22e4:: with SMTP id y91mr3589475ota.72.1602412421541; 
 Sun, 11 Oct 2020 03:33:41 -0700 (PDT)
MIME-Version: 1.0
References: <20200924091053.8373-1-katsikas.gp@gmail.com>
 <BL0PR12MB24196BDE1BBFBF195987C565A4390@BL0PR12MB2419.namprd12.prod.outlook.com>
 <CAN9HtFAoP5_U7PNTkjEQTFEseTYF6nk-OnKdyhgo=p2JswMS2w@mail.gmail.com>
 <1926489.DYHX6cUqRX@thomas>
In-Reply-To: <1926489.DYHX6cUqRX@thomas>
From: Georgios Katsikas <katsikas.gp@gmail.com>
Date: Sun, 11 Oct 2020 13:33:29 +0300
Message-ID: <CAN9HtFD-5AAkv-vqVwf7CBBeM-3Y38gq1kMmoj6PWxdQwg80jA@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Wisam Monther <wisamm@nvidia.com>, dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

Thanks for the feedback Thomas.
Please see my updated patch, I hope it better explains the scope of this
work.

Best regards,
Georgios

On Tue, Oct 6, 2020 at 1:25 AM Thomas Monjalon <thomas@monjalon.net> wrote:

> 05/10/2020 19:16, Georgios Katsikas:
> > Hi,
> >
> > What is the conclusion?
> > I haven't seen this patch being committed yet.
>
> You missed updating the file doc/guides/tools/flow-perf.rst
>
>
> > On Thu, Sep 24, 2020 at 3:01 PM Wisam Monther <wisamm@nvidia.com> wrote:
> > >From: Georgios Katsikas
> > > >
> > > >* One can now configure the number of rules per batch
>
> Please develop a bit more what was the previous behaviour
> and what you mean by "batch" in this context.
>
> > > >* Refactored flow_count variable to rules_count as it is related to
> the
> > > newly
> > > >added rules_batch variable
> > > >* Added default values to usage function
> > > >
> > > >Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
> > >
> > > Acked-by: Wisam Jaddo <wisamm@nvidia.com>
>
> Wisam, you should not ack if the doc is not updated.
> Otherwise you will have to complete the doc update yourself ;)
>
>
>