From: Tetsuya Mukawa <tetsuya.mukawa.1@gmail.com>
To: dev@dpdk.org
Subject: [dpdk-dev] About 'CONFIG_RTE_EAL_UNBIND_PORTS'
Date: Thu, 29 Aug 2013 16:54:55 +0900 [thread overview]
Message-ID: <CANCx15TfHxEYyiX+c4oma7R+yma0FXnJ9+QGT_fwk6OPZp2Wow@mail.gmail.com> (raw)
Hi folks,
Someone, could you please let me know what is a case that I need to
enable 'CONFIG_RTE_EAL_UNBIND_PORTS'?
Also, if 'CONFIG_RTE_EAL_UNBIND_PORTS' is enabled, it seems an
application dumps error when it exits
This error is displayed by following code.
--------------------------------------
pci_exit_process(struct rte_pci_device *dev)
{
..............
if (close(dev->intr_handle.fd) == -1){
RTE_LOG(ERR, EAL, "Error closing interrupt handle\n");
return -1;
}
--------------------------------------
I've confirmed when the issue occurs, always the fd is '0'.
I guess that the fd should be initialized as '-1', but actually it is
initialized as '0'.
So during finalization, pci_exit_process() may try to close STDIN.
(But I am not sure why closing STDIN returns error. STDIN might be
already closed by somewhere?)
Anyway, here is a patch I wrote to fix the issue.
Is this correct?
--------------------------------------
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c
b/lib/librte_eal/linuxapp/eal/eal_pci.c
index c793148..7bb03e9 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
@@ -519,6 +519,8 @@ pci_scan_one(const char *dirname, uint16_t domain,
uint8_t bus,
dev->addr.devid = devid;
dev->addr.function = function;
+ dev->intr_handle.fd = -1;
+
/* get vendor id */
rte_snprintf(filename, sizeof(filename), "%s/vendor", dirname);
if (eal_parse_sysfs_value(filename, &tmp) < 0) {
@@ -718,7 +720,8 @@ pci_exit_process(struct rte_pci_device *dev)
RTE_LOG(ERR, EAL, "Error with munmap\n");
return -1;
}
- if (close(dev->intr_handle.fd) == -1){
+ if ((dev->intr_handle.fd != -1) &&
+ (close(dev->intr_handle.fd) == -1)) {
RTE_LOG(ERR, EAL, "Error closing interrupt handle\n");
return -1;
}
--------------------------------------
Also here is the procedure to reproduce the issue.
1. Prepare Fedora16(3.6.11-4.fc16.x86_64) as a guest OS.
2. Add 2 network interfaces(virtio-net) to the guest.
3. Compile dpdk-1.3.2r2 with CONFIG_RTE_EAL_UNBIND_PORTS' enabled on the guest.
4. Run testpmd using virtio-net-pmd on the guest.
5. Quit testpmd, and check error messages.
Best Regards,
Tetsuya Mukawa
next reply other threads:[~2013-08-29 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 7:54 Tetsuya Mukawa [this message]
2013-09-02 15:57 ` Thomas Monjalon
2013-09-03 1:39 ` Tetsuya Mukawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANCx15TfHxEYyiX+c4oma7R+yma0FXnJ9+QGT_fwk6OPZp2Wow@mail.gmail.com \
--to=tetsuya.mukawa.1@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).