DPDK patches and discussions
 help / color / mirror / Atom feed
From: Vladimir Medvedkin <medvedkinv@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] lib/rib: Add Routing Information Base library
Date: Wed, 12 Jul 2017 02:17:00 +0300	[thread overview]
Message-ID: <CANDrEH=YqVWCtb0hQM6rt3Od30M16rNU8fg7UCcya+_rToEo0g@mail.gmail.com> (raw)
In-Reply-To: <20170711132807.4cbceb72@xeon-e3>

Thanks, I'll change it.

2017-07-11 23:28 GMT+03:00 Stephen Hemminger <stephen@networkplumber.org>:

> On Tue, 11 Jul 2017 19:33:05 +0000
> Medvedkin Vladimir <medvedkinv@gmail.com> wrote:
>
> > +
> > +#define ROUNDUP(x, y)   ((((x - 1) >> (32 - y)) + 1) << (32 - y))
>
> There is already RTE_ALIGN_FLOOR/RTE_ALIGN_CEIL
>
>
> > +#define RTE_DIR24_8_GET_TBL24_P(fib, ip)                     \
> > +     ((void *)&((uint8_t *)fib->tbl24)[(ip &                 \
> > +             RTE_DIR24_8_TBL24_MASK) >> (8 - fib->nh_sz)])   \
> > +
>
> Why is this a macro and not an inline function.
> The expresion could also be split up to be simpler, and compiler
> would generate same result.
>



-- 
Regards,
Vladimir

  reply	other threads:[~2017-07-11 23:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 19:33 [dpdk-dev] [RFC] Add RIB library Medvedkin Vladimir
2017-07-11 19:33 ` [dpdk-dev] [PATCH] lib/rib: Add Routing Information Base library Medvedkin Vladimir
2017-07-11 20:28   ` Stephen Hemminger
2017-07-11 23:17     ` Vladimir Medvedkin [this message]
2017-07-11 20:31 ` [dpdk-dev] [RFC] Add RIB library Stephen Hemminger
2017-07-11 23:13   ` Vladimir Medvedkin
2017-08-14 10:51 ` Bruce Richardson
2017-08-14 22:28   ` Vladimir Medvedkin
2017-08-15  8:23     ` Bruce Richardson
2017-08-15 10:49       ` Vladimir Medvedkin
2017-08-15 11:01         ` Vladimir Medvedkin
2018-01-16  0:41           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANDrEH=YqVWCtb0hQM6rt3Od30M16rNU8fg7UCcya+_rToEo0g@mail.gmail.com' \
    --to=medvedkinv@gmail.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).