From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 991A645A8D; Fri, 4 Oct 2024 14:01:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BA3A40EDF; Fri, 4 Oct 2024 14:01:18 +0200 (CEST) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by mails.dpdk.org (Postfix) with ESMTP id 3F20C40EDF for ; Fri, 4 Oct 2024 14:01:17 +0200 (CEST) Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3e034fac53bso1012416b6e.3 for ; Fri, 04 Oct 2024 05:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728043276; x=1728648076; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LG6J7DX3QHvcP74kUBvSwSBuH8sGorFJcUUkpYPm9Dg=; b=lQ69Yd+pqJUZesTOCCeIroIYUqdbIQpTRCHJuGiZUIFHhAonW3ydunUJUTTmZq6GTN a8AMJ04mJrfMLNqVQ6LWvopvMaCneMg3Tu8vmAyvNWQnoaQ34NFvkkpJNZ4IfFZaFAYq k5/FEUsPrQ98cRrsHLYyzQNYnaz1/WJIYNk0wdOOIsjxxWoF8DR41V7lC0X/7vNl/gNA MCmuHjOrBWfK0dEYlqcpzL2hXDFaGOo+qRxyxB1wHtGnV27LvMlS724W2DdK6wFI/BwE PLzdVlpOOMxtPtEwfxLvjQjW2keCy0aj/pvTAKau5x6eXXBoCFFKohzDyNIur0rHXy9Q 6iNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728043276; x=1728648076; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LG6J7DX3QHvcP74kUBvSwSBuH8sGorFJcUUkpYPm9Dg=; b=sXABev9Xma47X2OFky/enUU197Ei5/Tpa0E2dTXpp7cPlSYCr4+cD/ykPJ7hESsCaA xjlJStT4vQbc8S0A5Hqw1wfn05n84yeR8uTWPM/BZZBz7nmQgIXQ2Nf5S/1VM3vwbGz2 JzHq5qJyXRyAN0JDrz0ctAl8GmJyUkwrn4P6Q5QANqD0ZGSIph5bwg59Vfq0lTVzHTfu wtOw8a7WHKOf6cTnBq4yCvUJdLZO8yGQ3tPMoHI+iUkhbvqQA7yKEybbQXDksAAwImuU wGm20ENctzDv/TaeGWtjAHvJuaEGNaOklhXHU5lAn/uAih0Y8hKuWMsbG3Wm10JUoLWZ wshA== X-Forwarded-Encrypted: i=1; AJvYcCWQFuqIr6HPbRfhXTZXfPHDDVt22SAWg//FdfvB3YX/mgIVzI8eg10gDjo+OcVyARHvqbw=@dpdk.org X-Gm-Message-State: AOJu0YwIlvXA9e6FZBrXaQ1mipTREnMfzohKikFN3MkaEpP9L2odG6rB x2I6Ykb4t1BOMSYZrI5fa7gi/GbV4aTCYDUgjw2Kh2YG36+yqjmePeurVu/+4hhVg/t7MbsPTtV Zu1ItUQpcj8M8b5oFzh2v7FXB2e8= X-Google-Smtp-Source: AGHT+IHl3/u7BsN9IfEgHuCHZxyvhu17HTeCzonb33zf5z1NOvulCsBZjL0hlXr7hPMdQciaU9/WGeiqUEEU03fbnTY= X-Received: by 2002:a05:687c:2c0b:b0:277:ca2f:905 with SMTP id 586e51a60fabf-287c229f6a4mr1349497fac.29.1728043275790; Fri, 04 Oct 2024 05:01:15 -0700 (PDT) MIME-Version: 1.0 References: <20240906170649.1325254-1-vladimir.medvedkin@intel.com> In-Reply-To: From: Vladimir Medvedkin Date: Fri, 4 Oct 2024 13:01:04 +0100 Message-ID: Subject: Re: [PATCH] fib: network byte order IPv4 lookup To: David Marchand Cc: Vladimir Medvedkin , Bruce Richardson , dev@dpdk.org, rjarry@redhat.com, mb@smartsharesystems.com, Konstantin Ananyev Content-Type: multipart/alternative; boundary="0000000000009c36ad0623a56da3" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000009c36ad0623a56da3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi David, Thanks for pointing out this problem, I'll send a fix and v2. =D0=BF=D0=BD, 30 =D1=81=D0=B5=D0=BD=D1=82. 2024=E2=80=AF=D0=B3. =D0=B2 16:0= 7, David Marchand : > On Sat, Sep 28, 2024 at 1:51=E2=80=AFAM David Marchand > wrote: > > > > On Fri, Sep 6, 2024 at 1:07=E2=80=AFPM Vladimir Medvedkin > > wrote: > > > > > > Previously when running rte_fib_lookup IPv4 addresses must have been = in > > > host byte order. > > > > > > This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed = on > > > fib create, which will allow to have IPv4 in network byte order on > > > lookup. > > > > > > Signed-off-by: Vladimir Medvedkin > > > > _mm512_shuffle_epi8 requires avx512bw, so the dir24_8 AVX512 > > implementation can only compile when such feature is supported and > > enabled. > > Like the trie AVX512 implem. > > > > IOW, we are missing an update of the library meson.build. > > I also suspect that both this added support in the dir24_8 > implementation and the existing trie are missing some runtime check on > RTE_CPUFLAG_AVX512BW in get_vector_fn. > Can we get a fix for trie and a respin of this current patch? > > Thanks. > > > -- > David Marchand > > --=20 Regards, Vladimir --0000000000009c36ad0623a56da3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi David,

Thanks for pointing out this problem, I'll send a fix and v2.


=D0=BF=D0=BD, 30 =D1=81=D0=B5=D0=BD=D1=82. 2024=E2=80=AF=D0=B3. = =D0=B2 16:07, David Marchand <david.marchand@redhat.com>:
On Sat, Sep= 28, 2024 at 1:51=E2=80=AFAM David Marchand
<david.ma= rchand@redhat.com> wrote:
>
> On Fri, Sep 6, 2024 at 1:07=E2=80=AFPM Vladimir Medvedkin
> <= vladimir.medvedkin@intel.com> wrote:
> >
> > Previously when running rte_fib_lookup IPv4 addresses must have b= een in
> > host byte order.
> >
> > This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be pas= sed on
> > fib create, which will allow to have IPv4 in network byte order o= n
> > lookup.
> >
> > Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>=
>
> _mm512_shuffle_epi8 requires avx512bw, so the dir24_8 AVX512
> implementation can only compile when such feature is supported and
> enabled.
> Like the trie AVX512 implem.
>
> IOW, we are missing an update of the library meson.build.

I also suspect that both this added support in the dir24_8
implementation and the existing trie are missing some runtime check on
RTE_CPUFLAG_AVX512BW in get_vector_fn.
Can we get a fix for trie and a respin of this current patch?

Thanks.


--
David Marchand



--
Regards,
Vladimir
--0000000000009c36ad0623a56da3--