From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f41.google.com (mail-qg0-f41.google.com [209.85.192.41]) by dpdk.org (Postfix) with ESMTP id 757DA30D for ; Wed, 4 Jun 2014 11:58:10 +0200 (CEST) Received: by mail-qg0-f41.google.com with SMTP id j5so15410831qga.0 for ; Wed, 04 Jun 2014 02:58:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=0jbNabGUFyMb34xHQOUw0bIO3srNzB82X/1j/EQhFas=; b=saFRSsETr6c0Bhl67OXzvjFxnu4xmsl6+ckuofnhTrhCxoo/r2IfeTUJev/wM7ochZ BIabYqnJ9Yfzc3sREQiTKB3n+u5RHZuCAxQZT/DV23FIfDbSoizVYJnqXO5r0xmt5YxV Fkpqlmzd362Ba0Nsm7jDWmV1eqODiMj9XiRlqc3vDyeOebEtuEgyiejfx1D/F9gXgklT DL1PbMK+/N5KpOLnquWrGA8P2DiINByUm5j6/qeoQM32V16zF2vYuXMF4UNcPGotvar/ HMZbFZsGlc2q8pltVGss0KUcsStDLHZkX21UT/8XvtBu37Dqqe1INzu+6Zt8fv3rwna8 dO+g== MIME-Version: 1.0 X-Received: by 10.224.157.17 with SMTP id z17mr4154863qaw.72.1401875903043; Wed, 04 Jun 2014 02:58:23 -0700 (PDT) Received: by 10.140.30.55 with HTTP; Wed, 4 Jun 2014 02:58:22 -0700 (PDT) In-Reply-To: <1431824.kSt8MFELsZ@xps13> References: <1400543506-24717-1-git-send-email-medvedkinv@gmail.com> <1431824.kSt8MFELsZ@xps13> Date: Wed, 4 Jun 2014 13:58:22 +0400 Message-ID: From: Vladimir Medvedkin To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/3] ixgbe: Add L2 Ethertype, SYN and Five tuple queue filters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jun 2014 09:58:10 -0000 Hi Thomas, Sorry for late reply, I'm on vacation now. 1. I'm not shure about other NICs but Intel. API for Intel NICs is generic enough, even more generic than Jingjing's API because of pool logic. Besides I think it's more properly make rx_queue as part of filter struct for Jingjing's etype and 5-tuple filters implementation. 2. I'll try to send checked patch today. Regards, Vladimir. 2014-05-28 3:09 GMT+04:00 Thomas Monjalon : > Hi Vladimir, > > Seems like hardware filtering becomes useful these days :) > > 2014-05-19 19:51, Vladimir Medvedkin: > > This patchset adds in addition to the Flow Director filters L2 Ethertype, > > SYN and Five tuple queue filters to route packets according to ethertype, > > l4 proto, source/destination ip/ports pool and presence of SYN flag in > TCP > > packet. Unlike http://dpdk.org/ml/archives/dev/2014-May/002512.html this > > gives capability to work with pools. This patch functionality can be > merged > > with the patch above. > > 2 comments: > > 1) Do you have a good confidence that this new API is generic enough to be > used by other NICs than ixgbe? > > 2) Could you try to check your patches with the kernel script > checkpatch.pl, > please? > > Thanks > -- > Thomas >