From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f179.google.com (mail-lb0-f179.google.com [209.85.217.179]) by dpdk.org (Postfix) with ESMTP id 88D8BC5E4 for ; Fri, 19 Jun 2015 18:23:45 +0200 (CEST) Received: by lbbti3 with SMTP id ti3so75235240lbb.1 for ; Fri, 19 Jun 2015 09:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=1iRl+wqjuKYk05Igas+N2JK1rYGdun2fP0hg7qe3Ml8=; b=T9ivvipenMzaW5STyDsxp59/9ukd50/f0MC9C1USoLg26oVj5KxPGKMzad7cVfvj6m BpQ3PO2RWLluXtrhkSIQSLoT5p3iLhPgqSDtZlslakRYd4xf79gZhoTmwPQ6Fa6Jj4st rZQP7Y7VfY+JbVlVnbO4uFWb4wGwMF1b1JAOD0AKAozGlXDATYb2WO1yDEub62IkU6My XaZfG2n4V7A7m+SM5Dc3g37lvYMmzjFoPGcnBmOUrk1ad2Dw/8De7amzTMKsg/rWVx92 Hb05q2R9YfA8YfNKI+/NU1uL888Gqml4f6vJTdv1tdjtwWYYN1lZHVk0ghjXRoxWdSbg LOdg== MIME-Version: 1.0 X-Received: by 10.112.130.68 with SMTP id oc4mr18226397lbb.87.1434731025184; Fri, 19 Jun 2015 09:23:45 -0700 (PDT) Received: by 10.114.10.229 with HTTP; Fri, 19 Jun 2015 09:23:45 -0700 (PDT) In-Reply-To: <59AF69C657FD0841A61C55336867B5B03455A867@IRSMSX103.ger.corp.intel.com> References: <1434725778-22887-1-git-send-email-medvedkinv@gmail.com> <59AF69C657FD0841A61C55336867B5B03455A867@IRSMSX103.ger.corp.intel.com> Date: Fri, 19 Jun 2015 19:23:45 +0300 Message-ID: From: Vladimir Medvedkin To: "Richardson, Bruce" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] Add unit test for thash library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 16:23:45 -0000 2015-06-19 19:14 GMT+03:00 Richardson, Bruce : > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vladimir Medvedkin > > Sent: Friday, June 19, 2015 3:56 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] Add unit test for thash library > > > > Add unit test for thash library > > > Missing sign-off. > > > --- > > app/test/Makefile | 2 + > > app/test/autotest_data.py | 13 ++++ > > app/test/test_thash.c | 164 > > ++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 179 insertions(+) > > create mode 100644 app/test/test_thash.c > > > > diff --git a/app/test/Makefile b/app/test/Makefile > > index 5cf8296..fc6a247 100644 > > --- a/app/test/Makefile > > +++ b/app/test/Makefile > > @@ -85,6 +85,8 @@ SRCS-$(CONFIG_RTE_LIBRTE_HASH) +=3D test_hash.c > > SRCS-$(CONFIG_RTE_LIBRTE_HASH) +=3D test_hash_perf.c > > SRCS-$(CONFIG_RTE_LIBRTE_HASH) +=3D test_hash_functions.c > > > > +SRCS-y +=3D test_thash.c > > + > > SRCS-$(CONFIG_RTE_LIBRTE_LPM) +=3D test_lpm.c > > SRCS-$(CONFIG_RTE_LIBRTE_LPM) +=3D test_lpm6.c > > > > diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py > > index 0c3802b..7653f09 100644 > > --- a/app/test/autotest_data.py > > +++ b/app/test/autotest_data.py > > @@ -475,6 +475,19 @@ non_parallel_test_group_list =3D [ > > }, > > ] > > }, > > +{ > > + "Prefix" : "thash", > > + "Memory" : "32", > > + "Tests" : > > + [ > > + { > > + "Name" : "Thash autotest", > > + "Command" : "thash_autotest", > > + "Func" : default_autotest, > > + "Report" : None, > > + }, > > + ] > > +}, > > > > # > > # Please always make sure that ring_perf is the last test! > > diff --git a/app/test/test_thash.c b/app/test/test_thash.c > > new file mode 100644 > > index 0000000..4c863cc > > --- /dev/null > > +++ b/app/test/test_thash.c > > @@ -0,0 +1,164 @@ > > +/*- > > + * BSD LICENSE > > + * > > + * Copyright(c) 2015 Vladimir Medvedkin > > + * All rights reserved. > > + * > > + * Redistribution and use in source and binary forms, with or withou= t > > + * modification, are permitted provided that the following condition= s > > + * are met: > > + * > > + * * Redistributions of source code must retain the above copyrigh= t > > + * notice, this list of conditions and the following disclaimer. > > + * * Redistributions in binary form must reproduce the above > > copyright > > + * notice, this list of conditions and the following disclaimer = in > > + * the documentation and/or other materials provided with the > > + * distribution. > > + * * Neither the name of Intel Corporation nor the names of its > > + * contributors may be used to endorse or promote products deriv= ed > > + * from this software without specific prior written permission. > > + * > > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTO= RS > > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS > > FOR > > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE > COPYRIGHT > > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, > > INCIDENTAL, > > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF > > USE, > > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON > > ANY > > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TO= RT > > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE > > USE > > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH > DAMAGE. > > + */ > > + > > +//#include > > +//#include > > +//#include > > +#include > > +//#include > > +//#include > > Please just delete the commented out lines, there is no need to keep them= . > Deleted in v2 patch. > > > + > > +#include > > +#include > > +#include > > + > > +#include "test.h" > > + > > +#include > > + > > +struct test_thash_v4 { > > + uint32_t dst_ip; > > + uint32_t src_ip; > > + uint16_t dst_port; > > + uint16_t src_port; > > + uint32_t hash_l3; > > + uint32_t hash_l3l4; > > +}; > > + > > +struct test_thash_v6 { > > + uint8_t dst_ip[16]; > > + uint8_t src_ip[16]; > > + uint16_t dst_port; > > + uint16_t src_port; > > + uint32_t hash_l3; > > + uint32_t hash_l3l4; > > +}; > > + > > +/*From 82599 Datasheet p.309 =EF=BF=BD=C2=A77.1.2.8.RSS Verification S= uite*/ > > Strange characters present in the above line (they don't show up for me i= n > mutt though). > I'd also suggest dropping the page number, as that can probably change > across different versions of the datasheet. [I have a (very) old copy of > the datasheet myself, and it's only on page 248 there. It's obviously tim= e > for me to pull down an updated copy :-)). > > Strange characters removed in v2. I will remove page number in next patc= h. > /Bruce >