From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <medvedkinv@gmail.com>
Received: from mail-la0-f53.google.com (mail-la0-f53.google.com
 [209.85.215.53]) by dpdk.org (Postfix) with ESMTP id 371AF902
 for <dev@dpdk.org>; Tue, 28 Jul 2015 21:08:13 +0200 (CEST)
Received: by laah7 with SMTP id h7so74631390laa.0
 for <dev@dpdk.org>; Tue, 28 Jul 2015 12:08:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=e67xWmnF2PtMAgIciB3oVH4cb9fNLAHIV3dzH0CcdOw=;
 b=klUZnFotgcybf73WHlFvH+5xpDXRnBubWs243u+gk5DhfHOBpUtuO5VmYvFt4auc9V
 TzRlyx0GoSGmClA6Z61N/V2QzRQkvANRF/1nkjus1CqW3zfxj+SX6sF2wyA6zJZ/UTcZ
 hDouS7+BgnzR21eUfnguEEK8h2Qzo8sGfPIBsJououEFu+LFu1aJoYd7wJgo2IMSeQ97
 xqAoVcFF61DQlNAtARI4Y+Mx8i1TZ3cmu4XHTub7drOhBhmo13y5gJW3+MBwRKEAvvHu
 HjEAl3htmAFW2J6+CYYreEJFHjRpv5GJtHyxIxg1rJJlWsixtc1BY4sL6ND6pQzbUePt
 Whxw==
MIME-Version: 1.0
X-Received: by 10.152.20.106 with SMTP id m10mr35360771lae.7.1438110492691;
 Tue, 28 Jul 2015 12:08:12 -0700 (PDT)
Received: by 10.114.10.229 with HTTP; Tue, 28 Jul 2015 12:08:12 -0700 (PDT)
In-Reply-To: <3885263.OLndnQdN2M@xps13>
References: <1438088792-16344-1-git-send-email-medvedkinv@gmail.com>
 <1831659.nSDl63dTav@xps13>
 <CANDrEHnA8DP5wRbeAp-E+hTMieLb8=_xOWjB5A74Na+DG0jhCg@mail.gmail.com>
 <3885263.OLndnQdN2M@xps13>
Date: Tue, 28 Jul 2015 22:08:12 +0300
Message-ID: <CANDrEHmZQ7+RJ6e_X2TFS0FTca5AThzzH_i5X+HtQwky16qH6A@mail.gmail.com>
From: Vladimir Medvedkin <medvedkinv@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Make the thash library arch-independent
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2015 19:08:13 -0000

2015-07-28 19:05 GMT+03:00 Thomas Monjalon <thomas.monjalon@6wind.com>:

> 2015-07-28 18:33, Vladimir Medvedkin:
> > 2015-07-28 16:47 GMT+03:00 Thomas Monjalon <thomas.monjalon@6wind.com>:
> > > 2015-07-28 09:06, Vladimir Medvedkin:
> > > Please explain how it was broken and how you fixed it.
> > > It would be interesting to know which part is __SSE3__ and __SSE__.
> > >
> >  As mentioned in http://dpdk.org/ml/archives/dev/2015-July/022020.html
> > compilation fails on non x86 architectures( in that case it was tile).
> So I
> > add for optimized code, which uses SSE3 intrinsics, non optimized general
> > version.
>
> I know. I was requesting an updated commit with explanations:
>         build is broken because...
>         x86 version uses SSE3...
>         Some code is enclosed with __SSE__, not __SSE3__ because...
>
Oh, that's my mistake. Will fix this typo in the next patch.

>
> What happens if it is built with SSE3 support but run on
> a CPU without such support?
> Please check how it is done for ACL.
>
> > > > +#ifdef __SSE3__
> > > > +#include <rte_vect.h>
> > > > +#endif /* __SSE3__ */
> > >
> > > Comments after short ifdef block are not needed.
> > >
> > Should I delete it?
>
> Yes please.
>
> > > > +#ifndef XMM_SIZE
> > > > +#define XMM_SIZE     16
> > >
> > > Why is it needed?
> > >
> >  because there is no defines for XMM_SIZE on non X86 architectures
>
> Why XMM_SIZE is needed on non x86 arch?
>
Ok, I will leave union rte_thash_tuple unaligned for non x86 arch