From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <medvedkinv@gmail.com>
Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com
 [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id 4E05D726F
 for <dev@dpdk.org>; Fri, 27 Apr 2018 08:45:41 +0200 (CEST)
Received: by mail-qk0-f181.google.com with SMTP id p186so627611qkd.1
 for <dev@dpdk.org>; Thu, 26 Apr 2018 23:45:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=h057RgkRqM4i9WMtKdpkisH6BdgJzPMyoK5flXpxN3E=;
 b=SYlU24EdWYU3G6pY50WhwhpbDWWLUfoRWa/50D/sHvRuj7hFiQ70rRjmIy/QX30PSt
 s3JVe+9O9btkoYH8smkE+y/mBpdFr8ATyb3SxNhL6mAnAaWbpYpDJ0DeQLXkcGK25wJ+
 THf0CFfaltEifUJnV3AekRPlB0bLSdPzDt/P1OGmwiDkk18i+wPLOOSSmQtMIXlNCRDD
 r8PPFXwwVRuN/AVtI0bV8vJ3Y4/LbTmF2mn2ZNn+2QCe2wsfhnfHhu8W6PrsTZ9jJCPy
 +KjLkVhCvPC8QVKD73z5TX94LBPflnH7jwvkGyPeyF4pNpZbPTvHWiecl/UrUJ7KjB13
 yDvA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=h057RgkRqM4i9WMtKdpkisH6BdgJzPMyoK5flXpxN3E=;
 b=jN7/F6x4QdiCuqgHikC7WBQr80jV7qY/a8vZiTikfy2XgzCKd+iFVk3WeuM+LVKsq0
 Q/zAvsz5LQQrbN/hco2/A0gdACbux2NudoxLJi/lUvs+Gvj1Dzs7sI3yn1feG8Q3YDYZ
 +CU/BOl38HNBRGCziAUGjRSSoJ0wS7u9ftoTbqe6QJVuhIThcwviYwjI2tn9ToiOvMeJ
 LixQNmbtg5NTixzCN0g0RNHDnNNmJmu3skDiFh+q4x7ykgleVkvbwsrC/8BGwm6AwgW/
 fqVLgwfWRUC6+4pQgNt8EZbKA12XFUwOfahPW4vc1kF+pg1HFlmuCWh5u0OPap76eQL0
 Y0CQ==
X-Gm-Message-State: ALQs6tCrH4YpYPX4tG2mz2Ozmzg7VlQ8M49mJ8f54NLq3eUV6ua4lQnQ
 yCQV4NaHIiRg8WIb78wHw4KQYc76P/ZZf2SKCs4=
X-Google-Smtp-Source: AB8JxZqmuwoVotU5+ehSDIulKdoPVUGhwQ8VwQ1VgQWFIa7SzxPHhDJQ6DKCT/etyWGaoMYP01xq+XYibvGdIz9E9EA=
X-Received: by 10.55.154.79 with SMTP id c76mr815877qke.215.1524811540769;
 Thu, 26 Apr 2018 23:45:40 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.200.37.27 with HTTP; Thu, 26 Apr 2018 23:45:40 -0700 (PDT)
In-Reply-To: <20180426152045.07c20b45@xeon-e3>
References: <1524780214-23196-1-git-send-email-medvedkinv@gmail.com>
 <1524780214-23196-2-git-send-email-medvedkinv@gmail.com>
 <20180426152045.07c20b45@xeon-e3>
From: Vladimir Medvedkin <medvedkinv@gmail.com>
Date: Fri, 27 Apr 2018 09:45:40 +0300
Message-ID: <CANDrEHmgjCnhjqxwBV0XGq=Ytoqc8vVfn5WH_-ZbTgFrcfzG2w@mail.gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 thomas@monjalon.net, cristian.dumitrescu@intel.com
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v4 1/4] Add RIB library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2018 06:45:41 -0000

Hi Stephen,

Thanks for comments! Will fix in next version.

2018-04-27 1:20 GMT+03:00 Stephen Hemminger <stephen@networkplumber.org>:

> On Fri, 27 Apr 2018 01:03:31 +0300
> Medvedkin Vladimir <medvedkinv@gmail.com> wrote:
>
> > +             /**
> > +              * Intermediate node found.
> > +              * Previous rte_rib_tree_lookup_exact() returned NULL
> > +              * but node with proper search criteria is found.
> > +              * Validate intermediate node and return.
> > +              */
> > +             if ((key == (*tmp)->key) && (depth == (*tmp)->depth)) {
>
> Comments with /** are intended to be docbook comments.
> This is not a docbook comment for a function.
>



-- 
Regards,
Vladimir