From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <medvedkinv@gmail.com>
Received: from mail-la0-f45.google.com (mail-la0-f45.google.com
 [209.85.215.45]) by dpdk.org (Postfix) with ESMTP id B5C03C520
 for <dev@dpdk.org>; Tue, 28 Jul 2015 17:33:38 +0200 (CEST)
Received: by lahh5 with SMTP id h5so70981228lah.2
 for <dev@dpdk.org>; Tue, 28 Jul 2015 08:33:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=BwlC7RWZrkqXhSBa1h/DNcarsQbKoTki038AHVDefqw=;
 b=kp6kFiOa2ojw1n1K1efrljxLyAJXD39CUz9jD5tiAghNiBoM7O3bbeCMh8AB0NFJCV
 TgoAV6XFkb3DJn3eBzTiee0MVxUAqxYoILCb35+MMyCrgUaodmp5xK8hdK73Dnsr3ZqA
 UR2R2moDZpB8Mqpmt871ERcrdCkTEzxCYv6QSG5wKXcfUIzwrZuoJgQ6yVAvcYAJsZR2
 kYboVcG/CdB3c5Plc5zxV6YNV9zHH/5hPl4CBDaiyrjg5aQelWaI/CWq5Dx1o0D1xdiy
 fRxvPZ5JPbPe/QvhPvEX+hoTaLmhK4Fp+OrfCpwX+tMjGfYEbm7tY3ww24Gm7LRekeuv
 /E1A==
MIME-Version: 1.0
X-Received: by 10.152.21.227 with SMTP id y3mr33140360lae.24.1438097618362;
 Tue, 28 Jul 2015 08:33:38 -0700 (PDT)
Received: by 10.114.10.229 with HTTP; Tue, 28 Jul 2015 08:33:38 -0700 (PDT)
In-Reply-To: <1831659.nSDl63dTav@xps13>
References: <1438088792-16344-1-git-send-email-medvedkinv@gmail.com>
 <1831659.nSDl63dTav@xps13>
Date: Tue, 28 Jul 2015 18:33:38 +0300
Message-ID: <CANDrEHnA8DP5wRbeAp-E+hTMieLb8=_xOWjB5A74Na+DG0jhCg@mail.gmail.com>
From: Vladimir Medvedkin <medvedkinv@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Make the thash library arch-independent
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2015 15:33:39 -0000

Hi Thomas,


2015-07-28 16:47 GMT+03:00 Thomas Monjalon <thomas.monjalon@6wind.com>:

> Hi Vladimir,
> Thanks for fixing.
> Comments below.
>
> 2015-07-28 09:06, Vladimir Medvedkin:
> > Signed-off-by: Vladimir Medvedkin <medvedkinv@gmail.com>
>
> Please explain how it was broken and how you fixed it.
> It would be interesting to know which part is __SSE3__ and __SSE__.
>
 As mentioned in http://dpdk.org/ml/archives/dev/2015-July/022020.html
compilation fails on non x86 architectures( in that case it was tile). So I
add for optimized code, which uses SSE3 intrinsics, non optimized general
version.

>
> > +#ifdef __SSE3__
> > +#include <rte_vect.h>
> > +#endif /* __SSE3__ */
>
> Comments after short ifdef block are not needed.
>
Should I delete it?

>
> > +#ifndef XMM_SIZE
> > +#define XMM_SIZE     16
>
> Why is it needed?
>
 because there is no defines for XMM_SIZE on non X86 architectures

Regards,
Vladimir