From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nikhil.jagtap@gmail.com>
Received: from mail-it0-f42.google.com (mail-it0-f42.google.com
 [209.85.214.42]) by dpdk.org (Postfix) with ESMTP id 33ECD1DB1
 for <dev@dpdk.org>; Wed, 31 Aug 2016 12:02:17 +0200 (CEST)
Received: by mail-it0-f42.google.com with SMTP id n75so86085815ith.0
 for <dev@dpdk.org>; Wed, 31 Aug 2016 03:02:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:from:date:message-id:subject:to:cc;
 bh=/x1CPyI3EdypcZOIGC0ZvrOXGeY4/KgzXZyJBXWdxAk=;
 b=N7Fqa5kCoaQpp53jGR/+o1OvV8v2hri7Ua5ki9EmJcvbuwzLlC9mnYIfuRx7V9hIqh
 13cN5ssm7Pv1HeuNfysJzGfZWCoMZvymfNt7G430A+oaNMZ4ABEGZJ9gMR4i48ml7Suy
 XlSg/7EVSPgxeeKbx+8ziup5af07PQ3wKe/hd17SXqLJJ1OLT1TZsMAKoXroVRS0P3AA
 uxblIR6sgHN/BDJHsjy+CGjlZC5Awtix6twMx9Sdjd/+IEFXMJry5UJt7ph1Qm7TCGuB
 qHdWJTF46rkj3X9U8u/bsubljrPgUSsIN7u0lHRtcHHRrSDMwIzHQohgV6Be3gdIeHms
 PICQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc;
 bh=/x1CPyI3EdypcZOIGC0ZvrOXGeY4/KgzXZyJBXWdxAk=;
 b=FkBsEmZ72/4wGBvm+tyX1jMuostAjB2VN6gpkTnghliBaxuT6bJWc5vvip27AzCzRG
 7ywFqJzXpYzwIPt4B1aNgM0RA2KMYeeTF39LMB23nR2ub9wbg5OtQlLeu5lLEPDSADwn
 Qo8DNc9bLkrXxzjCLseXPxyPUq/syQ5fHOL5nlBv4gBedxp5OH0ko4C7MzJz8A8WWj5i
 fONikA6SrMsIt7kNH1/oUCPOlgcZBKIupEzzNzVOd0V9tHzETIW10UH/feG4riHBjSLc
 vct0PrmBL6oLK00BUNa9P1x1Q0HYdbmMFktN2A/AXrKw1KmMRoA4RVa9/cMWEa3utEza
 dUwg==
X-Gm-Message-State: AE9vXwNRpXO96qu6xxuOynSagVGVIJsOT5EcUyXIHdOVtVLwUuehGhACPVyZhBZ+elGbG18RbrXuDAsK+iHU2g==
X-Received: by 10.36.103.214 with SMTP id u205mr30681950itc.88.1472637736628; 
 Wed, 31 Aug 2016 03:02:16 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.36.53.23 with HTTP; Wed, 31 Aug 2016 03:02:16 -0700 (PDT)
From: Nikhil Jagtap <nikhil.jagtap@gmail.com>
Date: Wed, 31 Aug 2016 15:32:16 +0530
Message-ID: <CANKBMf138jW7AKZCRjvfj4huJDi04k6CHw_5sM_aLUpbihTUCg@mail.gmail.com>
To: cristian.dumitrescu@intel.com
Cc: dev@dpdk.org
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: [dpdk-dev] meter: excess token bucket update in srtcm
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Aug 2016 10:02:17 -0000

Hi,

As per srTCM RFC 2697, we should be updating the E bucket only after the C
bucket overflows.
"Thereafter, the token counts Tc and Te are updated CIR times per second as
follows:
     o If Tc is less than CBS, Tc is incremented by one, else
     o if Te is less then EBS, Te is incremented by one, else
     o neither Tc nor Te is incremented."

However in the current DPDK implementation of srTCM, we are updating both
the buckets simultaneously at the same rate (CIR). This will result in a
token accumulation rate of (2*CIR). This seems like a bug to me. Can you
confirm this?

Nikhil