From: Nikhil Jagtap <nikhil.jagtap@gmail.com>
To: cristian.dumitrescu@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] meter: excess token bucket update in srtcm
Date: Tue, 6 Sep 2016 09:43:20 +0530 [thread overview]
Message-ID: <CANKBMf1bYNXr7yNPhQAuhDEA=99u3+1fnrfLXbNkp++B-47pmw@mail.gmail.com> (raw)
In-Reply-To: <CANKBMf138jW7AKZCRjvfj4huJDi04k6CHw_5sM_aLUpbihTUCg@mail.gmail.com>
Hi,
Can someone please comment on this?
Nikhil
On 31 August 2016 at 15:32, Nikhil Jagtap <nikhil.jagtap@gmail.com> wrote:
> Hi,
>
> As per srTCM RFC 2697, we should be updating the E bucket only after the C
> bucket overflows.
> "Thereafter, the token counts Tc and Te are updated CIR times per second
> as follows:
> o If Tc is less than CBS, Tc is incremented by one, else
> o if Te is less then EBS, Te is incremented by one, else
> o neither Tc nor Te is incremented."
>
> However in the current DPDK implementation of srTCM, we are updating both
> the buckets simultaneously at the same rate (CIR). This will result in a
> token accumulation rate of (2*CIR). This seems like a bug to me. Can you
> confirm this?
>
> Nikhil
>
>
next prev parent reply other threads:[~2016-09-06 4:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 10:02 Nikhil Jagtap
2016-09-06 4:13 ` Nikhil Jagtap [this message]
2016-09-06 5:10 ` Ramia, Kannan Babu
2016-09-06 6:29 ` Nikhil Jagtap
2016-09-06 9:56 ` Dumitrescu, Cristian
2016-09-07 6:22 ` Nikhil Jagtap
2016-09-09 21:00 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANKBMf1bYNXr7yNPhQAuhDEA=99u3+1fnrfLXbNkp++B-47pmw@mail.gmail.com' \
--to=nikhil.jagtap@gmail.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).