From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f48.google.com (mail-it0-f48.google.com [209.85.214.48]) by dpdk.org (Postfix) with ESMTP id AC29137AA for ; Tue, 6 Sep 2016 06:13:21 +0200 (CEST) Received: by mail-it0-f48.google.com with SMTP id i184so174264325itf.1 for ; Mon, 05 Sep 2016 21:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=jAqF1PKfCOhzfLqhjvZSuKoe2+6F5NA0AuddNhdq9fA=; b=BD25M+XPqREp+ALMv5nZ969mEZDMXniw4cGi6TUlOxQMISkOHAUDyw+bpZDTJCoY7/ 1PUSwrFF4PewdCvS9K6uZkYff/GQJ/hC9FuDUzWOM8WI4Fmy2o+P48wvjA0EhMQQDLFa pcwyu+cjCuPvdXUNli9oxNKtTDtb9i6NFeu6iGiQ7GjJ3bpaMGC9j1cWkUtj2LLKTlfj CrYag3fAZ9huWGF3Yw094GiGTiEJzweEDrjnq/wVKjoj9rSMf8EcS3/U4ATcNUmf+riP BGcZEkycOW7CjnqO2NJOiuOpA2Sg9vmeET6uQW/s2J6P7hTgIe6ymCI9TIy7T7jXLuBN 0Wxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jAqF1PKfCOhzfLqhjvZSuKoe2+6F5NA0AuddNhdq9fA=; b=b+sSXliD5KZpTIPBS61KJ5vWBL4+/EcrD5jWVtmkYNsI8ApSEaMGd5V+t2UgxE7aGS Py18Qn3MwhAyr2SRMcC7/639F9kkRMGGNjn3zPBzo76DD8XtazYwto77rPRFkmc8KCmD mnqgo7Nl18F3dKuKgK1r2JxrnZ1CCo+6HG/EMAsALsb3ieLmCmB/nJEP6a9EyrVxLFBJ 6Dg3cEccsTP9uwDuPuGeJBRNnT55FTPuHVhkEudfTDirjDiW4H9CKcl+n07iLNkopfbs bcMh24WJ9h0U2Zplf2/FnxXp10A5gmd+8rq5MjgROv3ieBgx9k5oYsz6axrmm72HWH3y Yraw== X-Gm-Message-State: AE9vXwMS1fggNwrsOKzg0AtpU9KgetZRARO/srAi8XVRByn1B6F6Ba2a8qUpDNERrkOsPAuJ4jSjzqKUA8KjGA== X-Received: by 10.107.7.232 with SMTP id g101mr2563207ioi.53.1473135201064; Mon, 05 Sep 2016 21:13:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.53.23 with HTTP; Mon, 5 Sep 2016 21:13:20 -0700 (PDT) In-Reply-To: References: From: Nikhil Jagtap Date: Tue, 6 Sep 2016 09:43:20 +0530 Message-ID: To: cristian.dumitrescu@intel.com Cc: dev@dpdk.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] meter: excess token bucket update in srtcm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Sep 2016 04:13:21 -0000 Hi, Can someone please comment on this? Nikhil On 31 August 2016 at 15:32, Nikhil Jagtap wrote: > Hi, > > As per srTCM RFC 2697, we should be updating the E bucket only after the C > bucket overflows. > "Thereafter, the token counts Tc and Te are updated CIR times per second > as follows: > o If Tc is less than CBS, Tc is incremented by one, else > o if Te is less then EBS, Te is incremented by one, else > o neither Tc nor Te is incremented." > > However in the current DPDK implementation of srTCM, we are updating both > the buckets simultaneously at the same rate (CIR). This will result in a > token accumulation rate of (2*CIR). This seems like a bug to me. Can you > confirm this? > > Nikhil > >