From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f65.google.com (mail-oi0-f65.google.com [209.85.218.65]) by dpdk.org (Postfix) with ESMTP id F08A358F1 for ; Tue, 6 Sep 2016 08:29:40 +0200 (CEST) Received: by mail-oi0-f65.google.com with SMTP id w78so6943486oie.0 for ; Mon, 05 Sep 2016 23:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rfTZ4eM0yLfr1NXVVVDsAoSQOUDR2vnTLIbzScn/GS4=; b=zjDgFxWuCB1wbgce1Pdb9IpCvVSG7K/I9Aq+hNO33p/9GzSb0cgHiKwfj23dgqLTS4 g6E488e4OC4aWCC25OrMWWr1XXoMGHEAUijZS9v5SxBb+KZU/DCag21tbUF4ZzE5Teeu 3GSNr5XD1H2OxO1luQ4XbQcsP+p4v5T8cCZk+G7sbxlAzKu82QSHibgzeuRd6PAp69Fq VdjUeVb9Vl8xJ8cy/3nR1geo2uEEgcRxugxkeotR/j0HrO8sRnt8J1/m4i/1ADiH1elz vYPk6SLrrndxAhj6EUEu91an6RNJ0bZ/dTCR6apkzcnXd1N8J/fncEd5auknHpONxrfa gNDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rfTZ4eM0yLfr1NXVVVDsAoSQOUDR2vnTLIbzScn/GS4=; b=Mz3dNhKVdXgpf72YDO4m08nbrDpvefE1uGfDX5Wzfgz6xRmg2xRf/vsyQ992t3Py50 jHoCHud4v5exH2eIQ1Rg41N7RiO79ogzBmAXWXZF+vdfnalEPsflG8lwtCDpS/M3Ogaj jWnF2CfLQwKkHDowlh2d/fMwLwkE7vPWjtP9vI3M17HLWdUusn2bg3c42es8Jnk9dgVY QQ01XbaQDKRFXTAuufr9XcCuNejQPnKoQzovZ1c2Nqk115WdaSmD8wPY0+RdmqYqyHzo cojZT4qJHZuE+OFykcLjoDvI+MDuxKcV5rz8ftxzhObi2U0xgfK7OtniUJHlo+0teWhT t+xw== X-Gm-Message-State: AE9vXwN+Ra3eCpi/0vsJPDqBQjkCtR2LRxLWeGK6G+JnXB6TTWZWxB5lbVt4G/8tdUiVmCaEQgG+Q83ILbVr7w== X-Received: by 10.107.7.232 with SMTP id g101mr2964835ioi.53.1473143380297; Mon, 05 Sep 2016 23:29:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.53.23 with HTTP; Mon, 5 Sep 2016 23:29:39 -0700 (PDT) In-Reply-To: <682698A055A0F44AA47192B20141149762528A49@BGSMSX102.gar.corp.intel.com> References: <682698A055A0F44AA47192B20141149762528A49@BGSMSX102.gar.corp.intel.com> From: Nikhil Jagtap Date: Tue, 6 Sep 2016 11:59:39 +0530 Message-ID: To: "Ramia, Kannan Babu" Cc: "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] meter: excess token bucket update in srtcm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Sep 2016 06:29:41 -0000 Hi Kannan, Thank you for your reply. I will submit the patch on similar lines I had used for my test. Regards, Nikhil On 6 September 2016 at 10:40, Ramia, Kannan Babu < kannan.babu.ramia@intel.com> wrote: > Hi Nikhil > > You could submit a patch, something like that below logic > > If( ((n_periods * m->cir_bytes_per_period) > (m->cbs-m->tc)) > te = m->te + ((n_periods * m->cir_bytes_per_period) - > (m->cbs-m->tc)); > > and this should be done before m->tc update. > > > Regards > Kannan Babu > > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nikhil Jagtap > Sent: Tuesday, September 6, 2016 9:43 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] meter: excess token bucket update in srtcm > > Hi, > Can someone please comment on this? > > Nikhil > > On 31 August 2016 at 15:32, Nikhil Jagtap wrote: > > > Hi, > > > > As per srTCM RFC 2697, we should be updating the E bucket only after > > the C bucket overflows. > > "Thereafter, the token counts Tc and Te are updated CIR times per > > second as follows: > > o If Tc is less than CBS, Tc is incremented by one, else > > o if Te is less then EBS, Te is incremented by one, else > > o neither Tc nor Te is incremented." > > > > However in the current DPDK implementation of srTCM, we are updating > > both the buckets simultaneously at the same rate (CIR). This will > > result in a token accumulation rate of (2*CIR). This seems like a bug > > to me. Can you confirm this? > > > > Nikhil > > > > >