From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30EA3A0545; Thu, 11 Aug 2022 05:48:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C407A40DDA; Thu, 11 Aug 2022 05:48:12 +0200 (CEST) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by mails.dpdk.org (Postfix) with ESMTP id D086F40A87 for ; Thu, 11 Aug 2022 05:48:11 +0200 (CEST) Received: by mail-lf1-f42.google.com with SMTP id c17so23941997lfb.3 for ; Wed, 10 Aug 2022 20:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc; bh=+pTg+jHY2RKPSqISHCc+fGwBUq6boqwfzw1Wj6ZxWWs=; b=xbLxFSizzI2U85ZOh/YtdJgD2sVpxa4ZWcwxqivtr3r0klLtaS0BiUZnjEaUaM89eI h/hx6CfGblKToGXkqRwvcxAKZ69lylos0ByBrm4bdn/hM6NXUhGo0PFy6XyGsaWFhvk+ x5fND8fQJo4g21HDZRp0sZZIQy8K79UZqgvzkFGJ3FaRNJj/QKtfya9vAjy3XY/G2Mec OwUJE8SiaVrBhcCF6NRDa2RwofY0Us+isuCigVXcQwqwsow2xC2A6CbNWX3gzlYPPCC+ dG7GitbDt5XzykLqiqZESm5lgqyle0ELpv55jGOl2iGUVd0yr90heEUCM7h9ri2Ypng7 O2Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc; bh=+pTg+jHY2RKPSqISHCc+fGwBUq6boqwfzw1Wj6ZxWWs=; b=N9BYqVZ6ETafH8FlofDomzRVLQdMHbbH2lFTchKkmcqtz3tsqxKEbUcD8RVfxudQvO VAdAcuTr5ZfMJ5plcfJITYEJdsUC3+WhTebjyJ+7CKpL8LQdbec8LBekB39UUCKpKfu3 D2mn0Kkp4qWsDdCXb+iPCebNhcBaQDZ2TP42Amq0GLDYWmifBm3uBPKhrbVqdwQxeA69 ibkWUYrWGm0Ds7AurjGflfL5dYq0/0kapKalbzOb5Zhxn0viHLvs6V6/UQOOC3qNzJH1 xa6IaiRqr6icfenXpExs5U2zLGpnx5Xw4ttRd9SZ6MQI89HDBWkiwQz5jq+VPjrDldlw F89Q== X-Gm-Message-State: ACgBeo1WlKs2tRW4YOBgpJZZ1JCUhAgJqMTw4OF5/hqYweJmygWAHTLy mHfvC3hYKRpQLfpodqoOfKEQpOcm4Fal0gUBj5gxt2if1kwGqZa/ X-Google-Smtp-Source: AA6agR6A8p5efqqxCVA3hCJFh9irPFw5rlU16xzGkK/Qfb2PK456nqWf3+uwwajSQDlKevWeNzmCX1t/MWBuJrIeTJ8= X-Received: by 2002:ac2:5cc5:0:b0:48d:ab8c:c1d8 with SMTP id f5-20020ac25cc5000000b0048dab8cc1d8mr421088lfq.504.1660189690932; Wed, 10 Aug 2022 20:48:10 -0700 (PDT) MIME-Version: 1.0 References: <20220701103726.4190485-1-huzaifa.rahman@emumba.com> In-Reply-To: <20220701103726.4190485-1-huzaifa.rahman@emumba.com> From: Huzaifa Rahman Date: Thu, 11 Aug 2022 08:48:00 +0500 Message-ID: Subject: Re: [PATCH] docs: change the doc to highlight the allowed multicast addresses To: dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000c9c5bb05e5ef08ec" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000c9c5bb05e5ef08ec Content-Type: text/plain; charset="UTF-8" Hi, Is there any other work/changes required for this patch to be submitted? Thanks On Fri, Jul 1, 2022 at 3:37 PM huzaifa.rahman wrote: > Bugzilla ID: 802 > > The ipv4_multicast example does not work with any multicast IPs. > Only a selected few IPs are allowed to send pakcets. These IPs > are listed in an mcast_group_table array along with their respective > port masks. A normal user would not know about this behaviour since > there is no mention of it in the docs > > Added the mcast_group_table in the docs so user would know which > IPs are allowed. > > Signed-off-by: huzaifa.rahman > --- > doc/guides/sample_app_ug/ipv4_multicast.rst | 8 +++++++- > examples/ipv4_multicast/main.c | 2 ++ > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/sample_app_ug/ipv4_multicast.rst > b/doc/guides/sample_app_ug/ipv4_multicast.rst > index f87f7be57e..7c49212c64 100644 > --- a/doc/guides/sample_app_ug/ipv4_multicast.rst > +++ b/doc/guides/sample_app_ug/ipv4_multicast.rst > @@ -22,7 +22,13 @@ There are two key differences from the L2 Forwarding > sample application: > > The lookup method is the Four-byte Key (FBK) hash-based method. > The lookup table is composed of pairs of destination IPv4 address (the > FBK) > -and a port mask associated with that IPv4 address. > +and a port mask associated with that IPv4 address. By default, the > following IP addresses and their respective > +port masks are added: > + > +.. literalinclude:: ../../../examples/ipv4_multicast/main.c > + :language: c > + :start-after: Create the mcast group table. 8< > + :end-before: >8 End of create mcast group table. > > .. note:: > > diff --git a/examples/ipv4_multicast/main.c > b/examples/ipv4_multicast/main.c > index bdcaa3bcd1..c086149eca 100644 > --- a/examples/ipv4_multicast/main.c > +++ b/examples/ipv4_multicast/main.c > @@ -139,6 +139,7 @@ struct mcast_group_params { > uint16_t port_mask; > }; > > +/* Create the mcast group table. 8< */ > static struct mcast_group_params mcast_group_table[] = { > {RTE_IPV4(224,0,0,101), 0x1}, > {RTE_IPV4(224,0,0,102), 0x2}, > @@ -156,6 +157,7 @@ static struct mcast_group_params mcast_group_table[] = > { > {RTE_IPV4(224,0,0,114), 0xE}, > {RTE_IPV4(224,0,0,115), 0xF}, > }; > +/* >8 End of create mcast group table. */ > > /* Send burst of packets on an output interface */ > static void > -- > 2.25.1 > > --000000000000c9c5bb05e5ef08ec Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Is there any other work= /changes required for this patch to be submitted?

Thanks

On Fri, Jul 1, 2022 at 3:37 PM huzaifa.rahman <huzaifa.rahman@emumba.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">Bugzilla ID: 802

The ipv4_multicast example does not work with any multicast IPs.
Only a selected few IPs are allowed to send pakcets. These IPs
are listed in an mcast_group_table array along with their respective
port masks. A normal user would not know about this behaviour since
there is no mention of it in the docs

Added the mcast_group_table in the docs so user would know which
IPs are allowed.

Signed-off-by: huzaifa.rahman <huzaifa.rahman@emumba.com>
---
=C2=A0doc/guides/sample_app_ug/ipv4_multicast.rst | 8 +++++++-
=C2=A0examples/ipv4_multicast/main.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 | 2 ++
=C2=A02 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/doc/guides/sample_app_ug/ipv4_multicast.rst b/doc/guides/sampl= e_app_ug/ipv4_multicast.rst
index f87f7be57e..7c49212c64 100644
--- a/doc/guides/sample_app_ug/ipv4_multicast.rst
+++ b/doc/guides/sample_app_ug/ipv4_multicast.rst
@@ -22,7 +22,13 @@ There are two key differences from the L2 Forwarding sam= ple application:

=C2=A0The lookup method is the Four-byte Key (FBK) hash-based method.
=C2=A0The lookup table is composed of pairs of destination IPv4 address (th= e FBK)
-and a port mask associated with that IPv4 address.
+and a port mask associated with that IPv4 address. By default, the followi= ng IP addresses and their respective
+port masks are added:
+
+.. literalinclude:: ../../../examples/ipv4_multicast/main.c
+=C2=A0 =C2=A0 :language: c
+=C2=A0 =C2=A0 :start-after: Create the mcast group table. 8<
+=C2=A0 =C2=A0 :end-before: >8 End of create mcast group table.

=C2=A0.. note::

diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.= c
index bdcaa3bcd1..c086149eca 100644
--- a/examples/ipv4_multicast/main.c
+++ b/examples/ipv4_multicast/main.c
@@ -139,6 +139,7 @@ struct mcast_group_params {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 uint16_t port_mask;
=C2=A0};

+/* Create the mcast group table. 8< */
=C2=A0static struct mcast_group_params mcast_group_table[] =3D {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {RTE_IPV4(224,0,0,1= 01), 0x1},
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {RTE_IPV4(224,0,0,1= 02), 0x2},
@@ -156,6 +157,7 @@ static struct mcast_group_params mcast_group_table[] = =3D {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {RTE_IPV4(224,0,0,1= 14), 0xE},
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {RTE_IPV4(224,0,0,1= 15), 0xF},
=C2=A0};
+/* >8 End of create mcast group table. */

=C2=A0/* Send burst of packets on an output interface */
=C2=A0static void
--
2.25.1

--000000000000c9c5bb05e5ef08ec--