From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B54F5A055F; Fri, 27 May 2022 07:15:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A69BC427F0; Fri, 27 May 2022 07:15:09 +0200 (CEST) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by mails.dpdk.org (Postfix) with ESMTP id 664DC4114A for ; Fri, 27 May 2022 07:15:08 +0200 (CEST) Received: by mail-lf1-f42.google.com with SMTP id l30so126715lfj.3 for ; Thu, 26 May 2022 22:15:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=+BR1ogit9BSuGXnRmFuCYCTZO3WzHemxyh2NTNeXBjQ=; b=hu2kViFCyjN8ThIK7nYdXzCmUSbuiT8WBonUZv2nwQK72Jh1XsCuoVTf1iSTgdBsF9 w7+FJnM4q46olAG2mqTpXoYJRYEFUyAkOd1nVocKIwfaYd5zNM/FTGx8ymV3vLu51CBq xhfOAugpheQWivbIX0Cigd2GttGjs6BmAoEYoC22S8M2IvVxF4ias834VI4le3mGQZST dBN6+F4m5vxA1awlhsDXV1rfJhC+y3+qpdHJqdxuKq4BiMLuwJx2TtRoY7XfoIMfrwpj MMAEqc8FJIHrX+YFn7Eq/rs2WY4Mt+SemWi69cquY053TYU2vYe4qY5DfTJWmJX/cr1c GGHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=+BR1ogit9BSuGXnRmFuCYCTZO3WzHemxyh2NTNeXBjQ=; b=Y/o3C2YivWj0yHf/bJsPbWbseL8NcHv3n2wjtyIw07ue2MuJIA1h4zIbqdVOgCJUEH ErK8Ctjh41rR2yco2+jGjVbBpRTkDpquyEkIl5k/uyKUgJr4oGspJSIzK/wLCctYUQyj /PEv5c1MBPKYeW0zxoEAMYgKk0WFdg9a5WinmpyXYyI3LhEjPuMDtDJy9q8Q3+lqhoEz fnbO5aYdtd7Syi1nmVdcAhUStdMnPSxJTnYP4N2M/WJYFD+99lM8lWFKzdbJ646NOcof PdatZUs+3JTUyaH0gsw34LAkdckIWQck+X0gUogtKdmbbtg2rszc3tEFvo2LlnoSr1wB sE8Q== X-Gm-Message-State: AOAM531LF6NXwztW9AGS9UUUJOdjCqRoKO3/TrkivS4PAFq+p8dvYad2 XKE8E+8oxlClH906OgxLY0XFgl+iyz4tcDJby2HiIHC6qDZyVEFs X-Google-Smtp-Source: ABdhPJzVN8gSPI2ujYw5W32KYpzmofiEJoZA5nX0ALq0jfOISJKLdbt/FyKE386t1ln+8pB/9CZoBnffgfqvD9UUJSA= X-Received: by 2002:a05:6512:1108:b0:477:93a5:328e with SMTP id l8-20020a056512110800b0047793a5328emr29507725lfg.546.1653628507904; Thu, 26 May 2022 22:15:07 -0700 (PDT) MIME-Version: 1.0 References: <20220324053124.8085-1-huzaifa.rahman@emumba.com> In-Reply-To: <20220324053124.8085-1-huzaifa.rahman@emumba.com> From: Huzaifa Rahman Date: Fri, 27 May 2022 10:14:57 +0500 Message-ID: Subject: Re: [PATCH] ethtool: correct format strings according to the arguments To: dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000cdee1a05dff76308" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000cdee1a05dff76308 Content-Type: text/plain; charset="UTF-8" Hi, The following tests are failing but my patch is not related to anything related to these. Please re-run the tests. Failed Tests: - mtu_update - scatter Thanks, Huzaifa On Thu, Mar 24, 2022 at 10:31 AM huzaifa.rahman wrote: > The corrected format strings are not consistent with the > given arguments. So they are changed accordingly. > > Signed-off-by: huzaifa.rahman > --- > examples/ethtool/ethtool-app/main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/examples/ethtool/ethtool-app/main.c > b/examples/ethtool/ethtool-app/main.c > index 1f011a9321..ea8332e49c 100644 > --- a/examples/ethtool/ethtool-app/main.c > +++ b/examples/ethtool/ethtool-app/main.c > @@ -208,7 +208,7 @@ static int worker_main(__rte_unused void *ptr_data) > &ptr_port->mac_addr); > if (ret != 0) { > > rte_spinlock_unlock(&ptr_port->lock); > - printf("Failed to get MAC address > (port %u): %s", > + printf("Failed to get MAC address > (port %i): %s", > ptr_port->idx_port, > rte_strerror(-ret)); > return ret; > @@ -284,11 +284,11 @@ int main(int argc, char **argv) > rte_exit(EXIT_FAILURE, "rte_eal_init(): Failed"); > > cnt_ports = rte_eth_dev_count_avail(); > - printf("Number of NICs: %i\n", cnt_ports); > + printf("Number of NICs: %u\n", cnt_ports); > if (cnt_ports == 0) > rte_exit(EXIT_FAILURE, "No available NIC ports!\n"); > if (cnt_ports > MAX_PORTS) { > - printf("Info: Using only %i of %i ports\n", > + printf("Info: Using only %u of %i ports\n", > cnt_ports, MAX_PORTS > ); > cnt_ports = MAX_PORTS; > -- > 2.25.1 > > --000000000000cdee1a05dff76308 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

The following tests are= failing but my patch is not related to anything related to these. Please r= e-run the tests.
Failed Tests:
		- mtu_update
		- scatter

Thanks,
Huzaifa

On Thu, Mar 24, 2= 022 at 10:31 AM huzaifa.rahman <huzaifa.rahman@emumba.com> wrote:
The corrected format strings are not consiste= nt with the
given arguments. So they are changed accordingly.

Signed-off-by: huzaifa.rahman <huzaifa.rahman@emumba.com>
---
=C2=A0examples/ethtool/ethtool-app/main.c | 6 +++---
=C2=A01 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool= -app/main.c
index 1f011a9321..ea8332e49c 100644
--- a/examples/ethtool/ethtool-app/main.c
+++ b/examples/ethtool/ethtool-app/main.c
@@ -208,7 +208,7 @@ static int worker_main(__rte_unused void *ptr_data)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 &ptr= _port->mac_addr);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (ret !=3D 0) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 rte_spin= lock_unlock(&ptr_port->lock);
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0printf(&q= uot;Failed to get MAC address (port %u): %s",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0printf(&q= uot;Failed to get MAC address (port %i): %s",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0ptr_port->idx_port,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0rte_strerror(-ret));
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return r= et;
@@ -284,11 +284,11 @@ int main(int argc, char **argv)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 rte_exit(EXIT_FAILU= RE, "rte_eal_init(): Failed");

=C2=A0 =C2=A0 =C2=A0 =C2=A0 cnt_ports =3D rte_eth_dev_count_avail();
-=C2=A0 =C2=A0 =C2=A0 =C2=A0printf("Number of NICs: %i\n", cnt_po= rts);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0printf("Number of NICs: %u\n", cnt_po= rts);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (cnt_ports =3D=3D 0)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 rte_exit(EXIT_FAILU= RE, "No available NIC ports!\n");
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (cnt_ports > MAX_PORTS) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0printf("Info: = Using only %i of %i ports\n",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0printf("Info: = Using only %u of %i ports\n",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 cnt_ports, MAX_PORTS
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 );
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cnt_ports =3D MAX_P= ORTS;
--
2.25.1

--000000000000cdee1a05dff76308--