Re: [PATCH] mlx5: initially reading xstats does not cause seg fault

[Huzaifa Rahman <huzaifa.rahman@emumba.com>]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

The bugzilla ID of this bug is 701:
https://bugs.dpdk.org/show_bug.cgi?id=701

On Tue, Aug 23, 2022 at 12:33 PM Kamil Vojanec <vojanec@cesnet.cz> wrote:

> On 8/18/22 14:30, huzaifa.rahman wrote:
>
> Bugzilla ID: 296
>
> the size of counters array in mlx5_xstats_get() was smaller
> than the memory we are setting for this array in
> mlx5_os_read_dev_counters(). due to which the extra memory is
> corrupted and thus corrupting the seemingly unrelated variables.
> this happens at the first run only because the n function arg
> of mlx5_xstats_get() which is used to init counters array is
> initialized by adding the preceding statistics which in our case
> (i.e first run) is zero. after the initialization in
> mlx5_os_stats_init() the mlx5_stats_n is populated and thus from
> then onward the counters array size is correct
>
> my changes will only affect the flow of the first run when we
> need to initialize stats in mlx5_os_stats_init(). the size of the
> counters array is set according the mlx5_stats_n variable. by doing
> this we will avoid the memset corrupting other variables` memory
>
> Signed-off-by: huzaifa.rahman <huzaifa.rahman@emumba.com> <huzaifa.rahman@emumba.com>
>
> Tested-by: Kamil Vojanec <vojanec@cesnet.cz> <vojanec@cesnet.cz>
>
>

[-- Attachment #2: Type: text/html, Size: 1835 bytes --]